| commit | dac7785050e083dce091a558408dbde98fd9d169 | [log] [tgz] |
|---|---|---|
| author | Joshua Seaton <joshuaseaton@google.com> | Sun Dec 30 17:37:54 2018 -0800 |
| committer | Joshua Seaton <joshuaseaton@google.com> | Mon Dec 31 11:08:33 2018 -0800 |
| tree | 043d0cb593840833b05e70ebef5952482e4793f9 | |
| parent | 078c34aaee784ec4737e5fe71c0392d54de0f02d [diff] |
[botanist] Fix arm64 paving bug. new(Foo) != nil new returns a pointer to a Foo struct that is 'zeroed'; this is not a nil pointer. This fixes a bug in the arm64 codepath (i.e., for vim2s) in which the following was happening: -images.json for an arm64 build did not designate a kernel (with a --boot switch) (WAI) -in Pave(), in iterating over the images looking for a kernel, it tries to reassign a pointer defined as new(Image); because no kernel was found it passes this non-nil-but-garbage pointer to transfer() which fails in trying to open it. Change-Id: I2d1e6eec4f3103bd30b52c932b836206c769ab33
This repo contains tools used in Fuchsia build and development.
Go packages from here are automatically built and uploaded to CIPD and Google Storage by bots using the tools recipe. To add a tool to the build:
builder_mixins section with name: "tools".properties_j to add a string to the packages list:"fuchsia.googlesource.com/tools/cmd/your-new-tool"