Google Git
Sign in
fuchsia / tools / 1f7aa42174bc755e32ff0210bdcf19bcaa76815a
commit1f7aa42174bc755e32ff0210bdcf19bcaa76815a[log] [tgz]
authorJake Ehrlich <jakehehrlich@google.com>Fri Feb 15 17:18:11 2019 -0800
committerJake Ehrlich <jakehehrlich@google.com>Fri Feb 15 18:48:10 2019 -0800
treec5c953c6e4a57fe0b4a74aef57c8e00d27181250
parent782e7cb3a39b6e020dd726806316345285d5ccb4 [diff]
[symbolize] Handle backtrace addresses correctly

This change handles the issue where the reported addresses are return addresses
and not the caller address. Because subtracting 1 will on x86_64 and AArch64
cause the address to be in the middle (or start on x86_64 in rare cases) this
is always a valid technique.

Test: Just symbolized a real crash with it
Change-Id: I3838b9e929763e6a9a04a2650297951839f6acd1
3 files changed
tree: c5c953c6e4a57fe0b4a74aef57c8e00d27181250
  1. artifacts/
  2. bloaty/
  3. botanist/
  4. build/
  5. buildbucket/
  6. cache/
  7. cmd/
  8. color/
  9. digest/
  10. elflib/
  11. fastboot/
  12. gcs/
  13. gndoc/
  14. isatty/
  15. logger/
  16. mdns/
  17. netboot/
  18. ninjalog/
  19. qemu/
  20. resultstore/
  21. retry/
  22. runtests/
  23. secrets/
  24. serial/
  25. symbolize/
  26. tap/
  27. telnet/
  28. testrunner/
  29. testsharder/
  30. tftp/
  31. .gitignore
  32. go.mod
  33. go.sum
  34. LICENSE
  35. manifest
  36. PATENTS
  37. README.md
README.md

tools

This repo contains tools used in Fuchsia build and development.

Go packages from here are automatically built and uploaded to CIPD and Google Storage by bots using the tools recipe. To add a tool to the build:

  • Edit the bot config.
  • Find the builder_mixins section with name: "tools".
  • Edit the JSON in properties_j to add a string to the packages list:
"fuchsia.googlesource.com/tools/cmd/your-new-tool"