)]}' { "log": [ { "commit": "1851f817deb8c0ef611801c1fba2d866d88584ff", "tree": "553f21fadab4af966c38018a75067fc8d7016742", "parents": [ "c4e63110b1d957df2da0455c5159a39b159b190f" ], "author": { "name": "Prashanth Swaminathan", "email": "prashanthsw@google.com", "time": "Mon Jul 14 12:12:18 2025 -0700" }, "committer": { "name": "Prashanth Swaminathan", "email": "prashanthsw@google.com", "time": "Mon Jul 14 13:15:14 2025 -0700" }, "message": "[wayland][libxml2] Remove libxml2 dependency\n\nWe\u0027d like to remove the libxml2 dependency as it\u0027s hard to maintain, and\nwayland only uses it for this binary tool that we do not use. Remove the\nsource sets that require libxml2.\n\nBug: 431804801\nChange-Id: Ie5ee2583e2e6f38a7a5f198fe9c06a4ad5140ce9\nReviewed-on: https://fuchsia-review.googlesource.com/c/third_party/wayland/+/1321667\nReviewed-by: Craig Stout \u003ccstout@google.com\u003e\n" }, { "commit": "c4e63110b1d957df2da0455c5159a39b159b190f", "tree": "5c096b1fd5173fd453f2079c1aa0c611e575bd21", "parents": [ "9192d3cebd2e7a82aa3dc7cd235fb15ae8a5884d" ], "author": { "name": "Marina Ciocea", "email": "marinaciocea@google.com", "time": "Mon Dec 12 17:18:54 2022 -0500" }, "committer": { "name": "Marina Ciocea", "email": "marinaciocea@google.com", "time": "Tue Dec 13 21:11:51 2022 +0000" }, "message": "[wayland] Add OWNERS file\n\nAdd as owners the owners of the code that calls into this dependency.\n\nThe OWNERS file is generated by `fx update-3p-owners`.\n\nBug: 102810\nChange-Id: I116b33547ec4a13b3dfa613889c92d5dc378e10f\nReviewed-on: https://fuchsia-review.googlesource.com/c/third_party/wayland/+/775602\nReviewed-by: Alexander Radchenko \u003calerad@google.com\u003e\nReviewed-by: Craig Stout \u003ccstout@google.com\u003e\n" }, { "commit": "9192d3cebd2e7a82aa3dc7cd235fb15ae8a5884d", "tree": "55ddd9ff45a5ea3a19deec40d96fdb70a6b77d0a", "parents": [ "f22098b991a38cd737a5019c5f251668d99753a0" ], "author": { "name": "C Stout", "email": "cstout@google.com", "time": "Mon Aug 23 13:59:57 2021 -0700" }, "committer": { "name": "Craig Stout", "email": "cstout@google.com", "time": "Mon Aug 23 21:16:59 2021 +0000" }, "message": "Use so.0 extension for shared libraries\n\nBuster does not have a link for the short form name.\n\nChange-Id: I7f0e29e0443154acc62206e3d35e54b892d34592\nReviewed-on: https://fuchsia-review.googlesource.com/c/third_party/wayland/+/572524\nReviewed-by: David Reveman \u003creveman@google.com\u003e\n" }, { "commit": "f22098b991a38cd737a5019c5f251668d99753a0", "tree": "15155710eb601d3159d9b9f55e2e8b740158e404", "parents": [ "792822df4a7da76ac415edd68fad59b1769d649c" ], "author": { "name": "C Stout", "email": "cstout@google.com", "time": "Fri Aug 20 17:29:26 2021 -0700" }, "committer": { "name": "Craig Stout", "email": "cstout@google.com", "time": "Mon Aug 23 19:05:38 2021 +0000" }, "message": "Switch to shared libraries.\n\nWhen mesa is built out-of-tree it depends on the system\nlibwayland-client.so, so apps built in tree that use the\nVulkan Wayland swapchain should use the same client library\nimplementation.\n\nChange-Id: I08187c45dc0be3ef400c8a69a7b757058b452784\nReviewed-on: https://fuchsia-review.googlesource.com/c/third_party/wayland/+/571756\nReviewed-by: David Reveman \u003creveman@google.com\u003e\n" }, { "commit": "792822df4a7da76ac415edd68fad59b1769d649c", "tree": "3d4bc6c5a3a81d977345d0fc70c135c91454f8cf", "parents": [ "d0e75f0202f15d9a28e78c408103dbeb8d958327" ], "author": { "name": "Tamir Duberstein", "email": "tamird@google.com", "time": "Sun May 09 12:35:14 2021 -0400" }, "committer": { "name": "Tamir Duberstein", "email": "tamird@google.com", "time": "Sun May 09 19:23:03 2021 +0000" }, "message": "[config] Suppress implicit-fallthrough\n\nChange-Id: Ief5fd9bb3a27b2be3a3b01a1ccbb96426623a5f5\nReviewed-on: https://fuchsia-review.googlesource.com/c/third_party/wayland/+/527270\nReviewed-by: Shai Barack \u003cshayba@google.com\u003e\n" }, { "commit": "d0e75f0202f15d9a28e78c408103dbeb8d958327", "tree": "0b2ecad7aeee814639ea170368e14fbd3507235a", "parents": [ "f08e0327211a41d6497a62eba2c93b1ad7a8719d" ], "author": { "name": "Shai Barack", "email": "shayba@google.com", "time": "Thu Sep 24 22:04:55 2020 -0700" }, "committer": { "name": "Shai Barack", "email": "shayba@google.com", "time": "Wed Sep 30 21:31:58 2020 +0000" }, "message": "[wayland] Update from origin\n\nBecause msandy@google.com asked, and because upstream fixed an implicit\nconversion issue.\n\nBug: 58162\nChange-Id: I4846a4819867a61fe3c222335d9fe48e69df4c5f\nReviewed-on: https://fuchsia-review.googlesource.com/c/third_party/wayland/+/430731\nReviewed-by: Shai Barack \u003cshayba@google.com\u003e\nReviewed-by: Matt Sandy \u003cmsandy@google.com\u003e\n" }, { "commit": "f08e0327211a41d6497a62eba2c93b1ad7a8719d", "tree": "16c7b67e8f92e3d0d55a7572a5978c0a0c2bfd35", "parents": [ "c7b92f06c02484476677a18b2b2b8312a7a7420f" ], "author": { "name": "Shai Barack", "email": "shayba@google.com", "time": "Thu Sep 24 11:54:01 2020 -0700" }, "committer": { "name": "Shai Barack", "email": "shayba@google.com", "time": "Sun Sep 27 05:19:13 2020 +0000" }, "message": "[Wconversion] Fix implicit conversion issue\n\nMake a cast from long to int explicit.\n\nBug: 58162\nChange-Id: I84aa84e59f50b6e87bec56bacd2f0a587d53a949\nReviewed-on: https://fuchsia-review.googlesource.com/c/third_party/wayland/+/430718\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\n" }, { "commit": "c7b92f06c02484476677a18b2b2b8312a7a7420f", "tree": "aebd9b198d441b54eb0901154b31332689e36e3c", "parents": [ "ca7694ea81ce461e19c8be7dc6f721f1270fe1fb" ], "author": { "name": "Shai Barack", "email": "shayba@google.com", "time": "Mon Aug 31 13:36:16 2020 -0700" }, "committer": { "name": "Shai Barack", "email": "shayba@google.com", "time": "Wed Sep 02 18:35:14 2020 +0000" }, "message": "[Wconversion] Suppress warnings\n\nBug: 56258\nBug: 58162\n\nChange-Id: Ib9ec81a2d95d0b02ca1a7ccf75769bc2d516cd3a\nReviewed-on: https://fuchsia-review.googlesource.com/c/third_party/wayland/+/422704\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\nReviewed-by: Shai Barack \u003cshayba@google.com\u003e\n" }, { "commit": "ca7694ea81ce461e19c8be7dc6f721f1270fe1fb", "tree": "c3fab0688242a18f6893d4d6ff4159f81f2f0e25", "parents": [ "98ba5f12c0cbf7c832423b0e2353216def74cb74" ], "author": { "name": "Leonard Chan", "email": "leonardchan@google.com", "time": "Wed Sep 11 14:28:38 2019 -0700" }, "committer": { "name": "Leonard Chan", "email": "leonardchan@google.com", "time": "Wed Sep 11 14:32:01 2019 -0700" }, "message": "[wayland] Temporarily disable `-Wsizeof-array-div` warnings\n\nClang introduced a new warning that is raised when we\nattempt to check the size of an array through sizeof() division. If the\ntype of the sizeof() in the divisor is not the same as that of the array\nelement, a warning is raised.\n\nBUG: 36439\nChange-Id: Ibb9972257c44987a7c5e339320c02610773266b0\n" }, { "commit": "98ba5f12c0cbf7c832423b0e2353216def74cb74", "tree": "1ca2a431263065060c18bdaaafb8e97ebeac79ae", "parents": [ "8c61ec96ae8f209499322636b5386d3d44775f4e" ], "author": { "name": "Matt Sandy", "email": "msandy@google.com", "time": "Wed Jul 24 10:54:13 2019 -0700" }, "committer": { "name": "Matt Sandy", "email": "msandy@google.com", "time": "Wed Jul 24 11:09:39 2019 -0700" }, "message": "[build] require linux for DTD validation\n\nThis change removes the use of DTD validation (requiring libxml2) for\nnon-linux builds.\n\nTest: CQ\nChange-Id: I37794f8d28fb470cf0715d00bf934bcb42943b4c\n" }, { "commit": "8c61ec96ae8f209499322636b5386d3d44775f4e", "tree": "6352642038f0d8c1c03c31b8fec460104d36eed9", "parents": [ "26fc26d7bee038bf9c0019cb07c6c3c15f26c1f2" ], "author": { "name": "Matt Sandy", "email": "msandy@google.com", "time": "Tue Jul 23 16:47:14 2019 -0700" }, "committer": { "name": "Matt Sandy", "email": "msandy@google.com", "time": "Tue Jul 23 16:47:14 2019 -0700" }, "message": "[build] use c instead of asm for DTD_DATA\n\nThis change removes the use of dtddata.S and instead adds the required\ndata file as a script-generated c file. This allows the project to build\non the MacOS host toolchain. The change also reverts a prior change to\ndtddata.S as it is no longer needed.\n\nTest: ran wayland_swapchain_test\nChange-Id: I8d1e22b49296f2fa92b07a3e850cad1f3433d41f\n" }, { "commit": "26fc26d7bee038bf9c0019cb07c6c3c15f26c1f2", "tree": "a15a0debc3e076380efa4f8bc2c921949a950109", "parents": [ "33002cbe2c15c1e12084963034ac2e2ffbc757e1" ], "author": { "name": "Matt Sandy", "email": "msandy@google.com", "time": "Fri Jul 12 15:02:58 2019 -0700" }, "committer": { "name": "Matt Sandy", "email": "msandy@google.com", "time": "Fri Jul 12 16:38:49 2019 -0700" }, "message": "[build] improve wayland build config\n\nThis change reduces the visibility of the internal wayland targets, as\nwell as changes the wayland.gni templates to implicitly propagate deps\nto callers. For example, a target that defines a wayland_protocol_header\ntarget will automatically use the include path for that header.\n\nTest: CQ\nChange-Id: Ice1d81a1d307790d233b76594e630602d78b0f3c\n" }, { "commit": "33002cbe2c15c1e12084963034ac2e2ffbc757e1", "tree": "ae4dfa0757ddad64604784bdcfaa903504b8f1ef", "parents": [ "01095a9ce4d8457ee2f221848b9805c4b5cffc95" ], "author": { "name": "Matt Sandy", "email": "msandy@google.com", "time": "Mon Jun 10 11:59:51 2019 -0700" }, "committer": { "name": "Matt Sandy", "email": "msandy@google.com", "time": "Tue Jul 09 16:13:30 2019 -0700" }, "message": "[build] add build config for wayland\n\nThis change adds build config files for wayland, enabling it to be used\nby other targets in-tree.\n\nTest: added wayland as local dep and built fuchsia\nChange-Id: I837b0b668ccf6dfcdd5164faf83a5625ef2fc655\n" }, { "commit": "01095a9ce4d8457ee2f221848b9805c4b5cffc95", "tree": "dfa779d52afab16678141766a5d7ad7c4eefd692", "parents": [ "cb9a2557e11f294256943f5b4187940d7234820c" ], "author": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Fri Aug 24 16:15:59 2018 +0100" }, "committer": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Wed Aug 29 09:59:04 2018 +0100" }, "message": "tests: Remove memory leak checking infrastructure\n\nThere are far better ways to detect memory leaks, such as either\nvalgrind or ASan. Having Meson makes it really easy to use these tools\nin our tests, and we can do that in CI as well.\n\nHaving these local wrappers actually completely broke ASan usage, so\nremove them in favour of using the more powerful options.\n\nSigned-off-by: Daniel Stone \u003cdaniels@collabora.com\u003e\nReviewed-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\nReviewed-by: Peter Hutterer \u003cpeter.hutterer@who-t.net\u003e\n" }, { "commit": "cb9a2557e11f294256943f5b4187940d7234820c", "tree": "111932ce342e3171c43c1326ba0d2e610380d7e6", "parents": [ "9575d1c772378df73cd421997b70d4a880575911" ], "author": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Fri Aug 24 16:53:25 2018 +0100" }, "committer": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Wed Aug 29 09:59:04 2018 +0100" }, "message": "tests: Overly elaborate compiler warning workaround\n\nClang will rightly point out that example_sockaddr_un in socket-test\nwill get discarded from the compilation unit as it is completely unused.\nPut in a couple of lines which of no value other than stopping Clang\nfrom complaining.\n\nSigned-off-by: Daniel Stone \u003cdaniels@collabora.com\u003e\nReviewed-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\nReviewed-by: Peter Hutterer \u003cpeter.hutterer@who-t.net\u003e\n" }, { "commit": "9575d1c772378df73cd421997b70d4a880575911", "tree": "512d0378803bc58533ba9836c79dec274751fb25", "parents": [ "4939923d3a8487f6644b1feb657693d8f929297b" ], "author": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Fri Aug 24 16:48:13 2018 +0100" }, "committer": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Wed Aug 29 09:59:04 2018 +0100" }, "message": "tests: Use volatile pointer for NULL dereference\n\nClang warns that it can silently discard a non-volatile write to a NULL\npointer (perhaps it constitutes undefined behaviour?), and recommends\nchanging it to volatile.\n\nThis patch slavishly complies with the demand of the unfeeling machine.\n\nSigned-off-by: Daniel Stone \u003cdaniels@collabora.com\u003e\nReviewed-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\nReviewed-by: Peter Hutterer \u003cpeter.hutterer@who-t.net\u003e\n" }, { "commit": "4939923d3a8487f6644b1feb657693d8f929297b", "tree": "fe8ece071dae90ecfc8db80541d3ad445202b22d", "parents": [ "5fab243a729c949d38463c47040ea6abec8d7850" ], "author": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Tue Aug 28 23:59:35 2018 +0100" }, "committer": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Wed Aug 29 09:58:49 2018 +0100" }, "message": "scanner: Reverse expat/libxml include order\n\nlibxml2 unconditonally defines XMLCALL to nothing. Expat does not\nredefine XMLCALL if it is already defined, but if it is not, and we are\nbuilding with gcc on i386 (not x86-64), it will define it as \u0027cdecl\u0027.\n\nIncluding Expat before libxml thus results in a warning about XMLCALL\nbeing redefined. Luckily we can get around this by just reversing the\ninclude order: cdecl is a no-op on Unix-like systems, so by having\nlibxml first define XMLCALL to nothing and including Expat afterwards,\nwe avoid the warning and lose nothing.\n\nSigned-off-by: Daniel Stone \u003cdaniels@collabora.com\u003e\nReviewed-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\nReviewed-by: Peter Hutterer \u003cpeter.hutterer@who-t.net\u003e\n" }, { "commit": "5fab243a729c949d38463c47040ea6abec8d7850", "tree": "6ef75eca3a73ca4a17d26bfcdb13d7cba2978f3a", "parents": [ "a2ed67e85c386413979ab30bf5ec48dc19fcf99e" ], "author": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Mon Aug 27 22:26:37 2018 +0100" }, "committer": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Wed Aug 29 09:56:56 2018 +0100" }, "message": "scanner: Mark fail() as noreturn\n\nHelp static analysers by letting them know that once we fail(),\nexecution will terminally complete.\n\nSigned-off-by: Daniel Stone \u003cdaniels@collabora.com\u003e\nReviewed-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\nReviewed-by: Peter Hutterer \u003cpeter.hutterer@who-t.net\u003e\n" }, { "commit": "a2ed67e85c386413979ab30bf5ec48dc19fcf99e", "tree": "8549349b0e623a8524681a229f1437b8bfe78da3", "parents": [ "f1d10fb6092c772a7c5ac192890a8d2bbe695a5f" ], "author": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Fri Aug 24 16:32:42 2018 +0100" }, "committer": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Wed Aug 29 09:56:39 2018 +0100" }, "message": "scanner: Plug two memory leaks\n\nFound with both ASan leak sanitizer and Valgrind. We were trivially\nleaking the enum name for every arg parsed by the scanner which had one.\nIf libxml-based DTD validation was enabled, we would also leak the DTD\nitself, despite diligently freeing the document, context, etc.\n\nSigned-off-by: Daniel Stone \u003cdaniels@collabora.com\u003e\nReviewed-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\nReviewed-by: Peter Hutterer \u003cpeter.hutterer@who-t.net\u003e\n" }, { "commit": "f1d10fb6092c772a7c5ac192890a8d2bbe695a5f", "tree": "185a482709f8bd20d283efb6d6659b32f3c86fac", "parents": [ "254bef7b4a32b52346bdcdf4b8a432b582a9ddb4" ], "author": { "name": "Derek Foreman", "email": "derek.foreman.samsung@gmail.com", "time": "Fri Aug 24 13:41:14 2018 -0500" }, "committer": { "name": "Derek Foreman", "email": "derek.foreman.samsung@gmail.com", "time": "Fri Aug 24 13:41:14 2018 -0500" }, "message": "configure.ac: Reopen master for regular development\n" }, { "commit": "254bef7b4a32b52346bdcdf4b8a432b582a9ddb4", "tree": "6d240ecdc18c81ee5202956de5ca5f063b838c37", "parents": [ "581c62841f2215ee12a8d9af4e4c05d052c6a204" ], "author": { "name": "Derek Foreman", "email": "derek.foreman.samsung@gmail.com", "time": "Fri Aug 24 12:39:14 2018 -0500" }, "committer": { "name": "Derek Foreman", "email": "derek.foreman.samsung@gmail.com", "time": "Fri Aug 24 12:39:14 2018 -0500" }, "message": "configure.ac: bump to version 1.16.0 for the official release\n" }, { "commit": "581c62841f2215ee12a8d9af4e4c05d052c6a204", "tree": "b6143ea21506420365b221f73943f6bc0ad56e7f", "parents": [ "de3079685c320ac290bb1c5728db27e3bc829c90" ], "author": { "name": "Michal Srb", "email": "msrb@suse.com", "time": "Tue Aug 21 10:47:29 2018 +0200" }, "committer": { "name": "Derek Foreman", "email": "derek.foreman.samsung@gmail.com", "time": "Fri Aug 24 12:31:02 2018 -0500" }, "message": "tests: Demarshalling of very long array/string lengths.\n\nAttempting to demarshal message with array or string longer than its\nbody should return failure. Handling the length correctly is tricky when\nit gets to near-UINT32_MAX values. Unexpected overflows can cause\ncrashes and other security issues.\n\nThese tests verify that demarshalling such message gives failure instead\nof crash.\n\nv2: Added consts, serialized opcode and size properly, updated style.\nReviewed-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\nAcked-by: Derek Foreman \u003cderek.foreman.samsung@gmail.com\u003e\n" }, { "commit": "de3079685c320ac290bb1c5728db27e3bc829c90", "tree": "1bd4741760ffd3939c16a99b7c2bcb9de35d341e", "parents": [ "f7fdface41a9205c12aedf7fe04aba7792402909" ], "author": { "name": "Derek Foreman", "email": "derek.foreman.samsung@gmail.com", "time": "Fri Aug 17 11:19:45 2018 -0500" }, "committer": { "name": "Derek Foreman", "email": "derek.foreman.samsung@gmail.com", "time": "Fri Aug 17 11:19:45 2018 -0500" }, "message": "configure.ac: bump to version 1.15.94 for the RC2 release\n" }, { "commit": "f7fdface41a9205c12aedf7fe04aba7792402909", "tree": "d9ee5cf00ae47ef34504131f0be063f581998684", "parents": [ "f5b9e3b9a1df83ec3a6d219d7c28a1ac5bc0f339" ], "author": { "name": "Michal Srb", "email": "msrb@suse.com", "time": "Tue Aug 14 13:07:53 2018 +0200" }, "committer": { "name": "Derek Foreman", "email": "derek.foreman.samsung@gmail.com", "time": "Fri Aug 17 10:59:20 2018 -0500" }, "message": "connection: Prevent pointer overflow from large lengths.\n\nIf the remote side sends sufficiently large `length` field, it will\noverflow the `p` pointer. Technically it is undefined behavior, in\npractice it makes `p \u003c end`, so the length check passes. Attempts to\naccess the data later causes crashes.\n\nThis issue manifests only on 32bit systems, but the behavior is\nundefined everywhere.\nReviewed-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\nReviewed-by: Derek Foreman \u003cderek.foreman.samsung@gmail.com\u003e\n" }, { "commit": "f5b9e3b9a1df83ec3a6d219d7c28a1ac5bc0f339", "tree": "f16aae048d5e27635828ad1e283bb213a6b5deea", "parents": [ "fde60465c3b30c9bbcfdd67622ce5539709bac40" ], "author": { "name": "Michal Srb", "email": "msrb@suse.com", "time": "Tue Aug 14 13:07:52 2018 +0200" }, "committer": { "name": "Derek Foreman", "email": "derek.foreman.samsung@gmail.com", "time": "Fri Aug 17 10:57:41 2018 -0500" }, "message": "connection: Prevent integer overflow in DIV_ROUNDUP.\n\nThe DIV_ROUNDUP macro would overflow when trying to round values higher\nthan MAX_UINT32 - (a - 1). The result is 0 after the division. This is\npotential security issue when demarshalling an array because the length\ncheck is performed with the overflowed value, but then the original huge\nvalue is stored for later use.\n\nThe issue was present only on 32bit platforms. The use of size_t in the\nDIV_ROUNDUP macro already promoted everything to 64 bit size on 64 bit\nsystems.\nReviewed-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\nReviewed-by: Derek Foreman \u003cderek.foreman.samsung@gmail.com\u003e\n\nStyle changes by Derek Foreman\n" }, { "commit": "fde60465c3b30c9bbcfdd67622ce5539709bac40", "tree": "ccfd1fa8d80f99024297c00687f9deff1de862f0", "parents": [ "1e4af929d2be8e1fd277100558a0ecc44e3fe6ed" ], "author": { "name": "Derek Foreman", "email": "derek.foreman.samsung@gmail.com", "time": "Fri Aug 10 13:01:10 2018 -0500" }, "committer": { "name": "Derek Foreman", "email": "derek.foreman.samsung@gmail.com", "time": "Fri Aug 10 13:01:10 2018 -0500" }, "message": "configure.ac: bump to version 1.15.93 for the RC1 release\n" }, { "commit": "1e4af929d2be8e1fd277100558a0ecc44e3fe6ed", "tree": "803b6da558e8e5d1a4f834e8ae635e75f0aaafad", "parents": [ "6ac3ff1c3fb99af77522853cd3687dca0773cc78" ], "author": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Mon Aug 06 11:49:31 2018 +0100" }, "committer": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Tue Aug 07 14:35:29 2018 +0100" }, "message": "contributing: Weston now uses GitLab MRs\n\nNote that Weston uses GitLab MRs for review, not mail.\n\nSigned-off-by: Daniel Stone \u003cdaniels@collabora.com\u003e\nReviewed-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\n" }, { "commit": "6ac3ff1c3fb99af77522853cd3687dca0773cc78", "tree": "d7ea3889e7af9a1f8031a16597c73e51ce9cd986", "parents": [ "614c137200a4f62658ea9144193661f7c5f38c1d" ], "author": { "name": "Derek Foreman", "email": "derek.foreman.samsung@gmail.com", "time": "Fri Jul 27 11:46:27 2018 -0500" }, "committer": { "name": "Derek Foreman", "email": "derek.foreman.samsung@gmail.com", "time": "Fri Jul 27 11:46:27 2018 -0500" }, "message": "configure.ac: bump to version 1.15.92 for the beta release\n" }, { "commit": "614c137200a4f62658ea9144193661f7c5f38c1d", "tree": "6b1073aaca71d47afa6ed31ec97d80e07b81f398", "parents": [ "bd56f9e29f16ca956b3e4d9658e32f1125db9d2d" ], "author": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Sun Jul 22 10:17:39 2018 +0100" }, "committer": { "name": "Derek Foreman", "email": "derek.foreman.samsung@gmail.com", "time": "Fri Jul 27 11:16:32 2018 -0500" }, "message": "spec: Delete old unused directory\n\nThe protocol spec used to live here, but it\u0027s now part of the regular\ndoc build. The PNG files are created as part of the doc build. Delete\nthe pre-generated versions.\n\nSigned-off-by: Daniel Stone \u003cdaniels@collabora.com\u003e\nReviewed-by: Derek Foreman \u003cderek.foreman.samsung@gmail.com\u003e\n" }, { "commit": "bd56f9e29f16ca956b3e4d9658e32f1125db9d2d", "tree": "6e7bbf7e32e7d48adf2d6ea29c48485a3822fa3e", "parents": [ "99c3c10ad0e0a27a8c5d33d1e285e8b77fe0534b" ], "author": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Sat Jul 21 12:04:13 2018 +0100" }, "committer": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Thu Jul 26 16:23:35 2018 +0100" }, "message": "build: Remove support for non-pkg-config Expat\n\nThe Expat XML library has shipped a pkg-config file for long enough to\nbe in Debian\u0027s oldstable (Jessie, April 2015) and Ubuntu\u0027s oldest\nsupported LTS (Trusty, 14.04). The pkg-config file was added in Expat\nupstream\u0027s commit 352cfc8f59a7, in September 2007.\n\nDrop build support for versions of Expat which do not ship a\npkg-config file.\n\nSigned-off-by: Daniel Stone \u003cdaniels@collabora.com\u003e\nReviewed-by: Derek Foreman \u003cderek.foreman.samsung@gmail.com\u003e\nReviewed-by: Emil Velikov \u003cemil.velikov@collabora.com\u003e\n" }, { "commit": "99c3c10ad0e0a27a8c5d33d1e285e8b77fe0534b", "tree": "6e190e1679bd77af7812a2c1e1e0102aa41bc97a", "parents": [ "e614d79b6534541c3c1d2e0000c90f74e62622fc" ], "author": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Sat Jul 21 11:58:41 2018 +0100" }, "committer": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Thu Jul 26 16:21:46 2018 +0100" }, "message": "build: Remove execinfo.h check\n\nThe check for the execinfo.h header is only advisory; the build will not\nfail if it is not present, and set HAVE_EXECINFO_H if it is. The check\nwas added in commit bc3e020475e (\"build: Add declaration checks to check for\nrequired syscall flags\") with no obvious use or reasoning.\n\nRemove the no-op check.\n\nSigned-off-by: Daniel Stone \u003cdaniels@collabora.com\u003e\nReviewed-by: Derek Foreman \u003cderek.foreman.samsung@gmail.com\u003e\nReviewed-by: Emil Velikov \u003cemil.velikov@collabora.com\u003e\n" }, { "commit": "e614d79b6534541c3c1d2e0000c90f74e62622fc", "tree": "1ed466a1df49bde3348296a76c70023e1c294ea4", "parents": [ "504db9d8e5d3a6de4abbbb0ae11a82fd81b3771f" ], "author": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Fri Feb 16 10:54:40 2018 -0600" }, "committer": { "name": "Derek Foreman", "email": "derek.foreman.samsung@gmail.com", "time": "Wed Jul 25 12:08:16 2018 -0500" }, "message": "wayland-server: Finally remove deprecated struct wl_buffer definition\n\ncommit d94a8722cb29d8b897672be66ff3c9ff79eab6fe\nwarned this was coming, back in 2013.\n\nI\u0027ve seen libraries that have wayland client and server using functions\nin the same file. Since struct wl_buffer still exists as an opaque\nentity in client code, the vestigial deprecated wl_buffer from the\nserver include will generate warnings when not building with\nWL_HIDE_DEPRECATED.\n\nSigned-off-by: Derek Foreman \u003cderekf@osg.samsung.com\u003e\nAcked-by: Emil Velikov \u003cemil.velikov@collabora.com\u003e\nReviewed-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\nReviewed-by: Daniel Stone \u003cdaniels@collabora.com\u003e\n" }, { "commit": "504db9d8e5d3a6de4abbbb0ae11a82fd81b3771f", "tree": "8b01551d64ecf6d8fbb5f29786aeaae01fec39e0", "parents": [ "4cc1c1519a7001d1f9e4db8c9dea6fa191b88744" ], "author": { "name": "Simon Ser", "email": "contact@emersion.fr", "time": "Tue Jul 03 07:27:05 2018 -0400" }, "committer": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Tue Jul 24 11:26:17 2018 +0100" }, "message": "protocol: allow to send a zero physical output size\n\nPhysical size doesn\u0027t always make sense for all outputs. In case\nit\u0027s not available or not relevant, allow compositors to send zero.\n\nAcked-by: Daniel Stone \u003cdaniels@collabora.com\u003e\nAcked-by: Jonas Ådahl \u003cjadahl@gmail.com\u003e\nAcked-by: Olivier Fourdan \u003cofourdan@redhat.com\u003e\n" }, { "commit": "4cc1c1519a7001d1f9e4db8c9dea6fa191b88744", "tree": "88b27928f10f213398a51477e3125b1528dcc345", "parents": [ "14705824a61155a9b2366c1d982832f8c5a8366b" ], "author": { "name": "Derek Foreman", "email": "derek.foreman.samsung@gmail.com", "time": "Fri Jul 13 11:27:03 2018 -0500" }, "committer": { "name": "Derek Foreman", "email": "derek.foreman.samsung@gmail.com", "time": "Fri Jul 13 11:27:03 2018 -0500" }, "message": "configure.ac: bump to version 1.15.91 for the alpha release\n" }, { "commit": "14705824a61155a9b2366c1d982832f8c5a8366b", "tree": "77da364460eeeae4783ef893584a3c2f28d1f56b", "parents": [ "9f80af930b76139fdb851708d70fa26ddf3ed09e" ], "author": { "name": "Pekka Paalanen", "email": "pekka.paalanen@collabora.co.uk", "time": "Tue Jul 03 13:32:03 2018 +0300" }, "committer": { "name": "Derek Foreman", "email": "derek.foreman.samsung@gmail.com", "time": "Fri Jul 13 11:20:31 2018 -0500" }, "message": "contributing: document the release cycle freezes\n\nThese should be the conventions we have been using since 1.0, written\ndown more accurately.\n\nSigned-off-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\nReviewed-by: Daniel Stone \u003cdaniels@collabora.com\u003e\nReviewed-by: Derek Foreman \u003cderek.foreman.samsung@gmail.com\u003e\n" }, { "commit": "9f80af930b76139fdb851708d70fa26ddf3ed09e", "tree": "82b07819004354cb5bdb337b95b85a3cd8d74f55", "parents": [ "3cfdd56af4444fce71d4ae8c8e515cec8eafb3e2" ], "author": { "name": "Pekka Paalanen", "email": "pekka.paalanen@collabora.co.uk", "time": "Tue Jul 03 13:32:02 2018 +0300" }, "committer": { "name": "Derek Foreman", "email": "derek.foreman.samsung@gmail.com", "time": "Fri Jul 13 11:20:07 2018 -0500" }, "message": "contributing: about re-sending patches\n\nThis is what is generally expected from people who re-send patches,\nwhether the patches are their own or not.\n\nSigned-off-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\nReviewed-by: Daniel Stone \u003cdaniels@collabora.com\u003e\nReviewed-by: Derek Foreman \u003cderek.foreman.samsung@gmail.com\u003e\n" }, { "commit": "3cfdd56af4444fce71d4ae8c8e515cec8eafb3e2", "tree": "b364a4a35e991ccfca08aa0a6e2c107360ac4955", "parents": [ "b5f97895da4aae4ba87ae3aa7da36abb86dcb58c" ], "author": { "name": "Pekka Paalanen", "email": "pekka.paalanen@collabora.co.uk", "time": "Tue Jul 03 13:32:01 2018 +0300" }, "committer": { "name": "Derek Foreman", "email": "derek.foreman.samsung@gmail.com", "time": "Fri Jul 13 11:19:12 2018 -0500" }, "message": "contributing: review rules for bugs\n\nHalf of the ideas came from Daniel but most of them are reworded, the\nrest are my thoughts.\n\nMention compiler warnings specifically, and be more explicit on what\nkind of code or bugs or bug fixes are acceptable or not. Clarify commit\nscope.\n\nv2: move the \"In a patch series\" rule to the bottom, reworded.\n\nCc: Daniel Stone \u003cdaniels@collabora.com\u003e\nSigned-off-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\nReviewed-by: Daniel Stone \u003cdaniels@collabora.com\u003e\nReviewed-by: Derek Foreman \u003cderek.foreman.samsung@gmail.com\u003e\n" }, { "commit": "b5f97895da4aae4ba87ae3aa7da36abb86dcb58c", "tree": "43da3d26727ad5355b4a6a57d6c236b7536aaf3a", "parents": [ "7cbaa871cccf0e07123185d5db8a35f7eee27f37" ], "author": { "name": "Pekka Paalanen", "email": "pekka.paalanen@collabora.co.uk", "time": "Tue Jul 03 13:32:00 2018 +0300" }, "committer": { "name": "Derek Foreman", "email": "derek.foreman.samsung@gmail.com", "time": "Fri Jul 13 11:17:35 2018 -0500" }, "message": "contributing: how to read the review rules\n\nThis is to avoid fighting around the letter of the guidelines. This is\nnot a protocol spec.\n\nSigned-off-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\nReviewed-by: Daniel Stone \u003cdaniels@collabora.com\u003e\nReviewed-by: Derek Foreman \u003cderek.foreman.samsung@gmail.com\u003e\n" }, { "commit": "7cbaa871cccf0e07123185d5db8a35f7eee27f37", "tree": "9c756e79c12efca74169f4e4d01332b272a9f1a1", "parents": [ "a9ff9cc7d591124413249a4d803188cd3f9165ca" ], "author": { "name": "Pekka Paalanen", "email": "pekka.paalanen@collabora.co.uk", "time": "Thu Feb 15 13:48:35 2018 +0200" }, "committer": { "name": "Pekka Paalanen", "email": "pekka.paalanen@collabora.co.uk", "time": "Thu Jun 28 14:35:40 2018 +0300" }, "message": "client: remove definition of wl_global\n\nNothing on the client side uses it since\n9fe75537ad207c1496e6d9be41a8f5af4b876506 which was just before the 0.99\nrelease.\n\nSigned-off-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\nReviewed-By: Markus Ongyerth \u003cwl@ongy.net\u003e\n" }, { "commit": "a9ff9cc7d591124413249a4d803188cd3f9165ca", "tree": "d3081b5f29f4f18218531ef2fafc916b8e64175a", "parents": [ "bb1a8ca91e7d99f54b43ece01674ccbd720ec4bd" ], "author": { "name": "Simon Ser", "email": "contact@emersion.fr", "time": "Mon Jun 18 06:58:46 2018 -0400" }, "committer": { "name": "Pekka Paalanen", "email": "pekka.paalanen@collabora.co.uk", "time": "Thu Jun 28 14:13:13 2018 +0300" }, "message": "doc: update IANA MIME types registry URL\n\nUse a more official one, served over HTTP rather than FTP.\n\nReviewed-by: Matheus Santana \u003cembs@cin.ufpe.br\u003e\nAcked-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\n" }, { "commit": "bb1a8ca91e7d99f54b43ece01674ccbd720ec4bd", "tree": "4805c66a81da55a44908fe57642803d89e20fd5a", "parents": [ "f16eae15e1862f8cf07450ab1587cb8190b7606e" ], "author": { "name": "Pekka Paalanen", "email": "pekka.paalanen@collabora.co.uk", "time": "Fri Jun 15 17:25:07 2018 +0300" }, "committer": { "name": "Pekka Paalanen", "email": "pekka.paalanen@collabora.co.uk", "time": "Mon Jun 18 16:15:58 2018 +0300" }, "message": "contributing: commit rights\n\nThis has been copied from\nhttps://cgit.freedesktop.org/xorg/app/intel-gpu-tools/tree/CONTRIBUTING?id\u003deccae1360d6d01e73c6af2bd97122cef708207ef\nand slightly edited to better with Wayland and Weston.\n\nThe intention is to make it easier to give out commit access to new\npeople, let them know what is expected of them, and help the community\nto grow. Hopefully this will in time improve the patch review throughput\nand timeliness.\n\nThe original text was introduced in\nhttps://cgit.freedesktop.org/xorg/app/intel-gpu-tools/commit/CONTRIBUTING?id\u003d0350f0e7f6a0e07281445fc3082aa70419f4aac7\n\nSigned-off-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\nReviewed-by: Matheus Santana \u003cembs@cin.ufpe.br\u003e\nReviewed-by: Daniel Stone \u003cdaniels@collabora.com\u003e\nReviewed-by: Emil Velikov \u003cemil.velikov@collabora.com\u003e\nReviewed-by: Derek Foreman \u003cderek.foreman.samsung@gmail.com\u003e\n" }, { "commit": "f16eae15e1862f8cf07450ab1587cb8190b7606e", "tree": "ef934928bf9989d2e90a51256a088d0506c72b9c", "parents": [ "35d0425e39a6fa9d358ffff507c97a79fc112dc9" ], "author": { "name": "Pekka Paalanen", "email": "pekka.paalanen@collabora.co.uk", "time": "Wed Jun 13 16:02:51 2018 +0300" }, "committer": { "name": "Pekka Paalanen", "email": "pekka.paalanen@collabora.co.uk", "time": "Mon Jun 18 16:04:57 2018 +0300" }, "message": "contributing: add review guidelines\n\nThis sets up the standards for patch review, and defines when a patch\ncan be merged. I believe these are the practises we have been using\nalready for a long time, now they are just written down explicitly.\n\nIt\u0027s not an exhaustive list of criteria and likely cannot ever be, but\nit should give a good idea of what level of review we want to have.\n\nIt has been written in general terms, so that we can easily apply the\nsame text not just to Wayland, but also Weston and other projects as\nnecessary.\n\nThis addition is not redundant with\nhttps://wayland.freedesktop.org/reviewing.html .\n\nThe web page is a friendly introduction and encouragement for people to\nget involved. The guidelines here are more specific and aimed for people\nwho seek commit rights or maintainership.\n\nSigned-off-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\nReviewed-by: Matheus Santana \u003cembs@cin.ufpe.br\u003e\nReviewed-by: Daniel Stone \u003cdaniels@collabora.com\u003e\nReviewed-by: Emil Velikov \u003cemil.velikov@collabora.com\u003e\nReviewed-by: Derek Foreman \u003cderek.foreman.samsung@gmail.com\u003e\n" }, { "commit": "35d0425e39a6fa9d358ffff507c97a79fc112dc9", "tree": "2798df9bfd01f99bc547d3c078f42a37d97754c1", "parents": [ "630c25f4c1609c0be1c0cdfcb4a9d125ac8c2d14" ], "author": { "name": "Emil Velikov", "email": "emil.velikov@collabora.com", "time": "Thu Jun 14 18:14:14 2018 +0100" }, "committer": { "name": "Pekka Paalanen", "email": "pekka.paalanen@collabora.co.uk", "time": "Mon Jun 18 12:17:11 2018 +0300" }, "message": ".gitlab-ci.yml: collect the distcheck error logs\n\nCurrently we issue both check and distcheck, as reportedly there has\nbeen cases in the past one works, while the other doesn\u0027t.\n\nYet we only collect the check artefacts (test logs).\n\nCorrect that, by picking the distcheck ones as well.\nNote: the build-*/wayland*/ directory is purged by distcheck if it runs\nsuccessfully.\n\nSigned-off-by: Emil Velikov \u003cemil.l.velikov@gmail.com\u003e\nReviewed-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\n" }, { "commit": "630c25f4c1609c0be1c0cdfcb4a9d125ac8c2d14", "tree": "8e70945232aa7c053d7eaf2bd180d979193bc926", "parents": [ "d95cf312019bed4768a2e97ec73dc926eddc4dbe" ], "author": { "name": "Pekka Paalanen", "email": "pekka.paalanen@collabora.co.uk", "time": "Wed Jun 13 13:21:43 2018 +0300" }, "committer": { "name": "Pekka Paalanen", "email": "pekka.paalanen@collabora.co.uk", "time": "Thu Jun 14 14:40:32 2018 +0300" }, "message": "contributing: format as markdown\n\nFormat for nice viewing through Gitlab.\n\nConduct and Licensing were raised to first level headings as they are\nnot technical guidelines for contributing patches. It\u0027s nice to use the\nfirst level headings more.\n\nReformat patchwork link and add Xorg patchwork link for Xwayland.\n\nv2: Unfortunately Gitlab harcodes a tab character to mean 4 spaces, so we\ncannot reasonably spell the coding style examples correctly. Hence, tab\ncharacters have been replaced with eight spaces so that they at least\nlook right in both the file and through gitlab web UI.\n\nSigned-off-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\nReviewed-by: Peter Hutterer \u003cpeter.hutterer@who-t.net\u003e\nReviewed-by: Daniel Stone \u003cdaniels@collabora.com\u003e\n" }, { "commit": "d95cf312019bed4768a2e97ec73dc926eddc4dbe", "tree": "3bf8fae33c28fc4b32834a617e17af828e79f9c7", "parents": [ "7846d4beea05239f7188f8417e8f497203bf8641" ], "author": { "name": "Pekka Paalanen", "email": "pekka.paalanen@collabora.co.uk", "time": "Wed Jun 13 12:45:36 2018 +0300" }, "committer": { "name": "Pekka Paalanen", "email": "pekka.paalanen@collabora.co.uk", "time": "Thu Jun 14 14:39:47 2018 +0300" }, "message": "doc: move Contributing\n\nGitlab expects a CONTRIBUTING.md in the root directory, so move our\nguide there.\n\nConversion to proper markup is a follow-up patch.\n\nSigned-off-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\nReviewed-by: Peter Hutterer \u003cpeter.hutterer@who-t.net\u003e\nReviewed-by: Daniel Stone \u003cdaniels@collabora.com\u003e\n" }, { "commit": "7846d4beea05239f7188f8417e8f497203bf8641", "tree": "b5f3657bb16a0bb8f3f03084cad79461bdb9fd5a", "parents": [ "8b2ba84bd0c152d3e6de8bd22b413a1ca6eb6630" ], "author": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Sat Jun 09 00:49:33 2018 +0100" }, "committer": { "name": "Pekka Paalanen", "email": "pekka.paalanen@collabora.co.uk", "time": "Mon Jun 11 12:03:39 2018 +0300" }, "message": "doc: Update URLs for GitLab transition\n\nUpdate bug and Git URLs for GitLab; the site has also been served over\nHTTPS for quite some time.\n\nSigned-off-by: Daniel Stone \u003cdaniels@collabora.com\u003e\nReviewed-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\n" }, { "commit": "8b2ba84bd0c152d3e6de8bd22b413a1ca6eb6630", "tree": "7446008700e43ea723677491048a57f4ae3ea81f", "parents": [ "a060822399b8f38ca665b502c6fb4c204029c5e8" ], "author": { "name": "Simon Ser", "email": "contact@emersion.fr", "time": "Fri May 25 17:24:41 2018 -0400" }, "committer": { "name": "Pekka Paalanen", "email": "pekka.paalanen@collabora.co.uk", "time": "Thu Jun 07 11:52:06 2018 +0300" }, "message": "scanner: allow referencing foreign enums\n\nIt\u0027s already possible to reference foreign interfaces, so it\nshould also be possible to reference foreign enums.\n\nSigned-off-by: Simon Ser \u003ccontact@emersion.fr\u003e\nReviewed-by: Silvan Jegen \u003cs.jegen@gmail.com\u003e\nReviewed-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\n" }, { "commit": "a060822399b8f38ca665b502c6fb4c204029c5e8", "tree": "60d26492c9d9321fd34f175952d0fa5cb2df1a17", "parents": [ "0e6ac72288f884ba0321c285a65578492c706534" ], "author": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Tue Jun 05 21:22:38 2018 +0100" }, "committer": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Thu Jun 07 08:48:24 2018 +0100" }, "message": "Add .gitlab-ci.yml\n\nAdd a GitLab CI configuration which tests building, \u0027make check\u0027, and\n\u0027make distcheck\u0027 of the tree inside a Debian Stretch container. The\nchoice of distribution base was arbitrary and may easily be changed.\n\nWhen commits are pushed to upstream, the commits will run this CI\npipeline to run these tests, and capture the result as an artifact\nbundle, including the compiled binaries and full test suite logs.\n\nResults can be seen at:\n https://gitlab.freedesktop.org/wayland/wayland/pipelines/\n\nSigned-off-by: Daniel Stone \u003cdaniels@collabora.com\u003e\n" }, { "commit": "0e6ac72288f884ba0321c285a65578492c706534", "tree": "7d509a81678a096a1cae79a4e9cf99d734c56e93", "parents": [ "5e0f7ad1bfcaadcc9cfaa1bd3fa78a1442b873a2" ], "author": { "name": "Markus Ongyerth", "email": "wl@ongy.net", "time": "Mon Apr 16 15:01:00 2018 -0500" }, "committer": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Fri Apr 20 13:19:13 2018 -0500" }, "message": "tests: Add free-without-remove test\n\n[Derek Foreman \u003cderekf@osg.samsung.com\u003e moved this into resources-test]\n\nReviewed-by: Derek Foreman \u003cderekf@osg.samsung.com\u003e\n" }, { "commit": "5e0f7ad1bfcaadcc9cfaa1bd3fa78a1442b873a2", "tree": "939211c4f95ce27cd2261a3e61bc179f105ab3fb", "parents": [ "58ee271bff499b6b0d865fa0126990dc478bff24" ], "author": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Mon Apr 16 15:00:59 2018 -0500" }, "committer": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Fri Apr 20 13:19:13 2018 -0500" }, "message": "server: Add special case destroy signal emitter\n\nIn the past much code (weston, efl/enlightenment, mutter) has\nfreed structures containing wl_listeners from destroy handlers\nwithout first removing the listener from the signal. As the\ndestroy notifier only fires once, this has largely gone\nunnoticed until recently.\n\nOther code does not (Qt, wlroots) - and removes itself from\nthe signal before free.\n\nIf somehow a destroy signal is listened to by code from both\nkinds of callers, those that free will corrupt the lists for\nthose that don\u0027t, and Bad Things will happen.\n\nTo avoid these bad things, remove every item from the signal list\nduring destroy emit, and put it in a list all its own. This way\nwhether the listener is removed or not has no impact on the\nfollowing emits.\n\nSigned-off-by: Derek Foreman \u003cderekf@osg.samsung.com\u003e\nReviewed-by: Simon Ser \u003ccontact@emersion.fr\u003e\nReviewed-by: Markus Ongyerth \u003cwl@ongy.net\u003e\n" }, { "commit": "58ee271bff499b6b0d865fa0126990dc478bff24", "tree": "fdde8b0be7fba18705c2b872017055522bfc8e73", "parents": [ "685f9a09097a7c598dd737eb83ea419f6a21b260" ], "author": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Mon Apr 16 15:00:58 2018 -0500" }, "committer": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Fri Apr 20 13:12:57 2018 -0500" }, "message": "tests: Test for use after free in resource destruction signals\n\nFor years it\u0027s been common practice to free the object containing\nthe wl_listener inside resource destruction notifiers, but not\nremove the listener from the list.\n\nThat is: It\u0027s been safe to assume (when only one listener is present)\nthat the wl_listener will never be touched again, since this is\na destruction callback.\n\nRecently some patches were reviewed that made some positive changes\nto our internal signal handling code, but would\u0027ve violated this\nassumption, and changed free()d memory in several existing compositors\n(weston, mutter, enlightenment).\n\nSince the breakage was extremely subtle, codify this assumption in\na test case (thus promoting it to an ABI promise).\n\nReviewed-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\nReviewed-by: Markus Ongyerth \u003cwl@ongy.net\u003e\nSigned-off-by: Derek Foreman \u003cderekf@osg.samsung.com\u003e\n" }, { "commit": "685f9a09097a7c598dd737eb83ea419f6a21b260", "tree": "40020967498a18349a7d2497920012550c9fd79b", "parents": [ "e09c1a98f988d32f8b6fb06aa72da06c93897189" ], "author": { "name": "Dipen Somani", "email": "dipen.somani@samsung.com", "time": "Thu Apr 19 09:01:56 2018 -0500" }, "committer": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Fri Apr 20 13:05:09 2018 -0500" }, "message": "wayland-server: Properly handle EAGAIN from wl_connection_read()\n\ncommit 3cddb3c692acd3536a7cc8542a29f0cc3c0ac3d6 casted len to an\nunsigned value to compare to sizeof results. However,\nwl_connection_read() can fail, setting errno to EAGAIN and returning\na value of -1.\n\nWhen cast to an unsigned type this leads to a loop condition of true\nwhen it should be false.\n\nSigned-off-by: Dipen Somani \u003cdipen.somani@samsung.com\u003e\nSigned-off-by: Derek Foreman \u003cderekf@osg.samsung.com\u003e\nReviewed-by: Derek Foreman \u003cderekf@osg.samsung.com\u003e\n" }, { "commit": "e09c1a98f988d32f8b6fb06aa72da06c93897189", "tree": "53d58e42a98650181bceb751b8cb86b2d2f82b19", "parents": [ "4fdb8530a3dfd43cdd88e89188a7eb468bf8d07c" ], "author": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Mon Apr 09 13:15:31 2018 -0500" }, "committer": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Mon Apr 09 13:15:31 2018 -0500" }, "message": "configure.ac: Reopen master for regular development\n" }, { "commit": "4fdb8530a3dfd43cdd88e89188a7eb468bf8d07c", "tree": "d8f181e6b7fb24f4cebf1cab1f5eaba0d6b62d35", "parents": [ "8be9aa86a2fd0f00f842c4a700633f3521fa9704" ], "author": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Mon Apr 09 11:54:10 2018 -0500" }, "committer": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Mon Apr 09 11:54:10 2018 -0500" }, "message": "configure.ac: bump to version 1.15.0 for the official release\n" }, { "commit": "8be9aa86a2fd0f00f842c4a700633f3521fa9704", "tree": "0a87b41a57dbbf7d0780b6cb0d4f0af232948dd4", "parents": [ "dbcd4cd96e60a7d0fed3916aa6691a5aa681114b" ], "author": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Mon Apr 02 12:50:16 2018 -0500" }, "committer": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Mon Apr 02 12:50:16 2018 -0500" }, "message": "configure.ac: bump to version 1.14.93 for the RC1 release\n" }, { "commit": "dbcd4cd96e60a7d0fed3916aa6691a5aa681114b", "tree": "310554226f147cc6741dc383c5ff42cf637a78ae", "parents": [ "05fd07f4277414ae39a0336ac04c94a58ef2aa96" ], "author": { "name": "Emil Velikov", "email": "emil.velikov@collabora.com", "time": "Tue Mar 20 11:10:45 2018 +0000" }, "committer": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Mon Apr 02 11:01:33 2018 -0500" }, "message": ".gitignore: add wayland-egl-abi-check\n\nInstruct git go ignore the file, in case we\u0027ve done an in-tree build.\n\nCc: Derek Foreman \u003cderekf@osg.samsung.com\u003e\nSigned-off-by: Emil Velikov \u003cemil.velikov@collabora.com\u003e\nReviewed-by: Derek Foreman \u003cderekf@osg.samsung.com\u003e\n" }, { "commit": "05fd07f4277414ae39a0336ac04c94a58ef2aa96", "tree": "bf75468a76ae0b2968b0ec47cf1dfdea4251770a", "parents": [ "d3fe626219ee336d86f1bec980c5c09cce8d68c1" ], "author": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Tue Mar 20 11:01:02 2018 +0000" }, "committer": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Tue Mar 20 10:01:19 2018 -0500" }, "message": "wayland-egl: Ignore underscored symbols in ABI check\n\nRather than a hard-coded list of platform symbols, just ignore anything\nprefaced with an underscore. This fixes breakage on ARM, which declares\nseveral slightly different platform symbols to x86.\n\nSigned-off-by: Daniel Stone \u003cdaniels@collabora.com\u003e\nFixes: 21b1f22eb056 (\"wayland-egl: enhance the symbol test\")\nBugzilla: https://bugs.freedesktop.org/show_bug.cgi?id\u003d105620\nCc: Emil Velikov \u003cemil.velikov@collabora.com\u003e\nReviewed-by: Derek Foreman \u003cderekf@osg.samsung.com\u003e\n" }, { "commit": "d3fe626219ee336d86f1bec980c5c09cce8d68c1", "tree": "96ae948cd43ed032df40a3f39e6eb18f8dbf85b2", "parents": [ "3de11b8d798d657fb59e84792a44dbb027ab523f" ], "author": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Mon Mar 19 15:39:39 2018 -0500" }, "committer": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Mon Mar 19 15:39:39 2018 -0500" }, "message": "configure.ac: bump to version 1.14.92 for the beta release\n" }, { "commit": "3de11b8d798d657fb59e84792a44dbb027ab523f", "tree": "1dad877e6f696b8a1d81635f353879c5c79ebe18", "parents": [ "2031bcf5daef57d1693b5e808fac2bb90affe5cb" ], "author": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Mon Mar 19 15:13:14 2018 +0000" }, "committer": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Mon Mar 19 11:44:28 2018 -0500" }, "message": "wayland-egl: Make symbol test fail on failure\n\nThe previous rewrite of the wayland-egl ABI checker introduced checks\nfor removed symbols as well as added symbols, but broke some failure\nconditions. Add an explict return-code variable set in failure paths,\nrather than chaining or conditions.\n\nIf we cannot find the binary or nm, we regard this as an error\ncondition, rather than test failure.\n\nv2: Don\u0027t test if we can execute $NM.\n\nSigned-off-by: Daniel Stone \u003cdaniels@collabora.com\u003e\nReported-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\nFixes: 21b1f22eb056 (\"wayland-egl: enhance the symbol test\")\nCc: Emil Velikov \u003cemil.velikov@collabora.com\u003e\nReviewed-by: Emil Velikov \u003cemil.velikov@collabora.com\u003e\n" }, { "commit": "2031bcf5daef57d1693b5e808fac2bb90affe5cb", "tree": "b0f3cd58fdfebc92b908a7e50af93ca7c0961aab", "parents": [ "5f5945b71b3139ee81b640821e431b16f1d00021" ], "author": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Mon Mar 19 12:20:54 2018 +0000" }, "committer": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Mon Mar 19 11:39:11 2018 -0500" }, "message": "wayland-egl: Pass nm path to check script\n\nA previous patch used $NM as an environment variable, but this was only\nset as a make variable. Make sure it is passed through from make to the\nenvironment we use to run tests.\n\nv2: Quote argument when passing to shell.\n\nSigned-off-by: Daniel Stone \u003cdaniels@collabora.com\u003e\nReported-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\nFixes: 6903e4d53925 (\"wayland-egl: use correct `nm` path when cross-compiling\")\nCc: Emil Velikov \u003cemil.velikov@collabora.com\u003e\nReviewed-by: Quentin Glidic \u003csardemff7+git@sardemff7.net\u003e\n" }, { "commit": "5f5945b71b3139ee81b640821e431b16f1d00021", "tree": "90484ebe0b3f7b4ed84a793a7593519017416d39", "parents": [ "21b1f22eb056cd9a9c90555749f1744f07b38d3f" ], "author": { "name": "Emil Velikov", "email": "emil.velikov@collabora.com", "time": "Thu Mar 15 14:30:29 2018 +0000" }, "committer": { "name": "Pekka Paalanen", "email": "pekka.paalanen@collabora.co.uk", "time": "Mon Mar 19 11:40:47 2018 +0200" }, "message": "wayland-egl: bump the version number to 18.1.0\n\nSeems like I was overoptimistic with my earlier assumption, namely:\n\n\"... 17.3.x should be the last version that ships the library.\"\n\nMesa 18.0.0 and its wayland-egl is about to be released any time soon,\nso bump the number since it must no be smaller. As soon as we get\na wayland release I\u0027ll drop the Mesa copy but for now.\n\nSigned-off-by: Emil Velikov \u003cemil.velikov@collabora.com\u003e\nReviewed-by: Daniel Stone \u003cdaniels@collabora.com\u003e\n" }, { "commit": "21b1f22eb056cd9a9c90555749f1744f07b38d3f", "tree": "9f13f015f4eec1f648d11a311e40fe41ffa19c19", "parents": [ "2ba70f1f6de52e207aad82680bd4f794d7b99e52" ], "author": { "name": "Emil Velikov", "email": "emil.velikov@collabora.com", "time": "Thu Mar 15 14:30:28 2018 +0000" }, "committer": { "name": "Pekka Paalanen", "email": "pekka.paalanen@collabora.co.uk", "time": "Mon Mar 19 11:40:39 2018 +0200" }, "message": "wayland-egl: enhance the symbol test\n\nThe current test had a few fall-outs:\n - it was checking only for T (.text) symbols\n - did not consider symbol removal\n\nFix that by fetching all the symbols and doing a bidirectional check -\nfor added and removed symbols. Error out with informative message for\neach case.\n\nv2: Rebase on top of $NM patch.\n\nSigned-off-by: Emil Velikov \u003cemil.velikov@collabora.com\u003e\nReviewed-by: Daniel Stone \u003cdaniels@collabora.com\u003e\n" }, { "commit": "2ba70f1f6de52e207aad82680bd4f794d7b99e52", "tree": "eb662a8793db1651f28b49f5194d7954347c496e", "parents": [ "79cc3ad6bd0d7c19b64def8b4e4fea0483993dc6" ], "author": { "name": "Emil Velikov", "email": "emil.velikov@collabora.com", "time": "Thu Mar 15 14:30:27 2018 +0000" }, "committer": { "name": "Pekka Paalanen", "email": "pekka.paalanen@collabora.co.uk", "time": "Mon Mar 19 11:40:20 2018 +0200" }, "message": "wayland-egl: fail the symbol check if lib is missing\n\nBased on a similar patch (in Mesa) by Eric Engestrom.\n\nv2: Rebase on top of $NM patch\nv3: Rebase\n\nReviewed-by: Eric Engestrom \u003ceric@engestrom.ch\u003e (v1)\nSigned-off-by: Emil Velikov \u003cemil.velikov@collabora.com\u003e\nReviewed-by: Daniel Stone \u003cdaniels@collabora.com\u003e\n" }, { "commit": "79cc3ad6bd0d7c19b64def8b4e4fea0483993dc6", "tree": "69fe5c6791818479e5df55b935e6558d4aec75e9", "parents": [ "f34af17b219f1eaa0d091a687124fbb8b7a3c81b" ], "author": { "name": "Emil Velikov", "email": "emil.velikov@collabora.com", "time": "Fri Mar 16 16:14:54 2018 +0000" }, "committer": { "name": "Pekka Paalanen", "email": "pekka.paalanen@collabora.co.uk", "time": "Mon Mar 19 11:39:49 2018 +0200" }, "message": "wayland-egl: set the correct path to libwayland-egl.so\n\nEarlier commit changed to passing the binary name as env. variable\nintroducing a typo.\n\nThat went unnoticed, since we do not check if the file is present or\nnot.\n\nCc: Pukka Paalanen \u003cppaalanen@gmail.com\u003e\nCc: Daniel Stone \u003cdaniels@collabora.com\u003e\nFixes: 85cb5ed64aa (\"wayland-egl-symbols-check: pass the DSO name via\nthe build system\")\nSigned-off-by: Emil Velikov \u003cemil.velikov@collabora.com\u003e\nReviewed-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\n" }, { "commit": "f34af17b219f1eaa0d091a687124fbb8b7a3c81b", "tree": "e90b293b20e83f4d7d8ebea5e3811b1bf36d9eca", "parents": [ "371c26d52b992ed224062cb09e138d0c053b87ff" ], "author": { "name": "Emil Velikov", "email": "emil.velikov@collabora.com", "time": "Tue Mar 13 13:43:37 2018 +0000" }, "committer": { "name": "Pekka Paalanen", "email": "pekka.paalanen@collabora.co.uk", "time": "Fri Mar 16 12:18:07 2018 +0200" }, "message": "configure.ac: don\u0027t install the static libraries\n\nOne should always be using the shared libraries.\n\nSpotted while going through the Debian packaing.\n\nSigned-off-by: Emil Velikov \u003cemil.velikov@collabora.com\u003e\nReviewed-by: Peter Hutterer \u003cpeter.hutterer@who-t.net\u003e\nAcked-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\n" }, { "commit": "371c26d52b992ed224062cb09e138d0c053b87ff", "tree": "1056d7b4aabe8628800f12b2a48ebe594ecebf0f", "parents": [ "adda7cbbb894139d5a35abba41c310a433f693b9" ], "author": { "name": "Pekka Paalanen", "email": "pekka.paalanen@collabora.co.uk", "time": "Wed Feb 14 14:22:23 2018 +0200" }, "committer": { "name": "Pekka Paalanen", "email": "pekka.paalanen@collabora.co.uk", "time": "Thu Mar 15 14:59:24 2018 +0200" }, "message": "tests: disable coredumps on sanity-test\n\nSEGV and ABRT by default cause a core dump, which may create a file,\nlaunch crash handlers, and so on. sanity-test has 21 processes that\nare expected to crash like this. Disable core dumps on them all.\n\nI counted 21 entries in coredumpctl list, while only 16 functions needed\npatching. After this patch no entries appear in coredumpctl list.\n\nSigned-off-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\nReviewed-by: Daniel Stone \u003cdaniels@collabora.com\u003e\n" }, { "commit": "adda7cbbb894139d5a35abba41c310a433f693b9", "tree": "961550b5101f2ac01bc06e043bb3761ee069a456", "parents": [ "a9187853d44db41206b5d16a770d4db108972812" ], "author": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Wed Mar 07 13:38:53 2018 -0600" }, "committer": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Wed Mar 07 13:38:53 2018 -0600" }, "message": "walyand-client: Fix trivial build break from previous commit\n\nprevious commit, a9187853d44db41206b5d16a770d4db108972812 added\na trailing { on a line it shouldn\u0027t have, and I pushed without\nbuilding first.\n\nSigned-off-by: Derek Foreman \u003cderekf@osg.samsung.com\u003e\n" }, { "commit": "a9187853d44db41206b5d16a770d4db108972812", "tree": "11ea8b1fa43d48179636f5e4e1ef4882f699959f", "parents": [ "97351f995c216eff33b02ade0bd63dd089c3af89" ], "author": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Tue Mar 06 17:38:13 2018 -0600" }, "committer": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Wed Mar 07 09:21:28 2018 -0600" }, "message": "client: Don\u0027t inappropriatly close fds for zombie objects\n\ncommit 239ba39331420f953de35c337ae57db35573f9cb which was intended\nto stop leaking fds in events for zombie objects didn\u0027t notice that\npassing 0 to wl_connection_close_fds_in() would still close fds.\n\nTest the fd count before calling.\n\nSigned-off-by: Derek Foreman \u003cderekf@osg.samsung.com\u003e\nReviewed-by: Daniel Stone \u003cdaniels@collabora.com\u003e\n" }, { "commit": "97351f995c216eff33b02ade0bd63dd089c3af89", "tree": "de29f067dfa99ab862d5e961bcf3842090b2b019", "parents": [ "400df40dfa8ec9095b0614a0be45dbea3f2a5895" ], "author": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Mon Feb 26 10:52:17 2018 -0600" }, "committer": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Mon Feb 26 11:37:44 2018 -0600" }, "message": "configure.ac: bump to version 1.14.91 for the alpha release\n" }, { "commit": "400df40dfa8ec9095b0614a0be45dbea3f2a5895", "tree": "1ef8239a596351b0224c5b089d23fee7f8cafb6e", "parents": [ "e501230d1dc8a5015616e104ec0e08886a0b88df" ], "author": { "name": "Pekka Paalanen", "email": "pekka.paalanen@collabora.co.uk", "time": "Mon Feb 26 11:44:25 2018 +0200" }, "committer": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Mon Feb 26 07:35:04 2018 -0600" }, "message": "tests: fix scanner private-code test reference data\n\nCommit e501230d1dc8a5015616e104ec0e08886a0b88df \"scanner: Fix broken\nprivate-code generation\" changed the scanner output without updating the\nreference output for scanner tests.\n\nUpdate the reference data. This fixes \u0027make check\u0027.\n\nSigned-off-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\nReviewed-by: Derek Foreman \u003cderekf@osg.samsung.com\u003e\n" }, { "commit": "e501230d1dc8a5015616e104ec0e08886a0b88df", "tree": "2e59a0b0df5c4c422cf484278533249a5afb2646", "parents": [ "6903e4d5392563b36aabc8ebc69cb1a08dd2de0e" ], "author": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Fri Feb 23 16:23:15 2018 -0600" }, "committer": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Fri Feb 23 16:41:40 2018 -0600" }, "message": "scanner: Fix broken private-code generation\n\nMissing a closing bracket.\n\nReviewed-by: Daniel Stone \u003cdaniels@collabora.com\u003e\n" }, { "commit": "6903e4d5392563b36aabc8ebc69cb1a08dd2de0e", "tree": "3c28b0d9709bd4bc2ee1de8466226ee208da03f6", "parents": [ "b02c4013e3c10d26c6afae675eec77a97c4c10ab" ], "author": { "name": "Emil Velikov", "email": "emil.velikov@collabora.com", "time": "Fri Feb 23 17:31:53 2018 +0000" }, "committer": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Fri Feb 23 17:38:22 2018 +0000" }, "message": "wayland-egl: use correct `nm` path when cross-compiling\n\nInspired by Heiko Becker and Eric\u0027s work in libdrm and Mesa\nrespectively.\n\nCc: Eric Engestrom \u003ceric.engestrom@imgtec.com\u003e\nSigned-off-by: Emil Velikov \u003cemil.velikov@collabora.com\u003e\nReviewed-by: Daniel Stone \u003cdaniels@collabora.com\u003e\n" }, { "commit": "b02c4013e3c10d26c6afae675eec77a97c4c10ab", "tree": "00fe1a02914e187c72d787c005ef6c0a429c01fa", "parents": [ "bd92689382e5f401c6de26bdb8856cc3584f5c3a" ], "author": { "name": "Emil Velikov", "email": "emil.velikov@collabora.com", "time": "Thu Feb 22 11:23:39 2018 +0000" }, "committer": { "name": "Pekka Paalanen", "email": "pekka.paalanen@collabora.co.uk", "time": "Thu Feb 22 13:51:50 2018 +0200" }, "message": "tests: add code, public-code and private-code tests\n\nFirst one is deprecated in favour of the second option.\n\nThe latter is newly introduced and annotates the generated symbols\naccordingly.\n\nv2: Don\u0027t introduce small-public-code.c - reuse small-code.c (Pekka)\n\nCc: Pekka Paalanen \u003cppaalanen@gmail.com\u003e\nSigned-off-by: Emil Velikov \u003cemil.velikov@collabora.com\u003e\nReviewed-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\nReviewed-by: Derek Foreman \u003cderekf@osg.samsung.com\u003e\n" }, { "commit": "bd92689382e5f401c6de26bdb8856cc3584f5c3a", "tree": "11015d77ad468916aff8764068ef0a14566d57d9", "parents": [ "ab6b156920ced7dfac94e01cada216171b619891" ], "author": { "name": "Emil Velikov", "email": "emil.velikov@collabora.com", "time": "Fri Feb 16 16:22:32 2018 +0000" }, "committer": { "name": "Pekka Paalanen", "email": "pekka.paalanen@collabora.co.uk", "time": "Thu Feb 22 11:56:57 2018 +0200" }, "message": "scanner: make use of __has_attribute()\n\nA more generic way to evaluating various attributes, __has_attribute is\navailable with gcc, clang, even the Oracle/Sun compiler.\n\nSigned-off-by: Emil Velikov \u003cemil.velikov@collabora.com\u003e\nReviewed-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\nReviewed-by: Derek Foreman \u003cderekf@osg.samsung.com\u003e\n" }, { "commit": "ab6b156920ced7dfac94e01cada216171b619891", "tree": "cfc63ea80a0702b0b868fbde72a66e31c709ad0a", "parents": [ "9b76def674f0a0b99f5850cc800017fc4e03af7d" ], "author": { "name": "Emil Velikov", "email": "emil.velikov@collabora.com", "time": "Fri Feb 16 16:22:31 2018 +0000" }, "committer": { "name": "Pekka Paalanen", "email": "pekka.paalanen@collabora.co.uk", "time": "Thu Feb 22 11:56:57 2018 +0200" }, "message": "build: use public-code when using the local wayland-scanner\n\nThe core wayland interfaces are public, via the libwayland-server and\nlibwayland-client DSOs. Hence use \"public-code\" cmdline option, instead\nof the deprecated code\".\n\nAs the host wayland-scanner may not know about the new option, use the\nlegacy \"code\".\n\nSigned-off-by: Emil Velikov \u003cemil.velikov@collabora.com\u003e\nReviewed-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\nReviewed-by: Derek Foreman \u003cderekf@osg.samsung.com\u003e\n" }, { "commit": "9b76def674f0a0b99f5850cc800017fc4e03af7d", "tree": "6334042d5c0c41ead2cc55de97243969b86c032d", "parents": [ "76a4e4251c4e5db7b87fe2240573115e09ba143f" ], "author": { "name": "Emil Velikov", "email": "emil.velikov@collabora.com", "time": "Fri Feb 16 16:22:30 2018 +0000" }, "committer": { "name": "Pekka Paalanen", "email": "pekka.paalanen@collabora.co.uk", "time": "Thu Feb 22 11:56:57 2018 +0200" }, "message": "scanner: introduce \"public-code\" and \"private-code\"\n\nThe options are used to indicate how the code will be used - will it be\npublic, as part of a DSO or private.\n\nIn nearly every instance, people want to use the latter. One noticeable\nexception is the wayland libraries. They provide the base marshalling\nprotocol that everyone uses.\n\nThe option \"code\" was deprecated in favour of \"public-code\" with a\nwarning message produced to guide people.\n\nSigned-off-by: Emil Velikov \u003cemil.velikov@collabora.com\u003e\nReviewed-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\nReviewed-by: Derek Foreman \u003cderekf@osg.samsung.com\u003e\n" }, { "commit": "76a4e4251c4e5db7b87fe2240573115e09ba143f", "tree": "4761b004ea4230283a652e8325889979a99d488d", "parents": [ "68398ec2cec755651a4d97a134241427670a5f34" ], "author": { "name": "Emil Velikov", "email": "emil.velikov@collabora.com", "time": "Tue Feb 21 16:14:29 2017 +0000" }, "committer": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Fri Feb 16 14:41:08 2018 +0000" }, "message": "build: remove white space in -uninstalled.pc.in files\n\nv2: Rebase, address wayland-client-uninstalled\n\nSigned-off-by: Emil Velikov \u003cemil.velikov@collabora.com\u003e\nReviewed-by: Derek Foreman \u003cderekf@osg.samsung.com\u003e (v1)\n" }, { "commit": "68398ec2cec755651a4d97a134241427670a5f34", "tree": "76ece189e058cda25eddb9f982287c99f8813ea8", "parents": [ "9fa60983b5799be62b9d88a4059f4d0038d7c80d" ], "author": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Wed Feb 14 12:15:11 2018 -0600" }, "committer": { "name": "Pekka Paalanen", "email": "pekka.paalanen@collabora.co.uk", "time": "Thu Feb 15 09:26:08 2018 +0200" }, "message": "connection: Fix broken log message when demarshalling short closure\n\nLike the similar wl_log() message further into this function that was\nfixed in commit 2fc248dc2c877d02694db40aad52180d71373d5a this should\nbe printing the sender_id saved earlier instead of *p.\n\nSince p is incremented during the loop it would not only print an\nincorrect object id, it could read past the end of the array.\n\nSigned-off-by: Derek Foreman \u003cderekf@osg.samsung.com\u003e\nReviewed-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\n" }, { "commit": "9fa60983b5799be62b9d88a4059f4d0038d7c80d", "tree": "2af75900436284817460ce8d79f559e782ea5655", "parents": [ "8d8f2600ecd3b017cb93d34e037cdae27fcded59" ], "author": { "name": "Emil Velikov", "email": "emil.velikov@collabora.com", "time": "Wed Dec 13 12:03:54 2017 +0000" }, "committer": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Fri Feb 09 17:34:19 2018 +0000" }, "message": "wayland-egl: rename wl_egl_window::private to driver_private\n\nprivate is a reserved keyword in C++. Thus if one is to have a backend\ndriver written in said language build will fail as below:\n\n.../wayland-egl-backend.h:56:8: expected unqualified-id before ‘private’\n\nRename it to driver_private and update the test.\n\nNOTE: version bump is not required since:\n - this is a pure API change, ABI is identical\n - hardware drivers already require [minor] changes to move to the\nupstream wayland-egl-backend.h\n\nCc: Arnaud Vrac \u003crawoul@gmail.com\u003e\nCc: Miguel A . Vico \u003cmvicomoya@nvidia.com\u003e\nSuggested-by: Arnaud Vrac \u003crawoul@gmail.com\u003e\nSigned-off-by: Emil Velikov \u003cemil.velikov@collabora.com\u003e\nReviewed-by: Miguel A Vico Moya \u003cmvicomoya@nvidia.com\u003e\n" }, { "commit": "8d8f2600ecd3b017cb93d34e037cdae27fcded59", "tree": "90db988f984db208100416ba497914e478e501bb", "parents": [ "85cb5ed64aa8246f4da93fc5b76dfc34096bf803" ], "author": { "name": "Emil Velikov", "email": "emil.velikov@collabora.com", "time": "Tue Oct 10 14:43:50 2017 +0100" }, "committer": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Fri Feb 09 17:31:06 2018 +0000" }, "message": "wayland-egl: move the wayland-egl{, -core}.h headers to egl/\n\nNow we have all the wayland-egl bits in a single place.\n\nSigned-off-by: Emil Velikov \u003cemil.velikov@collabora.com\u003e\nReviewed-by: Arnaud Vrac \u003cavrac@freebox.fr\u003e\n" }, { "commit": "85cb5ed64aa8246f4da93fc5b76dfc34096bf803", "tree": "c6d273f5b9b3d8f4bcb662c475b57137af85b7ca", "parents": [ "1fcb4d1387e2a40ed8cd35b11a7788de52b9cdb9" ], "author": { "name": "Emil Velikov", "email": "emil.velikov@collabora.com", "time": "Tue Oct 10 14:43:49 2017 +0100" }, "committer": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Fri Feb 09 17:31:03 2018 +0000" }, "message": "wayland-egl-symbols-check: pass the DSO name via the build system\n\nThe location of the file is build system specific so, keep it there.\n\nCc: Daniel Stone \u003cdaniels@collabora.com\u003e\nSuggested-by: Daniel Stone \u003cdaniels@collabora.com\u003e\nSigned-off-by: Emil Velikov \u003cemil.velikov@collabora.com\u003e\nReviewed-by: Arnaud Vrac \u003cavrac@freebox.fr\u003e\n" }, { "commit": "1fcb4d1387e2a40ed8cd35b11a7788de52b9cdb9", "tree": "f52a5c0b88df111cb77e40c1615964c1c9f37bda", "parents": [ "066113a4c8cc6837519beab711d22cf01997ff11" ], "author": { "name": "Emil Velikov", "email": "emil.velikov@collabora.com", "time": "Tue Oct 10 14:43:48 2017 +0100" }, "committer": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Fri Feb 09 17:31:00 2018 +0000" }, "message": "build: wire-up wayland-egl\n\nWire-up the imported sources, test and pkg-config files.\n\nv2:\n - Don\u0027t mangle with existing EXTRA_DIST list\n - Add the symbols check script to the `make check\u0027 target\n - Rename wayland-egl-{priv,backend}.h\n\nSigned-off-by: Emil Velikov \u003cemil.velikov@collabora.com\u003e\nReviewed-by: Arnaud Vrac \u003cavrac@freebox.fr\u003e\n" }, { "commit": "066113a4c8cc6837519beab711d22cf01997ff11", "tree": "b7c6d08b44b6a6e522551ee4845609cdce9ab88e", "parents": [ "bf3f9e241315cec472a482b5625c537d41dae6ab" ], "author": { "name": "Emil Velikov", "email": "emil.velikov@collabora.com", "time": "Tue Oct 10 14:43:47 2017 +0100" }, "committer": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Fri Feb 09 17:30:57 2018 +0000" }, "message": "wayland-egl: add a note about keeping the backend version in sync\n\nSigned-off-by: Emil Velikov \u003cemil.velikov@collabora.com\u003e\nReviewed-by: Arnaud Vrac \u003cavrac@freebox.fr\u003e\n" }, { "commit": "bf3f9e241315cec472a482b5625c537d41dae6ab", "tree": "9e0f65e919307c6b5e9caf4692bcae23f9880ee7", "parents": [ "6c7f96e8fea04ae81296b6188fb1aca6cd0391aa" ], "author": { "name": "Emil Velikov", "email": "emil.velikov@collabora.com", "time": "Tue Oct 10 14:43:46 2017 +0100" }, "committer": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Fri Feb 09 17:30:54 2018 +0000" }, "message": "wayland-egl: introduce wayland-egl-backend.pc\n\nFile will be installed alongside the backend header.\n\nThis way vendor implementations have enough information about the\ninterface and they can build their backend/driver library accordingly.\n\nCc: Miguel A. Vico \u003cmvicomoya@nvidia.com\u003e\nCc: James Jones \u003cjajones@nvidia.com\u003e\nCc: Daniel Stone \u003cdaniels@collabora.com\u003e\nCc: duncan-roe \u003cduncan_roe@optusnet.com.au\u003e\nCc: Takanari Hayama \u003ctaki@igel.co.jp\u003e\nSigned-off-by: Emil Velikov \u003cemil.velikov@collabora.com\u003e\nReviewed-by: Miguel A Vico Moya \u003cmvicomoya@nvidia.com\u003e\nReviewed-by: Arnaud Vrac \u003cavrac@freebox.fr\u003e\n" }, { "commit": "6c7f96e8fea04ae81296b6188fb1aca6cd0391aa", "tree": "37fc7198337bdf4ae636d9ea1e5c8469917da7ff", "parents": [ "d71e4ca501c54889c81526eba46fafa8f26d89a9" ], "author": { "name": "Emil Velikov", "email": "emil.velikov@collabora.com", "time": "Tue Oct 10 14:43:45 2017 +0100" }, "committer": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Fri Feb 09 17:30:50 2018 +0000" }, "message": "wayland-egl: correct wayland-egl.pc description/version\n\nDrop the \"Mesa\" part from the commit message and change the version to\n17.4.0. The number bears references from its Mesa heritage.\n\nCurrently Mesa provides 17.2.x while 17.3.x should be the last version\nthat ships the library.\n\nSome version numbers of wayland-egl.pc providers and users.\nThe latter is taken from Ubuntu 17.04.\n\nProviders:\n - Mali: 7.10\n - Mesa: 17.2.2\n\nUsers:\n - retroarch: NA\n - qtwayland5: NA\n - mpv, libmpv1: 9.0\n - mesa-utils-extra: NA\n - weston, libweston-1-0: NA\n\n - libwaffle-1-0: 9.1\n - libsdl2-2.0-0: NA\n\n - libgstreamer-plugins-bad1.0-0: autotools 9.0, meson 1.0\n - libglfw3-wayland: NA\n\n - kwin-wayland, kwin-wayland-backend-wayland: NA?\n - glmark2-wayland, glmark2-es2-wayland: NA\n\n - libwebkit2gtk-4.0-37, libwebkit2gtk-4.0-37-gtk2, (webkit overall): NA\n - libgtk-3-0 (gtk overall): NA\n - libcogl20 (cogl overall): 1.0.0\n\nv2: Bump the version to 17.4.0\n\nSigned-off-by: Emil Velikov \u003cemil.velikov@collabora.com\u003e\nReviewed-by: Arnaud Vrac \u003cavrac@freebox.fr\u003e\n" }, { "commit": "d71e4ca501c54889c81526eba46fafa8f26d89a9", "tree": "c2b6e5c8d621f724bd7144b8b5e6d4d2aa230584", "parents": [ "549a5ea710f4da1a5749587176d39fef1ded4077" ], "author": { "name": "Emil Velikov", "email": "emil.velikov@collabora.com", "time": "Tue Oct 10 14:43:44 2017 +0100" }, "committer": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Fri Feb 09 17:30:47 2018 +0000" }, "message": "wayland-egl: reuse the existing WL_EXPORT macro\n\nThere\u0027s little point if redefining new one ourselves. Just reuse the one\nthat\u0027s already available.\n\nCc: Daniel Stone \u003cdaniels@collabora.com\u003e\nSuggested-by: Daniel Stone \u003cdaniels@collabora.com\u003e\nSigned-off-by: Emil Velikov \u003cemil.velikov@collabora.com\u003e\nReviewed-by: Arnaud Vrac \u003cavrac@freebox.fr\u003e\n" }, { "commit": "549a5ea710f4da1a5749587176d39fef1ded4077", "tree": "fbd52f82e728f6823476e63ef984ccf40d635501", "parents": [ "0fa3474be36be5fee98bebb169df68dcf806e3f3" ], "author": { "name": "Emil Velikov", "email": "emil.velikov@collabora.com", "time": "Tue Oct 10 14:43:43 2017 +0100" }, "committer": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Fri Feb 09 17:30:36 2018 +0000" }, "message": "wayland-egl: import libwayland-egl.so frontend library from Mesa\n\nCurrently the client-facing libwayland-egl API is defined by a header\nfile shipped by Wayland, but the implementation is left to each vendor.\n\nThis can cause collisions when multiple implementations are installed on\nthe same system. Importing the implementation into Wayland with a stable\nand versioned driver-facing ABI allows multiple drivers to coexist on\nthe same system.\n\nPull the sample implementation from Mesa commit 677edff5cfd\n(\"wayland-egl: rework and simplify wl_egl_window initialization\")\nIt has been used by the Mesa open source drivers, NVIDIA and others[1].\n\nv2: Reword commit message, rebase on top of newer Mesa.\n\n[1] https://github.com/thayama/wayland-egl\n\nCc: Miguel A. Vico \u003cmvicomoya@nvidia.com\u003e\nCc: James Jones \u003cjajones@nvidia.com\u003e\nCc: Daniel Stone \u003cdaniels@collabora.com\u003e\nCc: duncan-roe \u003cduncan_roe@optusnet.com.au\u003e\nCc: Takanari Hayama \u003ctaki@igel.co.jp\u003e\nSuggested-by: Daniel Stone \u003cdaniels@collabora.com\u003e\nSigned-off-by: Emil Velikov \u003cemil.velikov@collabora.com\u003e\nReviewed-by: Miguel A Vico Moya \u003cmvicomoya@nvidia.com\u003e\nReviewed-by: Arnaud Vrac \u003cavrac@freebox.fr\u003e\n" }, { "commit": "0fa3474be36be5fee98bebb169df68dcf806e3f3", "tree": "19c1cbdeadb3209e0129a91f3c75cda46f5bb054", "parents": [ "bf7cc6805396af8df3b40e10c63de701346c93dd" ], "author": { "name": "Olivier Fourdan", "email": "ofourdan@redhat.com", "time": "Mon Feb 05 15:39:43 2018 +0100" }, "committer": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Fri Feb 09 17:03:28 2018 +0000" }, "message": "shm: provide actual error on mmap failed\n\nWhen an mmap() fails, a WL_SHM_ERROR_INVALID_FD is raised and the client\nis killed.\n\nHowever, there is no indication of the actual system error that caused\nmmap() to fail, which makes such error harder to investigate.\n\nProvide the actual error message that caused mmap() to fail.\n\nSigned-off-by: Olivier Fourdan \u003cofourdan@redhat.com\u003e\nReviewed-by: Jonas Ådahl \u003cjadahl@gmail.com\u003e\n" }, { "commit": "bf7cc6805396af8df3b40e10c63de701346c93dd", "tree": "aff21a2baebdb50b55fdeaa739d028e5e1d8754d", "parents": [ "ef48ff21f0468c428127d131b27cbddc627a83a6" ], "author": { "name": "Simon Ser", "email": "contact@emersion.fr", "time": "Wed Dec 13 11:51:19 2017 +0100" }, "committer": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Fri Feb 09 17:00:04 2018 +0000" }, "message": "server: add wl_display_destroy_clients()\n\nBug [1] reported that wl_display_destroy() doesn\u0027t destroy clients, so\nclient socket file descriptors are being kept open until the compositor\nprocess exits.\n\nPatch [2] proposed to destroy clients in wl_display_destroy(). The\npatch was not accepted because doing so changes the ABI.\n\nThus, a new wl_display_destroy_clients() function is added in this\npatch. It should be called by compositors right before\nwl_display_destroy().\n\n[1] https://bugs.freedesktop.org/show_bug.cgi?id\u003d99142\n[2] https://patchwork.freedesktop.org/patch/128832/\n\nSigned-off-by: Simon Ser \u003ccontact@emersion.fr\u003e\nReviewed-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\nAcked-by: Daniel Stone \u003cdaniels@collabora.com\u003e\n" }, { "commit": "ef48ff21f0468c428127d131b27cbddc627a83a6", "tree": "53ab155ac4d2b85ae6bbd0fbbccdff0bd1a259ba", "parents": [ "e5b52f673c508a5f95c88c6cc99026cd2b762b5e" ], "author": { "name": "Philipp Kerling", "email": "pkerling@casix.org", "time": "Wed Jan 24 14:28:15 2018 +0100" }, "committer": { "name": "Pekka Paalanen", "email": "pekka.paalanen@collabora.co.uk", "time": "Fri Feb 09 10:06:33 2018 +0200" }, "message": "doc: Document behavior of non-nullable object arguments in clients\n\nReviewed-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\n" }, { "commit": "e5b52f673c508a5f95c88c6cc99026cd2b762b5e", "tree": "cc66036865ce1e60c5abefb82de0a9f510ee9122", "parents": [ "118aaec480a1153cccc81a38a69c1b6571d98b36" ], "author": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Fri Jan 19 15:20:31 2018 -0600" }, "committer": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Mon Jan 22 09:45:47 2018 +0000" }, "message": "connection: Clear correct args when clearing fds to -1\n\ncommit 52609ddf79a96fee0465006e2c6339a3a5d23a87 was intended to\nset fds to -1 in the arg list, however it failed to account for\nversion information at the start of signatures.\n\nMost noticably, this broke mesa\u0027s create_prime_buffer by setting\nwidth to -1 instead of the fd, as the width was the argument\nfollowing the fd, and the version was one byte long.\n\nThis should close https://bugs.kde.org/show_bug.cgi?id\u003d389200\n\nSigned-off-by: Derek Foreman \u003cderekf@osg.samsung.com\u003e\nReviewed-by: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\nReviewed-by: Daniel Stone \u003cdaniels@collabora.com\u003e\n" }, { "commit": "118aaec480a1153cccc81a38a69c1b6571d98b36", "tree": "75529b109ef06c24fd5d6a93e1daa1ad457221ca", "parents": [ "35ab47567cca5bafe80e193b9c6f134c78ef3871" ], "author": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Fri Jan 19 11:51:35 2018 -0600" }, "committer": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Fri Jan 19 11:54:26 2018 -0600" }, "message": "tests: Add missing file to distribution\n\nIn f74c9b98db49ce16e037c3012590c4a24a4fc32e I added tests.xml to the\nrepository, but not to the distribution tarball.\n\nSigned-off-by: Derek Foreman \u003cderekf@osg.samsung.com\u003e\nReviewed-by: Quentin Glidic \u003csardemff7+git@sardemff7.net\u003e\nReviewed-by: Daniel Stone \u003cdaniels@collabora.com\u003e\n" }, { "commit": "35ab47567cca5bafe80e193b9c6f134c78ef3871", "tree": "ea85f5e8543fbcfa4c33175765353508483f812c", "parents": [ "ff992951a7e6da0a8e54786ef7371ae420ce6c9c" ], "author": { "name": "Fiedler, Mathias", "email": "mathias_fiedler@mentor.com", "time": "Tue Dec 05 09:49:52 2017 +0100" }, "committer": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Fri Jan 19 11:05:59 2018 -0600" }, "message": "server: add log message when client connection is destroyed due to an error\n\nThe client connection is destroyed by the server in several\ncircumstances. This patch adds log messages in case the connection is\ndestroyed due to an error other than normal hangup.\n\nSigned-off-by: Mathias Fiedler \u003cmathias_fiedler@mentor.com\u003e\nReviewed-by: Derek Foreman \u003cderekf@osg.samsung.com\u003e\n" }, { "commit": "ff992951a7e6da0a8e54786ef7371ae420ce6c9c", "tree": "98b722598f05dd541a6fbf1a9f2b7c154664e943", "parents": [ "f74c9b98db49ce16e037c3012590c4a24a4fc32e" ], "author": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Wed Dec 06 11:22:25 2017 -0600" }, "committer": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Tue Jan 09 15:20:00 2018 +0000" }, "message": "tests: Check for wrong fd delivery with zombie objects\n\nUntil recently, if an event attempting to deliver an fd to a zombie\nobject was demarshalled after the object was made into a zombie, we\nleaked the fd and left it in the buffer.\n\nIf another event attempting to deliver an fd to a live object was in that\nsame buffer, the zombie\u0027s fd would be delivered instead.\n\nThis test recreates that situation.\n\nWhile this is a ridiculously contrived way to force this race - delivering\nan event from a destruction handler - I do have reports of this race\nbeing hit in real world code.\n\nSigned-off-by: Derek Foreman \u003cderekf@osg.samsung.com\u003e\nAcked-by: Daniel Stone \u003cdaniels@collabora.com\u003e\n" }, { "commit": "f74c9b98db49ce16e037c3012590c4a24a4fc32e", "tree": "5e7afcd3ea20b6ee0d12d27405fbd245c2568d40", "parents": [ "239ba39331420f953de35c337ae57db35573f9cb" ], "author": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Wed Dec 06 11:22:24 2017 -0600" }, "committer": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Tue Jan 09 15:20:00 2018 +0000" }, "message": "tests: Add a test for fd leaks on zombie objects\n\nUntil recently, if a client destroying a resource raced with the\nserver generating an event on that resource that delivered a file\ndescriptor, we would leak the fd.\n\nThis tests for a leaked fd from that race condition.\n\nReviewed-by: Daniel Stone \u003cdaniels@collabora.com\u003e\nSigned-off-by: Derek Foreman \u003cderekf@osg.samsung.com\u003e\n" }, { "commit": "239ba39331420f953de35c337ae57db35573f9cb", "tree": "3c8efe369f2a4aa7151b8fe2f22d206a9eeeff29", "parents": [ "4485ed1f59cb8695f3ab690e074abd7e79a27640" ], "author": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Wed Dec 06 11:22:23 2017 -0600" }, "committer": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Tue Jan 09 15:20:00 2018 +0000" }, "message": "client: Consume file descriptors destined for zombie proxies\n\nWe need to close file descriptors sent to zombie proxies to avoid leaking\nthem, and perhaps more importantly, to prevent them from being dispatched\nin events on other objects (since they would previously be left in the\nbuffer and potentially fed to following events destined for live proxies)\n\nSigned-off-by: Derek Foreman \u003cderekf@osg.samsung.com\u003e\nReviewed-by: Daniel Stone \u003cdaniels@collabora.com\u003e\n" }, { "commit": "4485ed1f59cb8695f3ab690e074abd7e79a27640", "tree": "b71d081fc0b8c44340460b045622fcfc3d839aeb", "parents": [ "9744de9f472ec1e3c0e5b3416c097255e3bfdf12" ], "author": { "name": "Derek Foreman", "email": "derekf@osg.samsung.com", "time": "Wed Dec 06 11:22:22 2017 -0600" }, "committer": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Tue Jan 09 15:20:00 2018 +0000" }, "message": "client: Replace the singleton zombie with bespoke zombies\n\nUsing the singleton zombie object doesn\u0027t allow us to posthumously retain\nobject interface information, which makes it difficult to properly inter\nfuture events destined for the recently deceased proxy.\n\nNotably, this makes it impossible for zombie proxy destined file\ndescriptors to be properly consumed.\n\nWhen we create a proxy, we now create a zombie-state object to hold\ninformation about the file descriptors in events it can receive. This\nwill allow us, in a future patch, to close those FDs.\n\n[daniels: Split Derek\u0027s patch into a few smaller ones.]\n\nSigned-off-by: Derek Foreman \u003cderekf@osg.samsung.com\u003e\nReviewed-by: Daniel Stone \u003cdaniels@collabora.com\u003e\n" }, { "commit": "9744de9f472ec1e3c0e5b3416c097255e3bfdf12", "tree": "4948cc4024b6333d2655e03b1225066aea7a3405", "parents": [ "430c7820c31608dd29408fc800530b4fd08ff777" ], "author": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Thu Dec 28 16:05:59 2017 +0000" }, "committer": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Tue Jan 09 15:19:52 2018 +0000" }, "message": "client: Plug a race in proxy destruction vs. dispatch\n\nClosures created to hold events which will be dispatched on the client,\ntake a reference to the proxy for the object the event was sent to, as\nwell as the proxies for all objects referenced in that event.\n\nThese references are dropped immediately before dispatch, with the\ndisplay lock also being released. This leaves the potential for a\nvanishingly small race, where another thread drops the last reference\non one of the proxies used in an event as it is being dispatched.\n\nFix this by splitting decrease_closure_args_refcount into two functions:\none which validates the objects (to ensure that clients are not returned\nobjects which they have destroyed), and another which unrefs all proxies\non the closure (object event was sent to, all referenced objects) as\nwell as the closure itself. For symmetry, increase_closure_args_refcount\nis now the place where the refcount for the proxy for the object the\nevent was sent to, is increased.\n\nThis also happens to fix a bug: previously, if an event was sent to a\nclient-destroyed object, and the event had object arguments, a reference\nwould be leaked on the proxy for each of the object arguments.\n\nFound by inspection whilst reviewing the zombie-FD-leak series.\n\nSigned-off-by: Daniel Stone \u003cdaniels@collabora.com\u003e\nReviewed-by: Derek Foreman \u003cderekf@osg.samsung.com\u003e\nCc: Jonas Ådahl \u003cjadahl@gmail.com\u003e\nCc: Pekka Paalanen \u003cpekka.paalanen@collabora.co.uk\u003e\n" }, { "commit": "430c7820c31608dd29408fc800530b4fd08ff777", "tree": "d637ae0d8b1839ab166c8321ccf465e8cba1c9dd", "parents": [ "b39d8933973394432bf994b0c6e564fdaceb4757" ], "author": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Thu Dec 28 15:50:06 2017 +0000" }, "committer": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Tue Jan 09 15:18:04 2018 +0000" }, "message": "client: Add wl_proxy_unref helper\n\nRather than open-coded decrement-and-maybe-free, introduce a\nwl_proxy_unref helper to do this for us. This will come in useful for\nfuture patches, where we may also have to free a zombie object.\n\nSigned-off-by: Daniel Stone \u003cdaniels@collabora.com\u003e\nReviewed-by: Derek Foreman \u003cderekf@osg.samsung.com\u003e\nCc: Jonas Ådahl \u003cjadahl@gmail.com\u003e\n" }, { "commit": "b39d8933973394432bf994b0c6e564fdaceb4757", "tree": "a17836cf77829da6fcf9cd7fff6dcffa947fb1bd", "parents": [ "c380adc554a3d0e2a567ff07deab020a3068304c" ], "author": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Thu Dec 28 15:41:18 2017 +0000" }, "committer": { "name": "Daniel Stone", "email": "daniels@collabora.com", "time": "Tue Jan 09 15:17:58 2018 +0000" }, "message": "client: Use refcount exclusively for destruction\n\nCommit e273c7cde added a refcount to wl_proxy. The refcount is set to 1\non creation, decreased when the client explicitly destroys the proxy,\nand is increased and decreased every time an event referencing that\nproxy is queued.\n\nAssuming no bugs, this means the refcount cannot reach 0 without the\nproxy being explicitly destroyed. However, some (not all) of the\nproxy-unref paths were only destroying the proxy if it had already been\ndeleted. This should already be enforced by refcounting, so remove the\ncheck and rely solely on the refcount as the arbiter of when to free a\nproxy.\n\nSigned-off-by: Daniel Stone \u003cdaniels@collabora.com\u003e\nReviewed-by: Derek Foreman \u003cderekf@osg.samsung.com\u003e\nCc: Jonas Ådahl \u003cjadahl@gmail.com\u003e\n" } ], "next": "c380adc554a3d0e2a567ff07deab020a3068304c" }