commit | d158ca4bde2954414cbe302d3ffd4b676ab19b44 | [log] [tgz] |
---|---|---|
author | Ricardo Garcia <rgarcia@igalia.com> | Wed Jun 01 17:31:23 2022 +0200 |
committer | Matthew Netsch <quic_mnetsch@quicinc.com> | Thu Jun 09 19:08:26 2022 +0000 |
tree | 0758c2adce1390073e931e45e25eef92242a4e32 | |
parent | f2ccbefaf8b9ba78801f5cffb4dafc314943343c [diff] |
Forbid implicit cast from Move<T> to bool Take the following code: Move<VkPipelineLayout> smartLayout = ...; VkPipelineLayout rawLayout = smartLayout; That builds and applies the following implicit conversions: Move<T> -> bool -> VkPipelineLayout Which doesn't make any sense (the raw handle ends up having value "1") and it's arguably an easy typo to make, when the second line should actually have been one of: VkPipelineLayout rawLayout = *smartLayout; VkPipelineLayout rawLayout = smartLayout.get(); This commit disallows the implicit conversions from Move<T> to bool and makes the typo fail compilatoin on purpose. It also fixes one instance of such typo in the affected test, which was causing issues when implementing graphics pipeline libraries in RADV. Note the test also touches vktRenderPassTests.cpp, but the change should not affect any test result there. Affected tests: dEQP-VK.pipeline.pipeline_library.graphics_library.misc.timing.compare_link_times VK-GL-CTS issue: 3735 Components: Vulkan Change-Id: Id968a1e74f6246e592257f7b3675c80e3363feaf
This repository contains a GPU testing suite called dEQP (drawElements Quality Program). dEQP contains tests for several graphics APIs, including OpenGL ES, EGL, and Vulkan.
Up-to-date documentation for dEQP is available at:
The .qpa logs generated by the conformance tests may contain embedded PNG images of the results. These can be viewed with scripts/qpa_image_viewer.html
, by opening the file with a web browser and following its instructions, or using the Cherry tool.
This repository includes Khronos Vulkan CTS under external/vulkancts
directory. For more information see Vulkan CTS README.
This repository includes Khronos OpenGL / OpenGL ES CTS under external/openglcts
directory. For more information see OpenGL / OpenGL ES CTS README.
ANGLE can be built for Android by following the instructions here.
The resulting ANGLE shared object libraries can be linked against and embedded into dEQP.apk
with the --angle-path
option. This will cause dEQP.apk
to use the ANGLE libraries for OpenGL ES calls, rather than the native drivers.
An ABI must be specified and the directory structure containing the ANGLE shared objects must match it so the build system can find the correct *.so
files.
Assuming ANGLE shared objects are generated into ~/chromium/src/out/Release/
and dEQP.apk
will be generated with --abis arm64-v8a
, issue the following commands:
cd ~/chromium/src/out/Release/ mkdir arm64-v8a && cd arm64-v8a cp ../lib*_angle.so .
The --angle-path ~/chromium/src/out/Release/
option can then be used to link against and embed the ANGLE shared object files. The full command would be:
python scripts/android/build_apk.py --sdk <path to Android SDK> --ndk <path to Android NDK> --abis arm64-v8a --angle-path ~/chromium/src/out/Release/