)]}' { "log": [ { "commit": "11ad5a7b564fcb91be3635a112e81687d8524ce2", "tree": "c59bc865787b66745ad0e5acd5ebc47b1e2792cd", "parents": [ "410f668c7a0460595c86b3e2a25e396b96181ccf" ], "author": { "name": "David Dorwin", "email": "ddorwin@google.com", "time": "Fri Aug 29 13:39:00 2025 -0700" }, "committer": { "name": "David Dorwin", "email": "ddorwin@google.com", "time": "Fri Aug 29 14:21:06 2025 -0700" }, "message": "[sdk][build] Only reference header files once in build rule\n\nUse `public` directly rather than setting its value to `sources`. This\nis correct and avoids an error about a file being defined by multiple\natoms (though it is just this one) during IDK generation when building\n//sdk/firmware.\n\nChange-Id: I0e5722952f6c8a98e714d1fc3d61bb5df59bc25e\nReviewed-on: https://fuchsia-review.googlesource.com/c/third_party/vboot_reference/+/1357835\nReviewed-by: Yecheng Zhao \u003czyecheng@google.com\u003e\n" }, { "commit": "410f668c7a0460595c86b3e2a25e396b96181ccf", "tree": "2754ae0c868abb7010df4de1a844eb9b39acf00d", "parents": [ "2c156dcaf764331a05733ecde65bbdd158935db3" ], "author": { "name": "Darren Chan", "email": "chandarren@google.com", "time": "Fri Aug 29 01:54:15 2025 +0000" }, "committer": { "name": "Darren Chan", "email": "chandarren@google.com", "time": "Thu Aug 28 19:06:56 2025 -0700" }, "message": "[futility] Fix build target.\n\nThis fixes the `host_prebuilts-x64-linux` builder, which has been\nfailing for over 2 months due to a clang roll[1], which picked up [2],\nintroducing `-Wuninitialized-const-pointer`.\n\n[1]: https://fxrev.dev/1327414\n[2]: https://github.com/llvm/llvm-project/commit/00dacf8c22f065cb52efb14cd091d441f19b319e\n\nFixed: 441752797\nChange-Id: Id6564847cee992ae1afe29a39f64698d42c55773\nReviewed-on: https://fuchsia-review.googlesource.com/c/third_party/vboot_reference/+/1357324\nReviewed-by: Jiaming Li \u003clijiaming@google.com\u003e\nReviewed-by: Ina Huh \u003cihuh@google.com\u003e\n" }, { "commit": "2c156dcaf764331a05733ecde65bbdd158935db3", "tree": "30d9d952d4879fcb901cd87c2cb4a6020f8154a2", "parents": [ "68afa0f72b964c62d70f3b106590ae246d683c0f" ], "author": { "name": "David Dorwin", "email": "ddorwin@google.com", "time": "Wed Sep 25 17:55:21 2024 -0700" }, "committer": { "name": "David Dorwin", "email": "ddorwin@google.com", "time": "Thu Sep 26 15:36:26 2024 +0000" }, "message": "[sdk][build] Change SDK category to firmware_sdk\n\nThe \"experimental\" SDK category is deprecated.\n\nBug: 365996258, 331991540\nChange-Id: I8e2ef9462518a00abbd5cdf5abbb26e14197a890\nReviewed-on: https://fuchsia-review.googlesource.com/c/third_party/vboot_reference/+/1125373\nReviewed-by: David Pursell \u003cdpursell@google.com\u003e\n" }, { "commit": "68afa0f72b964c62d70f3b106590ae246d683c0f", "tree": "061f7036da3532099bfda2e17ee0d4ce508ea0bd", "parents": [ "36552f4770fa7d8d56ccacb739d8c5cbdf5961ad" ], "author": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Thu Jan 25 17:07:46 2024 -0800" }, "committer": { "name": "Mitchell Kember", "email": "mkember@google.com", "time": "Sat Jan 27 00:27:09 2024 +0000" }, "message": "[fxbug.dev] Migrate bug numbers\n\nThis changes fxbug.dev/ URLs from Monorail bug numbers to the new\nFuchsia Issue Tracker numbers.\n\nThe migration to the new issue tracker was announced here:\nhttps://groups.google.com/a/fuchsia.dev/g/announce/c/GOYfJozEqmk/m/qsGsaJ7UAAAJ\n\nBug: 298074672\nChange-Id: Ic81597ffa29ba1f17d1c6a4371a03119a8034c53\nReviewed-on: https://fuchsia-review.googlesource.com/c/third_party/vboot_reference/+/980663\nReviewed-by: Ian McKellar \u003cianloic@google.com\u003e\n" }, { "commit": "36552f4770fa7d8d56ccacb739d8c5cbdf5961ad", "tree": "6904a2e66ab98533bb1c8ad5e1037499e1744d0e", "parents": [ "8a1eb07e07888a56be9a5aad3b1b8e2fd2127588" ], "author": { "name": "Petr Hosek", "email": "phosek@google.com", "time": "Mon Oct 23 23:18:22 2023 +0000" }, "committer": { "name": "Petr Hosek", "email": "phosek@google.com", "time": "Mon Oct 23 23:39:26 2023 +0000" }, "message": "[build] Supress -Wbitfield-conversion\n\nThis warning was introduced by Clang and is being triggered by the\ngpt implementation, suppress it since we generally avoid modifying\nthird party code.\n\nBug: 135166\nChange-Id: I61045c5bba2fa41f248b7e371800c49b6edf7744\nReviewed-on: https://fuchsia-review.googlesource.com/c/third_party/vboot_reference/+/936042\nReviewed-by: Leonard Chan \u003cleonardchan@google.com\u003e\n" }, { "commit": "8a1eb07e07888a56be9a5aad3b1b8e2fd2127588", "tree": "243e88b5063223e967fe81802fd75709a67f6aec", "parents": [ "63c37cd4a5e35f250483a3a68637eac7f27be38e" ], "author": { "name": "Dov Shlachter", "email": "dovs@google.com", "time": "Tue May 02 13:23:04 2023 -0700" }, "committer": { "name": "Dov Shlachter", "email": "dovs@google.com", "time": "Tue May 02 21:15:49 2023 +0000" }, "message": "[sdk] Changes to libsparse to build using uefi toolchain.\n\nAdd missing includes and tweak dependencies to libsparse targets when\nbuilding using the kernel.efi toolchain.\n\nChange-Id: Idfcc773984f6cb5b87d0ace1ec5a42562e076d00\nReviewed-on: https://fuchsia-review.googlesource.com/c/third_party/vboot_reference/+/851176\nReviewed-by: Yecheng Zhao \u003czyecheng@google.com\u003e\n" }, { "commit": "63c37cd4a5e35f250483a3a68637eac7f27be38e", "tree": "0a7a336aae028eb8696c76334736812252399dc1", "parents": [ "b2bc52ea822836d4ebeca26a22c192ed7def8185" ], "author": { "name": "Yecheng Zhao", "email": "zyecheng@google.com", "time": "Tue Apr 18 16:11:57 2023 -0700" }, "committer": { "name": "Yecheng Zhao", "email": "zyecheng@google.com", "time": "Tue Apr 25 19:52:31 2023 +0000" }, "message": "[sdk] Fix include_base\n\nFixes include_base for cgptlib/include so that the include dir in\nmeta.json is consistent with actual include dir\n\nBug: b/269166466\nChange-Id: I5f22a2842a25a201d54a388f4c610fa413688c13\nReviewed-on: https://fuchsia-review.googlesource.com/c/third_party/vboot_reference/+/839378\nReviewed-by: David Pursell \u003cdpursell@google.com\u003e\n" }, { "commit": "b2bc52ea822836d4ebeca26a22c192ed7def8185", "tree": "0e0634d554b228f1a5b30465b20e07ab73479363", "parents": [ "98e1f847b11ab5b5b307514095f942ae8592862e" ], "author": { "name": "Yecheng Zhao", "email": "zyecheng@google.com", "time": "Fri Jan 06 13:44:27 2023 -0800" }, "committer": { "name": "Yecheng Zhao", "email": "zyecheng@google.com", "time": "Sun Jan 08 22:53:33 2023 +0000" }, "message": "[build] Add GN build rules for GPT utils\n\nBug: b/262617680\nChange-Id: I7b8252a2d3ba46143fa71a92097fab27ad1f9b05\nReviewed-on: https://fuchsia-review.googlesource.com/c/third_party/vboot_reference/+/787152\nReviewed-by: David Pursell \u003cdpursell@google.com\u003e\n" }, { "commit": "98e1f847b11ab5b5b307514095f942ae8592862e", "tree": "ec4a1b2483d24727657f986075433efe389edb44", "parents": [ "57dd611f3cc47cc702627e912f4bb80d1c95d372" ], "author": { "name": "Leonard Chan", "email": "leonardchan@google.com", "time": "Thu Oct 03 17:25:33 2019 -0700" }, "committer": { "name": "Leonard Chan", "email": "leonardchan@google.com", "time": "Thu Oct 03 17:40:19 2019 -0700" }, "message": "Make vboot_version extern in header\n\nWhen enabling `-fno-common` in Fuchsia, we get a bunch of linker errors\nwhen linking futility:\n\n```\nld.lld: error: duplicate symbol: vboot_version\n\u003e\u003e\u003e defined at futility.h:43 (../../third_party/vboot_reference/futility/futility.h:43)\n\u003e\u003e\u003e host_x63-asan_no_detect_leaks/obj/third_party/vboot_reference/futility/futility.cmd_bdb.c.o:(vboot_version)\n\u003e\u003e\u003e defined at futility.h:43 (../../third_party/vboot_reference/futility/futility.h:43)\n\u003e\u003e\u003e host_x64-asan_no_detect_leaks/obj/third_party/vboot_reference/futility/futility.cmd_create.c.o:(.bss.vboot_version+0x0)\n```\n\nand think this is because -fno-common places vboot_version for\nunitialized global variables in the BSS section of each object file.\nMaking it extern instead resolves each reference to its definition in\nfutility/misc.c.\n\nChange-Id: Ibc0ea747918569d0c854e7d2ee838e7537442eee\n" }, { "commit": "57dd611f3cc47cc702627e912f4bb80d1c95d372", "tree": "145a9247502e3e2ca75b6399bfa5087cc8b7a278", "parents": [ "3b57e728d8f82b23f6ed574ed805c949f03f26a0" ], "author": { "name": "Petr Hosek", "email": "phosek@google.com", "time": "Tue May 15 20:58:09 2018 -0700" }, "committer": { "name": "Petr Hosek", "email": "phosek@google.com", "time": "Tue May 15 20:58:09 2018 -0700" }, "message": "Update README.fuchsia\n\nChange-Id: I8637239be44d56cf7399fafab3fefb815b63024e\n" }, { "commit": "3b57e728d8f82b23f6ed574ed805c949f03f26a0", "tree": "224c941b4a81047b9f633908032a69f5ca022be4", "parents": [ "7a0ba932a8f6c4da71d4f9e73f3e1181fa297372" ], "author": { "name": "Damien Miller", "email": "djm@google.com", "time": "Wed Apr 04 17:35:25 2018 +1000" }, "committer": { "name": "Damien Miller", "email": "djm@google.com", "time": "Wed Apr 04 17:59:08 2018 +1000" }, "message": "Update README.fuchsia\n\nChange-Id: Ifa688fe5b9eb1d131027ed57cdbf387d672c1765\n" }, { "commit": "7a0ba932a8f6c4da71d4f9e73f3e1181fa297372", "tree": "a28fa8e1af42010cca2ad4c1b87040a0b79937bd", "parents": [ "0b235d5b2c31cdb3fc5ef32c58fec37746a5f125" ], "author": { "name": "Damien Miller", "email": "djm@google.com", "time": "Sun Mar 04 22:46:01 2018 -0500" }, "committer": { "name": "Damien Miller", "email": "djm@google.com", "time": "Sun Mar 04 22:50:32 2018 -0500" }, "message": "Link to upstream in README.fuchsia\n\nUpstream obtained from existing git remote\n\nSEC-17\n\nChange-Id: Ie99446fe04ce34f3adcd879cda5b89601bd7238d\n" }, { "commit": "0b235d5b2c31cdb3fc5ef32c58fec37746a5f125", "tree": "18c22f822677d808f729db68247e2d0c4d8eafdc", "parents": [ "b55892807edb2aea87e9cbc7c5bdaaffd4fdbb15" ], "author": { "name": "James Tucker", "email": "raggi@google.com", "time": "Tue Dec 05 13:19:58 2017 -0800" }, "committer": { "name": "James Tucker", "email": "raggi@google.com", "time": "Tue Dec 05 13:20:42 2017 -0800" }, "message": "darwin: read disk block sizes and counts\n\nFixes cgpt add, create, etc.\n\nChange-Id: I3017c2d3f3fccfdd4d761cf8c3631db8a350fee2\n" }, { "commit": "b55892807edb2aea87e9cbc7c5bdaaffd4fdbb15", "tree": "e2a873a722107ee118b2ebaf0e87c35912abef27", "parents": [ "b209f29093cfd026b861dc529e3415fe78984751" ], "author": { "name": "James Tucker", "email": "raggi@google.com", "time": "Sat Dec 02 00:07:30 2017 -0800" }, "committer": { "name": "James Tucker", "email": "raggi@google.com", "time": "Sat Dec 02 00:07:59 2017 -0800" }, "message": "cgpt: supprt MACOS builds\n\nChange-Id: I910041443b8a0ca143de47df91c6268ee2d12132\n" }, { "commit": "b209f29093cfd026b861dc529e3415fe78984751", "tree": "f98b18e8914db9ede9f9ac63ad77cfe86b2de603", "parents": [ "bf4925a458ca7e3e17cd53de018296517ecfe0e9" ], "author": { "name": "James Tucker", "email": "jftucker@gmail.com", "time": "Tue Nov 28 13:39:16 2017 -0800" }, "committer": { "name": "James Tucker", "email": "jftucker@gmail.com", "time": "Tue Nov 28 13:39:16 2017 -0800" }, "message": "Fixes for linux builds\n" }, { "commit": "bf4925a458ca7e3e17cd53de018296517ecfe0e9", "tree": "1db61fc915c897532f387d029fc15d22ec146386", "parents": [ "5110389811e7b82b8a46d9cfed1a6010947cfe60" ], "author": { "name": "James Tucker", "email": "raggi@google.com", "time": "Tue Nov 28 13:18:59 2017 -0800" }, "committer": { "name": "James Tucker", "email": "raggi@google.com", "time": "Tue Nov 28 13:18:59 2017 -0800" }, "message": "Fix non-mac builds\n" }, { "commit": "5110389811e7b82b8a46d9cfed1a6010947cfe60", "tree": "811ff8fa7cd38c335d34e61122109287a010945c", "parents": [ "7592bf2092698c5e115eb299e1e0f95f7d9baf85" ], "author": { "name": "James Tucker", "email": "raggi@google.com", "time": "Tue Nov 28 12:05:43 2017 -0800" }, "committer": { "name": "James Tucker", "email": "raggi@google.com", "time": "Tue Nov 28 12:05:43 2017 -0800" }, "message": "Add script for building futility on infra\n" }, { "commit": "7592bf2092698c5e115eb299e1e0f95f7d9baf85", "tree": "c93d94f594f21a389c2d00135b294cb1bdc85bb8", "parents": [ "796b0840d24ae0c11d1b4fd1afc88d60bcb68181" ], "author": { "name": "James Tucker", "email": "raggi@google.com", "time": "Tue Nov 28 12:05:27 2017 -0800" }, "committer": { "name": "James Tucker", "email": "raggi@google.com", "time": "Tue Nov 28 12:05:27 2017 -0800" }, "message": "Add support for building against boringssl\n" }, { "commit": "796b0840d24ae0c11d1b4fd1afc88d60bcb68181", "tree": "d5e23e9486f3a86826fa295142edee5aa7ed6e76", "parents": [ "57f4f70c818b3b86f906de1ddec9c2a89b06ee4b" ], "author": { "name": "James Tucker", "email": "raggi@google.com", "time": "Tue Nov 28 11:40:10 2017 -0800" }, "committer": { "name": "James Tucker", "email": "raggi@google.com", "time": "Tue Nov 28 11:40:10 2017 -0800" }, "message": "Allow separate OpenSSL include/lib dirs\n" }, { "commit": "57f4f70c818b3b86f906de1ddec9c2a89b06ee4b", "tree": "ef83e81c63e34d4234dd9c3be636eecc1b77addf", "parents": [ "56166a65c7a9b3df07c5678156c101be99c3f367" ], "author": { "name": "James Tucker", "email": "raggi@google.com", "time": "Tue Nov 28 11:11:28 2017 -0800" }, "committer": { "name": "James Tucker", "email": "raggi@google.com", "time": "Tue Nov 28 11:11:28 2017 -0800" }, "message": "a config file is not required\n" }, { "commit": "56166a65c7a9b3df07c5678156c101be99c3f367", "tree": "af9d3de0e99de1f9d380c5d37177d7843eb94c1e", "parents": [ "085759742ead585a4be3e13119d954e08babe889" ], "author": { "name": "James Tucker", "email": "raggi@google.com", "time": "Mon Nov 27 16:45:43 2017 -0800" }, "committer": { "name": "James Tucker", "email": "raggi@google.com", "time": "Mon Nov 27 16:45:43 2017 -0800" }, "message": "Add support for darwin back to the build\n" }, { "commit": "085759742ead585a4be3e13119d954e08babe889", "tree": "96502df78125cf5e2aa885b9563243511c3a710d", "parents": [ "087a4c8d9cc947b74ccd8e61a77b240406118825" ], "author": { "name": "Shelley Chen", "email": "shchen@chromium.org", "time": "Wed Sep 20 15:58:13 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Thu Nov 23 04:39:15 2017 -0800" }, "message": "detachables: create menu items for legacy screens\n\nPreviously, we didn\u0027t require any action on these legacy screens, so\ndidn\u0027t update current_screen when displaying these. Now, will be\nadding language switching and debug display for these screens, so need\nto keep track of them.\n\nBUG\u003db:65470853, b:67371896, b:64400036\nBRANCH\u003dNone\nTEST\u003dNone\n\nChange-Id: I2bab22fcbb0bb3cdfffe585eb633231ba8015fc3\nSigned-off-by: Shelley Chen \u003cshchen@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/676269\nCommit-Ready: ChromeOS CL Exonerator Bot \u003cchromiumos-cl-exonerator@appspot.gserviceaccount.com\u003e\nReviewed-by: Randall Spangler \u003crspangler@chromium.org\u003e\n" }, { "commit": "087a4c8d9cc947b74ccd8e61a77b240406118825", "tree": "8d397ece754a56ddfb89c0d969eff4eee72eec3f", "parents": [ "17fb34b647a73bb55fac876a9b20c2c90844ea2e" ], "author": { "name": "Stefan Reinauer", "email": "reinauer@google.com", "time": "Sat Nov 18 15:54:24 2017 -0800" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Mon Nov 20 18:13:45 2017 -0800" }, "message": "Fix vboot compilation with coreboot-sdk\n\nBUG\u003dnone\nBRANCH\u003dnone\nTEST\u003dUpstream builder does not fail with uninitialized variable anymore like this:\n firmware/lib/vboot_ui_menu.c: In function \u0027vb2_get_current_menu_size\u0027:\n firmware/lib/vboot_ui_menu.c:255:15: error: \u0027temp_menu\u0027 may be used uninitialized in this function [-Werror\u003dmaybe-uninitialized]\n *menu_array \u003d temp_menu;\n ~~~~~~~~~~~~^~~~~~~~~~~\n cc1: all warnings being treated as errors\n\nSigned-off-by: Stefan Reinauer \u003creinauer@chromium.org\u003e\n\nChange-Id: Idb1690c7b0becf3556cad379160fe152707ae843\nReviewed-on: https://chromium-review.googlesource.com/777805\nCommit-Ready: Stefan Reinauer \u003creinauer@google.com\u003e\nTested-by: Stefan Reinauer \u003creinauer@google.com\u003e\nReviewed-by: Martin Roth \u003cmartinroth@chromium.org\u003e\nReviewed-by: Shelley Chen \u003cshchen@chromium.org\u003e\n" }, { "commit": "17fb34b647a73bb55fac876a9b20c2c90844ea2e", "tree": "a574ae9d7cfd9c680b19a7b79932e54c5af6c45f", "parents": [ "4aaaeca130a701a06cb898d9a17eddf67daa3617" ], "author": { "name": "Randall Spangler", "email": "rspangler@chromium.org", "time": "Mon Oct 30 15:28:53 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Nov 17 20:18:20 2017 -0800" }, "message": "vboot: Use kernel max rollforward NV storage field\n\nKernel verification will now roll forward the minimum allowable\nversion in the TPM no farther than the kernel_max_rollforward setting.\n\nNote that CL:765573 changes chromeos-setgoodkernel so it always sets\nkernel_max_rollforward to 0xfffffffe when marking a kernel as good.\nThat ensures that firmware with this setting will behave the same for\nnow as existing firmware.\n\nBUG\u003dchromium:783997\nBRANCH\u003dnone\nCQ-DEPEND\u003dCL:765573\nTEST\u003dmake runtests\n Manual testing:\n crossystem tpm_kernvel --\u003e print current kernel version in TPM\n - Resign the kernel with a higher version\n - Reboot\n - Wait a minute for chromeos-setgoodkernel to run\n crossystem kernel_max_rollforward\u003d0\n - Reboot\n crossystem tpm_kernvel --\u003e has not changed\n - Wait a minute for chromeos-setgoodkernel to run\n crossystem kernel_max_rollforward -\u003e 0xfffffffe\n - Reboot\n crossystem tpm_kernvel --\u003e has changed to the higher version\n\nChange-Id: Ia32ecb7fa4078548cd311541ccbe120570cf1bc5\nReviewed-on: https://chromium-review.googlesource.com/765574\nCommit-Ready: Randall Spangler \u003crspangler@chromium.org\u003e\nTested-by: Randall Spangler \u003crspangler@chromium.org\u003e\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\nReviewed-by: Stefan Reinauer \u003creinauer@google.com\u003e\n" }, { "commit": "4aaaeca130a701a06cb898d9a17eddf67daa3617", "tree": "1f656152480b06b1c62589282249058d58702f88", "parents": [ "6014de9844835472b821d8ca61909a0ed6930dfe" ], "author": { "name": "Randall Spangler", "email": "rspangler@chromium.org", "time": "Fri Oct 20 12:38:40 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Nov 17 20:18:19 2017 -0800" }, "message": "nvstorage: Add kernel max rollforward NV storage field\n\nThis just adds the kernel_max_rollforward field to the nvstorage\nlibraries and crossystem. The firmware does not use it yet; that\u0027s\ncoming in a subsequent CL.\n\n16 of the fields\u0027s 32 bits are taken from unused bytes of the kernel\nfield. This has no effect on existing usage.\n\nBUG\u003dchromium:783997\nBRANCH\u003dnone\nTEST\u003dmake runtests\n Also manual testing. In a root shell:\n \tcrossystem kernel_max_rollforward --\u003e Should default to 0\n\n\tcrossystem kernel_max_rollforward\u003d0xfffffffe\n\tcrossystem kernel_max_rollforward --\u003e Should be 0xfffffffe\n\n (Note that setting it to 0xffffffff is indistinguishable from the\n -1 value that the crossystem library uses to indicate error, so\n 0xffffffff isn\u0027t actually usable as a max rollforward limit. But\n 0xfffffffe is, and if we ever get so close to the limit that we\n need to use 0xffffffff, something has already gone horribly wrong\n with our versioning strategy...)\n\nChange-Id: I008f412e6ed3c0b59beb9881268585af69d1ff2e\nSigned-off-by: Randall Spangler \u003crspangler@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/765572\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "6014de9844835472b821d8ca61909a0ed6930dfe", "tree": "e74630b7d0cb0ed8e5a76397ad966dd7f6091bad", "parents": [ "7850034a6dc8bd33413c0bedac654cbaa4e363c3" ], "author": { "name": "Shelley Chen", "email": "shchen@chromium.org", "time": "Mon Nov 13 09:35:26 2017 -0800" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Thu Nov 16 08:28:12 2017 -0800" }, "message": "detachables: Use Volup+Voldown to exit recovery graphic\n\nPreviously, we were able to exit the initial recovery graphic with\neither the volume up or volume down button. However, we would only\nlike the user to exit the screen when they know what they are doing,\nwe are making it so that they can only intentionally exit (with volup\n+ voldown simultaneously pressed).\n\nBUG\u003db:67371896\nBRANCH\u003dNone\nTEST\u003dreboot into recovery and press volume up + volume down keys.\n Make sure we exit to the recovery menu screen.\n\nChange-Id: I7dfb4a0e42c8b88e9b075e886cea1adfe248246c\nSigned-off-by: Shelley Chen \u003cshchen@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/766847\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "7850034a6dc8bd33413c0bedac654cbaa4e363c3", "tree": "82d407dfee9a61093c6064eebd83b03864a55da1", "parents": [ "0f0d7bdef662b19cba5501873b7ad076db752262" ], "author": { "name": "Shelley Chen", "email": "shchen@chromium.org", "time": "Mon Nov 06 15:59:50 2017 -0800" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Thu Nov 16 08:28:12 2017 -0800" }, "message": "detachables: Implement disable dev mode for enterprise\n\nWhen develper mode is disabled (through FWMP), don\u0027t allow user to see\nthe dev warning screen. Boot straight to TO_NORM and disable the\ncancel option. Basically, the user will only be able to enable OS\nverification, power off, or change the language. There is also no 30\nsecond timeout during bootup.\n\nBUG\u003db:65595945\nBRANCH\u003dNone\nTEST\u003dForce disable_dev_boot flag to 1 and ensure the TO_NORM menu is\n displayed w/o a cancel option. Scroll through options to make\n sure they work as expected. Make sure debug message is displayed\n indicating dev mode is disabled. Wait \u003e 30 secs to ensure\n timeout doesn\u0027t occur.\n\nChange-Id: I7d2bcd369694e886866f9dedff05d81a40f8270a\nSigned-off-by: Shelley Chen \u003cshchen@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/757115\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "0f0d7bdef662b19cba5501873b7ad076db752262", "tree": "73b527c569d97e04ddbea6276f7fd17d9b140a64", "parents": [ "4fbe948c5127b8468b5a507431547face6c74e15" ], "author": { "name": "Daisuke Nojiri", "email": "dnojiri@chromium.org", "time": "Mon Nov 13 15:23:46 2017 -0800" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Tue Nov 14 16:03:22 2017 -0800" }, "message": "EC-EFS: Fix in-place signature replacement\n\nWhen futility replaces the old signature in the input file with a\nnew one, it assumes the signature is at the end of RW region. This\nassumption is wrong for EC-EFS binaries because they place a\nsignature at each end of two EC_RW areas.\n\nThis patch fixes the issue by specifying the signature address via\n\u0027old_sig\u0027, which points to the (first) signature address regardless\nof the input file format (EFS v.s. non-EFS, FMAP v.s. no FMAP).\n\nBUG\u003db:66956286\nBRANCH\u003dnone\nTEST\u003dRun\n\u0027futility sign --type rwsig --prikey key_ec_efs.vbprik2 ec.bin\u0027.\nThen run \u0027futility show --type rwsig ec.bin\u0027, which prints\n\u0027Signature verification succeeded.\u0027\nmake runtests\n\nChange-Id: I730fd31be640de3e9381f156d084162dd4093ba6\nSigned-off-by: Daisuke Nojiri \u003cdnojiri@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/767596\n" }, { "commit": "4fbe948c5127b8468b5a507431547face6c74e15", "tree": "decef90bb29a77431488111fd761e9b34540f0f6", "parents": [ "ff82ffb0a9cd28bc186eef2e86cfc61aec2d6029" ], "author": { "name": "Furquan Shaikh", "email": "furquan@chromium.org", "time": "Mon Nov 13 12:59:46 2017 -0800" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Tue Nov 14 10:11:19 2017 -0800" }, "message": "vboot_ui_menu: Use volume down short press at recovery menu screen\n\nFix the typo made in\nhttps://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/757123\nfor usage of volume down button at recovery menu screen. It should be\nshort press instead of long press.\n\nBUG\u003db:64992445,b:65013794\nBRANCH\u003dNone\nTEST\u003dVerified that volume down short press works as expected on\nrecovery menu.\n\nChange-Id: Ia9a172439ac3bbd1ea395778e83a95c988816e01\nSigned-off-by: Furquan Shaikh \u003cfurquan@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/767059\nReviewed-by: Shelley Chen \u003cshchen@chromium.org\u003e\n" }, { "commit": "ff82ffb0a9cd28bc186eef2e86cfc61aec2d6029", "tree": "7b3968a64914817186df868a3caf2bb174c24c08", "parents": [ "db79418605d6c128a03af99156467963c01c05d8" ], "author": { "name": "Randall Spangler", "email": "rspangler@chromium.org", "time": "Mon Oct 30 15:43:17 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Sun Nov 12 10:49:49 2017 -0800" }, "message": "vboot: use VBNV_ constants with VbNvGet()\n\nThe vboot1 library VbNvGet() / VbNvSet() functions use enum VbNvParam\n(VBNV_*) constants.\n\nThe vboot2 library vb2_nv_get() / vb2_nv_set() functions use enum\nvb2_nv_param constants.\n\nDo not mix the two. In the one instance where this happens in the\ncurrent code, we get lucky, because VBNV_DEV_BOOT_FASTBOOT_FULL_CAP\nand VB2_NV_DEV_BOOT_FASTBOOT_FULL_CAP evaluate to the same value, so\nthis was harmless. But fix that now so nobody else copy/pastes that\npattern for a param where this isn\u0027t true.\n\nBUG\u003dnone\nBRANCH\u003dnone\nTEST\u003dmake runtests\n\nChange-Id: I1facbe1d97591dc8b1e6b38717924b884949da57\nSigned-off-by: Randall Spangler \u003crspangler@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/764970\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "db79418605d6c128a03af99156467963c01c05d8", "tree": "ee115ecd9482d9c25fa56f144de1b4d2c7d55466", "parents": [ "5049bd3ed69392b94864be410623868c8627016d" ], "author": { "name": "Furquan Shaikh", "email": "furquan@chromium.org", "time": "Tue Nov 07 12:49:17 2017 -0800" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Thu Nov 09 21:45:56 2017 -0800" }, "message": "buttons: Update button codes for vup, vdn and power\n\n1. Differentiate button codes for short press and long press of volume\nup and volume down.\n2. Add a new code for volume up-down combo press since it is expected\nto be used for one of the firmware screens.\n3. Treat volume down long press as Ctrl-D on developer screen.\n4. Treat volume up long press as Ctrl-U on developer screen.\n\nCQ-DEPEND\u003dCL:756254\nBUG\u003db:64992445,b:65013794\nBRANCH\u003dNone\nTEST\u003dVerified that buttons work as expected on Soraka.\n\nChange-Id: I5d443f43f785b973f3ff4aeaac52b152ed2fe0bd\nSigned-off-by: Furquan Shaikh \u003cfurquan@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/757123\nReviewed-by: Aaron Durbin \u003cadurbin@chromium.org\u003e\n" }, { "commit": "5049bd3ed69392b94864be410623868c8627016d", "tree": "323b0e0062c49a4d2be5ef2e155978d3ec9b1843", "parents": [ "e5e03c6d50fd4c4a0cd95b68eeb52f0c8e98bfc6" ], "author": { "name": "Daisuke Nojiri", "email": "dnojiri@chromium.org", "time": "Mon Oct 23 11:36:12 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Thu Nov 02 00:12:56 2017 -0700" }, "message": "Resign ec.bin and store EC-RW in bios.bin\n\nThis patch makes sign_official_build.sh resign ec.bin and store\nsigned RW copies in bios.bin if the original ec.bin contains\nsigned RW copies.\n\nBUG\u003db:66956286\nBRANCH\u003dnone\nCQ-DEPEND\u003dCL:738794,CL:*490792\nTEST\u003dsign_official_build.sh recovery recovery_image.bin \\\n~/trunk/src/platform/vboot_reference/tests/devkeys /tmp/out.bin\n\nChange-Id: I73c7d8da7d8e2f770e5952d0124f8d43bb13e592\nSigned-off-by: Daisuke Nojiri \u003cdnojiri@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/734295\n" }, { "commit": "e5e03c6d50fd4c4a0cd95b68eeb52f0c8e98bfc6", "tree": "5ae16e2b9ef4b576962ae56f3951647a36eacf5b", "parents": [ "8a6456084df1aaa3e0f8f67db66459ec08b1b6bc" ], "author": { "name": "Daisuke Nojiri", "email": "dnojiri@chromium.org", "time": "Fri Oct 27 11:23:44 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Mon Oct 30 23:21:32 2017 -0700" }, "message": "Call VbExEcRunningRW to set IN_RW flag\n\nCL:693008 changed check_ac_active so that we ask CR50 to verify EC\nis in RO. While this is the right decision, on some platforms ECs\ncan\u0027t reset EC_IN_RW. This causes check_ec_active to set IN_RW\nwrongly when EC is in RO after reboot.\n\nThis patch replaces VbExTrustEC with VbExEcRunningRW. If RW is\nowned it may say it\u0027s in RO. Then, the software sync will proceed\nand flash RW while the EC is running RW copy.\n\nIt also removes redundant checks for VbExTrustEC() when deciding\nwhether to allow developer mode to be enabled from the INSERT\nscreen. The INSERT screen can only be reached by manual recovery,\nwhich resets the EC, we don\u0027t need to check again before going to\nTODEV.\n\nBUG\u003db:67976359\nBRANCH\u003dnone\nTEST\u003dmake runtests\n\nChange-Id: Ide722146ca8683411dd9072a39387aa9531f6cfc\nSigned-off-by: Daisuke Nojiri \u003cdnojiri@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/740878\n" }, { "commit": "8a6456084df1aaa3e0f8f67db66459ec08b1b6bc", "tree": "b5b7c305984524055aa8992a981ba5e293898b2c", "parents": [ "2aa3dd0f6dfbe68474b2db3dec8c53a7ad66fb6d" ], "author": { "name": "Daisuke Nojiri", "email": "dnojiri@chromium.org", "time": "Fri Oct 20 17:01:21 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Oct 27 16:14:08 2017 -0700" }, "message": "EFS: Add key generator for EC EFS\n\nThis patch adds a script which generates a key pair for signing\n\u0026 verifying EC-RW copies.\n\nBUG\u003db:66956286\nBRANCH\u003dnone\nTEST\u003dVerify the script generates indented key pair\n\nChange-Id: Ia5aff7130587d4f1e18bcdfa514a953caa0cf183\nSigned-off-by: Daisuke Nojiri \u003cdnojiri@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/731824\nReviewed-by: C Shapiro \u003cshapiroc@google.com\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "2aa3dd0f6dfbe68474b2db3dec8c53a7ad66fb6d", "tree": "92881b1dfff1c84b965a4e29541691bef7c18343", "parents": [ "befe2e8f2a9ca3144bccebbf4bf4c930d8dc27c1" ], "author": { "name": "Shelley Chen", "email": "shchen@chromium.org", "time": "Fri Oct 20 13:00:27 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Thu Oct 26 00:19:48 2017 -0700" }, "message": "detachables: Remove screen blanking\n\nThis is not necessary anymore and rendering is taken\ncare of in depthcharge.\n\nBUG\u003db:35585623\nBRANCH\u003dNone\nTEST\u003dreboot and scroll through menus and make sure that\n rendering is still good.\n\nChange-Id: I078751014c8f84fb2ee403b6895e9dfa58e758d6\nSigned-off-by: Shelley Chen \u003cshchen@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/731114\nReviewed-by: Randall Spangler \u003crspangler@chromium.org\u003e\n" }, { "commit": "befe2e8f2a9ca3144bccebbf4bf4c930d8dc27c1", "tree": "3f09c29cc07d7e11e6e25b5a937e123a81a55846", "parents": [ "9ff61a3e814f28692336e45cc0158cb18b7444b8" ], "author": { "name": "Nicolas Boichat", "email": "drinkcat@google.com", "time": "Wed Oct 25 15:00:15 2017 +0800" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Wed Oct 25 05:52:43 2017 -0700" }, "message": "make_dev_ssd: Include full command path in error/help message\n\nLet\u0027s use the actual command/path used to call make_dev_ssd.sh,\ninstead of hard-coding \u0027./\u0027.\n\nBRANCH\u003dnone\nBUG\u003dnone\nTEST\u003d/usr/share/vboot/bin/make_dev_ssd.sh --remove_rootfs_verification\n outputs a command that can just be copy-pasted:\n sudo /usr/share/vboot/bin/make_dev_ssd.sh --remove_rootfs_verification --partitions 4\n (instead of:\n sudo ./make_dev_ssd.sh --remove_rootfs_verification --partitions 4\n )\n\nChange-Id: I903f94acc1fb310926b149c1e79e4017bf513e27\nReviewed-on: https://chromium-review.googlesource.com/737810\nCommit-Ready: Nicolas Boichat \u003cdrinkcat@chromium.org\u003e\nTested-by: Nicolas Boichat \u003cdrinkcat@chromium.org\u003e\nReviewed-by: Hung-Te Lin \u003chungte@chromium.org\u003e\n" }, { "commit": "9ff61a3e814f28692336e45cc0158cb18b7444b8", "tree": "54b534ef999cdafc84c21164d3899bba27eee6ed", "parents": [ "8122e0b8b13794ffcda7a0a0930b2bc6969e8364" ], "author": { "name": "C Shapiro", "email": "shapiroc@chromium.org", "time": "Mon Oct 23 12:01:29 2017 -0600" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Tue Oct 24 10:38:24 2017 -0700" }, "message": "vboot_reference: Decouple from model\n\nThe signer has no concept of model and doesn\u0027t need to. From its\nperspective, it is simply generating a signature block based on a set of\ninstructions.\n\nChanging the comments and variable name to reflect this.\n\nBUG\u003db:68141451\nTEST\u003dNone\nBRANCH\u003dNone\n\nChange-Id: Ia2a3e4a5273a4bcd9c5645db2cf0db80af6c28cf\nReviewed-on: https://chromium-review.googlesource.com/733857\nCommit-Ready: C Shapiro \u003cshapiroc@google.com\u003e\nTested-by: C Shapiro \u003cshapiroc@google.com\u003e\nReviewed-by: Simon Glass \u003csjg@chromium.org\u003e\nReviewed-by: Aaron Durbin \u003cadurbin@chromium.org\u003e\nReviewed-by: Jason Clinton \u003cjclinton@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "8122e0b8b13794ffcda7a0a0930b2bc6969e8364", "tree": "c1a571c51396cc755525e8d73831d54ec05a6074", "parents": [ "0329f9c2ec6a1ab951ad06d12e7706d63f6f0d8f" ], "author": { "name": "Shelley Chen", "email": "shchen@chromium.org", "time": "Fri Oct 20 10:28:29 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Oct 20 17:59:29 2017 -0700" }, "message": "detachables: Print error if enable normal mode when FORCE_DEV on\n\nPrint a debug error and beep when user tries to enable normal mode\nwhen FORCE_DEV gbb flag is enabled.\n\nBUG\u003db:67828898\nBRANCH\u003dNone\nTEST\u003dBoot up with gbb flag 0x8 enabled. Select \"Enabled OS\n Verification\" and select confirm. Should see error message\n printed and a beep. Confirm switching to normal mode\n screen will not appear.\n\nChange-Id: Ic02558eb4a86555cebc9c1cd6972d0f0600b4ff1\nSigned-off-by: Shelley Chen \u003cshchen@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/730415\nReviewed-by: Randall Spangler \u003crspangler@chromium.org\u003e\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "0329f9c2ec6a1ab951ad06d12e7706d63f6f0d8f", "tree": "71ef8f85b94604d57511df31c7e4adf13f21de56", "parents": [ "3b805725c15022783f0737a72b4f27962abf48cd" ], "author": { "name": "Shelley Chen", "email": "shchen@chromium.org", "time": "Mon Oct 09 11:04:30 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Wed Oct 18 06:15:06 2017 -0700" }, "message": "vboot_ui_menu: Checking vb2_update_menu return value\n\nIf return value is not VBERROR_SUCCESS, return\nwith an error.\n\nBUG\u003dNone\nBRANCH\u003dNone\nTEST\u003dNone\n\nChange-Id: I1402277567b901701cdd68d74968e43e838c89da\nSigned-off-by: Shelley Chen \u003cshchen@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/707496\nReviewed-by: Randall Spangler \u003crspangler@chromium.org\u003e\n" }, { "commit": "3b805725c15022783f0737a72b4f27962abf48cd", "tree": "901659ef5fe07f9799b298f66871ef49301a782b", "parents": [ "5d5b2f16109662dceb55dfbe62772ee41887be82" ], "author": { "name": "Andrey Pronin", "email": "apronin@chromium.org", "time": "Fri Oct 06 20:01:53 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Thu Oct 12 16:35:30 2017 -0700" }, "message": "tlcl, tpmc: extend GetVersion to report vendor specific data\n\n1) Extend TlclGetVersion to return vendor specific data, if\n requested.\n2) Extend \u0027tpmc getver\u0027 to include vendor specific data.\n\nBRANCH\u003dnone\nBUG\u003dchromium:771561\nTEST\u003dunit tests, running \u0027tpmc getver\u0027\n\nChange-Id: Ic04c242d4e6f33b45a80479be9ab9777b317ebe2\nReviewed-on: https://chromium-review.googlesource.com/706240\nCommit-Ready: Andrey Pronin \u003capronin@chromium.org\u003e\nTested-by: Andrey Pronin \u003capronin@chromium.org\u003e\nReviewed-by: Andrey Pronin \u003capronin@chromium.org\u003e\n" }, { "commit": "5d5b2f16109662dceb55dfbe62772ee41887be82", "tree": "f119693c5c6f897454c312453ace68e80fedc761", "parents": [ "95554e4e62dc2ae8333a6487f973f830753de071" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Mon Oct 09 22:41:05 2017 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Tue Oct 10 05:31:03 2017 -0700" }, "message": "futility_s: add vbutil_firmware \u0026 vbutil_key\n\nThe firmware updater relies on these, so include them.\n\nBUG\u003dchromium:772862\nTEST\u003dbuild works and futility_s includes new commands\nBRANCH\u003dNone\n\nChange-Id: I973e339d11df4d5b72f70d3a9e28916cca4ebbf6\nReviewed-on: https://chromium-review.googlesource.com/708236\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Furquan Shaikh \u003cfurquan@chromium.org\u003e\n" }, { "commit": "95554e4e62dc2ae8333a6487f973f830753de071", "tree": "37e80b101da6553108bb641e147b91bcf8e0a489", "parents": [ "e95ceff307f6c5c457f3e805991804ae2c7cb50c" ], "author": { "name": "Daisuke Nojiri", "email": "dnojiri@chromium.org", "time": "Thu Sep 28 15:53:21 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Thu Oct 05 21:24:44 2017 -0700" }, "message": "Check EC_IN_RW before proceeding to recovery mode\n\nDepthcharge currently asks EC whether recovery was requested manually\nor not without verifying EC is in RO or not. If EC-RW is compromised,\nrecovery switch state can be spoofed.\n\nThis patch makes Depthcharge check EC_IN_RW to determine whether EC\nis in RO or not. Only if it\u0027s in RO and it says recovery button was\npressed at boot, we proceed to the recovery process.\n\nAll other recovery requests including manual recovery requested by a\n(compromised) host will end up with \u0027broken\u0027 screen.\n\nBUG\u003db:66516882\nBRANCH\u003dnone\nTEST\u003dBoot Fizz. make runtests.\n\nChange-Id: I01d2df05fe22e79bbc949f5cb83db605147667b3\nSigned-off-by: Daisuke Nojiri \u003cdnojiri@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/693008\nReviewed-by: Randall Spangler \u003crspangler@chromium.org\u003e\n" }, { "commit": "e95ceff307f6c5c457f3e805991804ae2c7cb50c", "tree": "c9ac67df0a7ff60002851d9447da24fcc212b41a", "parents": [ "e0a9a13c82b3e9fbba21250be116de5b13d2a974" ], "author": { "name": "Divya Chellap", "email": "divya.chellappa@intel.com", "time": "Wed Sep 20 12:10:26 2017 +0530" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Thu Oct 05 03:04:15 2017 -0700" }, "message": "vboot: Handle power button press in broken screen\n\npower button press is not being handled in broken screen\n(VB_SCREEN_OS_BROKEN) if the user wants to exit out of it.\n\nBUG\u003dnone\nBRANCH\u003dnone\nTEST\u003dverified power button key functionality in\nbroken screen in Soraka board\n\nChange-Id: I64cbb79479e3e0579aeec4e87894441acf26c9fa\nSigned-off-by: Divya Chellap \u003cdivya.chellappa@intel.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/674886\nCommit-Ready: Divya Chellappa \u003cdivya.chellappa@intel.com\u003e\nTested-by: Divya Chellappa \u003cdivya.chellappa@intel.com\u003e\nReviewed-by: Aaron Durbin \u003cadurbin@chromium.org\u003e\nReviewed-by: Subrata Banik \u003csubrata.banik@intel.com\u003e\n" }, { "commit": "e0a9a13c82b3e9fbba21250be116de5b13d2a974", "tree": "33e6079ee9c75ddded7e3f20a628cb4b9bb829ff", "parents": [ "fb3c262eb0b2eb5d963680660dbbc5b00c6982df" ], "author": { "name": "Marco Chen", "email": "marco.chen@chromium.org", "time": "Thu Sep 28 13:53:04 2017 +0800" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Tue Oct 03 08:16:14 2017 -0700" }, "message": "Add a script to generate a keypair for signing Staff RW firmware.\n\nStaff decided to leverage the key format of Hammer therefore this\nscript calls Hammer\u0027s one to generate a key pair and renames them to\nkey_staff*.\n\nBUG\u003db:66889892\nTEST\u003dRun this script in the chroot and verify the generated key pair.\nBRANCH\u003dNone\n\nChange-Id: I73162efaba47a8c08336805130ced0be25ab262a\nReviewed-on: https://chromium-review.googlesource.com/688522\nCommit-Ready: Marco Chen \u003cmarcochen@chromium.org\u003e\nTested-by: Marco Chen \u003cmarcochen@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "fb3c262eb0b2eb5d963680660dbbc5b00c6982df", "tree": "5204d5da0a71a2138d1e2ec25557b77b8548f46b", "parents": [ "60dd468de6576e254d08153f57168c887429d4fd" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Fri Sep 29 01:13:49 2017 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Sep 29 20:16:18 2017 -0700" }, "message": "keygeneration: keyset_version_check.sh: support loem keysets\n\nBUG\u003dNone\nTEST\u003dran against local devkeys\nBRANCH\u003dNone\n\nChange-Id: Ib1c88ae187f12aad4531e9c22da6cda2af1503e3\nReviewed-on: https://chromium-review.googlesource.com/691340\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: David Riley \u003cdavidriley@chromium.org\u003e\n" }, { "commit": "60dd468de6576e254d08153f57168c887429d4fd", "tree": "a6c092152d1cfc9ce56d5c552dd2d7fe2e5d417c", "parents": [ "d4af2cdb1b714429ed6ecd6ca92ed80d255981b8" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Fri Sep 29 00:37:45 2017 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Sep 29 20:16:17 2017 -0700" }, "message": "keygeneration: keyset_version_check.sh: fix indentation\n\nBUG\u003dNone\nTEST\u003dran against local devkeys\nBRANCH\u003dNone\n\nChange-Id: I76470e18ea2e66f6abb5a912c4055fc245cedc8a\nReviewed-on: https://chromium-review.googlesource.com/691339\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: David Riley \u003cdavidriley@chromium.org\u003e\n" }, { "commit": "d4af2cdb1b714429ed6ecd6ca92ed80d255981b8", "tree": "bb9317bae6f7fb9d493527c31423c307122ec4ca", "parents": [ "cf81b101a14c7f26bba5f9f3cdab9d2a4ccb0c53" ], "author": { "name": "Garfield Tan", "email": "xutan@google.com", "time": "Tue Sep 26 18:13:12 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Wed Sep 27 16:29:29 2017 -0700" }, "message": "Use globbing to fetch mac_permissions.xml.\n\nAndroid master puts that file at a different location, so use similar\nlogic to official signing script.\n\nTEST\u003d\"sign_android_image.sh passed locally for both caroline (NYC) \u0026\ncaroline-bertha (master).\"\nBUG\u003db:65610114\nBRANCH\u003dnone\n\nChange-Id: If33bfbcaa7e6cff95f26ff26a91735c87880f3db\nReviewed-on: https://chromium-review.googlesource.com/686046\nCommit-Ready: Garfield Tan \u003cxutan@chromium.org\u003e\nTested-by: Garfield Tan \u003cxutan@chromium.org\u003e\nReviewed-by: Victor Hsieh \u003cvictorhsieh@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "cf81b101a14c7f26bba5f9f3cdab9d2a4ccb0c53", "tree": "c0f1ab53ff0a1111c9b3194f658ab3b74becb86f", "parents": [ "8e8be427abc7c0391d2454f5f189b2a99882ad10" ], "author": { "name": "Daniel Kurtz", "email": "djkurtz@chromium.org", "time": "Tue Sep 26 19:28:28 2017 -0600" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Wed Sep 27 10:59:31 2017 -0700" }, "message": "crossystem: add support for AMD0030 gpiochip\n\nOn AMD Stoney Ridge systems, the pinctrl (gpiochip) driver label is\n\"AMD0030\".\n\nSigned-off-by: Daniel Kurtz \u003cdjkurtz@chromium.org\u003e\n\nBUG\u003db:65597554\nTEST\u003dw/ coreboot patches:\n https://review.coreboot.org/#/c/21684/\n https://review.coreboot.org/#/c/21614/\nTEST\u003dcrossystem wpsw_cur\n \u003d\u003e 0\nBRANCH\u003dNone\n\nChange-Id: Iab0a1a28dd3e42d55cf3b18503e2df0de7b8ad11\nReviewed-on: https://chromium-review.googlesource.com/685945\nCommit-Ready: Daniel Kurtz \u003cdjkurtz@chromium.org\u003e\nTested-by: Aaron Durbin \u003cadurbin@chromium.org\u003e\nReviewed-by: Aaron Durbin \u003cadurbin@chromium.org\u003e\n" }, { "commit": "8e8be427abc7c0391d2454f5f189b2a99882ad10", "tree": "5e0e9892f729140277e9114204c82c6325fd8210", "parents": [ "a2ccb41cbc875500fedc1cbe57a184e8461e31ad" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Sat Sep 23 05:36:44 2017 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Tue Sep 26 13:36:19 2017 -0700" }, "message": "image_signing: fix under quoting of channel\n\nIf the channel is missing or has whitespace, the test triggers\nerrors in the script because the test command has bad quoting.\n\nBUG\u003dNone\nTEST\u003dscript no longer fails on an empty lsb-release\nBRANCH\u003dNone\n\nChange-Id: Ic2e6ab91ca4ec10c298d122aee1f7f7236b52bf2\nReviewed-on: https://chromium-review.googlesource.com/680059\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: David Riley \u003cdavidriley@chromium.org\u003e\n" }, { "commit": "a2ccb41cbc875500fedc1cbe57a184e8461e31ad", "tree": "bd3784508961f7b97f5ee03d74afbf50ac1e90a8", "parents": [ "b613faf5cd4359db719e7349148a94af4c50e342" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Sat Sep 23 05:36:14 2017 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Tue Sep 26 13:36:17 2017 -0700" }, "message": "image_signing: allow input rootfs to be a directory\n\nThis allows for quick local testing by creating a dummy rootfs.\n\nBUG\u003dchromium:714598\nTEST\u003dsigning images still works\nBRANCH\u003dNone\n\nChange-Id: If252b119fd64686b46e9989d55bedbd1eec45700\nReviewed-on: https://chromium-review.googlesource.com/680039\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: David Riley \u003cdavidriley@chromium.org\u003e\n" }, { "commit": "b613faf5cd4359db719e7349148a94af4c50e342", "tree": "5683c61cebb84c92ba8b18a490be8b08b51b87b5", "parents": [ "6d301ca142846f54d55b75b1c77439ce2c25835e" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Sat Sep 23 05:35:08 2017 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Tue Sep 26 13:36:09 2017 -0700" }, "message": "image_signing: allow lsb-release to contain comments\n\nNothing needs this, just something I noticed while debugging.\n\nBUG\u003dNone\nTEST\u003d`ensure_sane_lsb-release.sh` no longer complains about comment lines\nBRANCH\u003dNone\n\nChange-Id: Ia39e6461db79a387cc59e5f88ec1216984bb4d28\nReviewed-on: https://chromium-review.googlesource.com/680058\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "6d301ca142846f54d55b75b1c77439ce2c25835e", "tree": "7c1e339b1dffe2251b731a95fe8b613752cfef71", "parents": [ "5337484629c87d0fa6a1fa0aa598f3cad5a19f37" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Sat Sep 23 05:27:44 2017 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Mon Sep 25 15:52:47 2017 -0700" }, "message": "image_signing: fix logging multiple args\n\nBUG\u003dNone\nTEST\u003densure_sane_lsb-release.sh errors now include the full string\nBRANCH\u003dNone\n\nChange-Id: I460ec5e2127a57e7576214fe8fde9e511f940755\nReviewed-on: https://chromium-review.googlesource.com/680038\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: David Riley \u003cdavidriley@chromium.org\u003e\n" }, { "commit": "5337484629c87d0fa6a1fa0aa598f3cad5a19f37", "tree": "26bdc824555f8f374eeaf2d640f6c0b0646f04d7", "parents": [ "6129365995a7918e6f5ebd91600a6d3d345e3d08" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Fri Sep 15 11:33:34 2017 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Sep 22 22:25:40 2017 -0700" }, "message": "crossystem: support standard --help flag\n\nBUG\u003dchromium:765499\nTEST\u003dunittests pass\nBRANCH\u003dNone\n\nChange-Id: I5c5118c44897d89e5116a9fce49bacbf16704dd8\nReviewed-on: https://chromium-review.googlesource.com/668658\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Aaron Durbin \u003cadurbin@chromium.org\u003e\n" }, { "commit": "6129365995a7918e6f5ebd91600a6d3d345e3d08", "tree": "3bbdf87eb3e00692bb9d3571a2f9463b297cf635", "parents": [ "2ca654f03ab3039d21e628388285e5e9670c601f" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Fri Sep 22 19:19:30 2017 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Sep 22 22:25:35 2017 -0700" }, "message": "image_signing: ignore blank lines in loem.ini files\n\nBUG\u003dchromium:381862\nTEST\u003drun against a loem.ini file with blank lines doesn\u0027t barf\nBRANCH\u003dNone\n\nChange-Id: Icf8f8a3ba518ca0f4e64e6eee9c694d47fa32362\nReviewed-on: https://chromium-review.googlesource.com/679754\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: C Shapiro \u003cshapiroc@google.com\u003e\n" }, { "commit": "2ca654f03ab3039d21e628388285e5e9670c601f", "tree": "e0e48a7dba6221c4b9565226e32501d6664d4652", "parents": [ "1a8b1c008e9cbb08282a17318a82d1df88807022" ], "author": { "name": "Shelley Chen", "email": "shchen@chromium.org", "time": "Thu Sep 14 14:12:21 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Sep 15 16:59:22 2017 -0700" }, "message": "detachables: fix setting selected_idx of DEV_WARNING menu\n\nSelecting cancel from DEV_MENU should not set the selected_idx\nto loc. It should be set to power off.\n\nBUG\u003db:35585623\nBRANCH\u003dNone\nTEST\u003dgo to DEV_MENU, hit cancel and make sure that power off is\n selected item\n\nChange-Id: I8cae397c7174b5bd52a3a27736cd3d5a57412e63\nSigned-off-by: Shelley Chen \u003cshchen@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/667933\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "1a8b1c008e9cbb08282a17318a82d1df88807022", "tree": "3849393fd2e4c7f5694d86409099f3356045869b", "parents": [ "1282081609321888f485318cc7d06ee047feb31e" ], "author": { "name": "Shelley Chen", "email": "shchen@chromium.org", "time": "Wed Sep 13 10:44:06 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Sep 15 16:59:22 2017 -0700" }, "message": "detachables: Set TO_DEV menu\u0027s default selection to cancel\n\nBUG\u003db:65546569\nBRANCH\u003dNone\nTEST\u003dBoot into recovery, selection Disabled OS Verification.\n Ensure that in next menu, Cancel is selected.\n Also, setting default for TO_NORM menu to Confirm.\n\nChange-Id: Ibf72ec15aa38b1b815be97a08cfe7c9ee2615390\nSigned-off-by: Shelley Chen \u003cshchen@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/665356\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "1282081609321888f485318cc7d06ee047feb31e", "tree": "0c80cc7bcde61d74ba2dcbea1a475ad8dba582f5", "parents": [ "c8e3d27c814634c629b46dab0b708d3cf375c641" ], "author": { "name": "Shelley Chen", "email": "shchen@chromium.org", "time": "Wed Sep 13 10:34:11 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Sep 15 16:59:22 2017 -0700" }, "message": "detachables: Ensure keyboard input in TO_DEV menu trusted\n\nAdd in check at TO_DEV menu screen to make sure that the navigation\nkeys (up/down, volup/voldown) are trusted. Beep when user tries to\nuse unstrusted keys (usb keyboard) in the TO_DEV menu so that the user\nknows they\u0027re doing something wrong. USB keyboard return key will\nstill work in the TO_DEV menu.\n\nBUG\u003db:65546569\nBRANCH\u003dNone\nTEST\u003dtest out using up/down keys in TO_DEV menu and make sure that\n they are disabled and hear beeps.\n\nChange-Id: Ifc7183c7ca35efaf079abb196a90ab7305380642\nSigned-off-by: Shelley Chen \u003cshchen@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/665355\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "c8e3d27c814634c629b46dab0b708d3cf375c641", "tree": "775c0aca00613d733a054c6d70b31c5ba3c4eeae", "parents": [ "7fad48ef55490098bb4082c88d96f312977eac54" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Fri Sep 15 13:36:41 2017 +0800" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Sep 15 10:50:29 2017 -0700" }, "message": "Makefile: Build utils for both dynamic and static version.\n\nThe auto update process (especially firmware updater) needs static vboot\nutilitys but normal OS images, including recovery images, don\u0027t need\nthat. We should build both dynamic and static binaries at the same time\nfor images to choose what they need.\n\nCurrently only `crossystem` will build static version. And after this\nchange is merged:\n\n(cd /build/reef/usr/bin; file crossystem*)\ncrossystem: ELF 64-bit LSB shared object\ncrossystem_s: ELF 64-bit LSB executable\n\n(cd /build/reef/usr/bin; du -sh crossystem*)\n40K crossystem\n808K crossystem_s\n\nBUG\u003dchromium:764753,chromium:765499\nTEST\u003demerge-reef vboot_reference\nBRANCH\u003dNone\n\nChange-Id: Ibd66c87bb44c5593767aeb710240e0165103f016\nReviewed-on: https://chromium-review.googlesource.com/668274\nCommit-Ready: Hung-Te Lin \u003chungte@chromium.org\u003e\nTested-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "7fad48ef55490098bb4082c88d96f312977eac54", "tree": "85a8df34fc255283e6a7b860666541dedf8ad007", "parents": [ "8e0c3e5ad54c3c8442cfec9fe0a3256d16f52892" ], "author": { "name": "Shelley Chen", "email": "shchen@chromium.org", "time": "Tue Sep 12 15:30:41 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Wed Sep 13 01:50:59 2017 -0700" }, "message": "detachables: Disable Network Boot Option\n\nBUG\u003db:65595963\nBRANCH\u003dNone\nTEST\u003denabled Dev mode, reboot, select developer options \u0026\n make sure Network Boot doesn\u0027t appear in menu.\n\nChange-Id: I30953d037740259b06011ecb141d508db114b79e\nSigned-off-by: Shelley Chen \u003cshchen@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/664298\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "8e0c3e5ad54c3c8442cfec9fe0a3256d16f52892", "tree": "3cc3cd812fef26d93f0f7c8c60654dad342418cb", "parents": [ "a52fc548b4449868b0042acc81dd9fc44cdc9958" ], "author": { "name": "Shelley Chen", "email": "shchen@chromium.org", "time": "Thu Aug 31 14:10:12 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Wed Sep 13 01:50:59 2017 -0700" }, "message": "detachables: Power button turns off device on RECOVERY_INSERT screen\n\nBUG\u003db:64400325\nBRANCH\u003dNone\nTEST\u003dboot up into recovery, press power button\n ensure device shuts down.\n\nChange-Id: Ia8e6e91921e81692a2e57b1f77163c656b56ea85\nSigned-off-by: Shelley Chen \u003cshchen@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/646488\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "a52fc548b4449868b0042acc81dd9fc44cdc9958", "tree": "68924293cb492849fcef0da490c87612ac4b4b92", "parents": [ "3d25d2b4ba7886244176aa8c429fdac2acf7db3e" ], "author": { "name": "C Shapiro", "email": "shapiroc@chromium.org", "time": "Mon Sep 11 10:53:29 2017 -0600" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Tue Sep 12 13:03:23 2017 -0700" }, "message": "image_signing: Remove legacy unified build feature\n\nThis feature was originally implemented before go/cros-unibuild-signing.\nIt only provided basis support to continue testing unibuilds, but didn\u0027t\ndeal with the actual required model specific cases.\n\nUnibuilds have already been migrated away from this, so this feature is\nnow obsolete.\n\nBUG\u003dNone\nTEST\u003d~/trunk/src/platform/vboot_reference/scripts/image_signing/sign_official_build.sh\nrecovery ../build/images/coral/latest/recovery_image.bin\n../platform/vboot_reference/tests/devkeys\nBRANCH\u003dNone\n\nChange-Id: I58b569b97f0bf42a927a851e7bc0559cb1e26200\nReviewed-on: https://chromium-review.googlesource.com/660805\nCommit-Ready: C Shapiro \u003cshapiroc@google.com\u003e\nTested-by: C Shapiro \u003cshapiroc@google.com\u003e\nReviewed-by: Simon Glass \u003csjg@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "3d25d2b4ba7886244176aa8c429fdac2acf7db3e", "tree": "b2e194379ee8920c107e93d0752b5e0915d6237f", "parents": [ "f78d505e04051153d16df2a0adb9927a47d81bcd" ], "author": { "name": "Daisuke Nojiri", "email": "dnojiri@chromium.org", "time": "Thu Aug 31 10:12:40 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Sat Sep 09 02:26:17 2017 -0700" }, "message": "futility: Make rwsig sign command produce EC_RW image\n\nThis change makes futility write out a EC_RW image to the filesystem.\nIt also allows the command to run without \u0027--prikey\u0027 option. When a\nprivate key isn\u0027t provided, the command copies the previous signature.\nThis can be used to extract EC_RW without changing the key or the\nsignature. Since data only mode doesn\u0027t have a previous signature,\nthe command returns error if \u0027--prikey\u0027 isn\u0027t specified (as done\nbefore).\n\nBUG\u003db:65027647\nBRANCH\u003dnone\nTEST\u003dRun futility as follows\nfutility sign --type rwsig ec.RW.flat ec.RW.sig (Missing key error, expected)\nfutility sign --type rwsig ec.bin (EC_RW.bin is produced)\nfutility sign --type rwsig EC_RW.bin\nfutility sign --type rwsig --prikey key.vbprik2 ec.RW.flat ec.RW.sig\nfutility sign --type rwsig --prikey key.vbprik2 ec.bin (EC_RW.bin is produced)\nfutility sign --type rwsig --prikey key.vbprik2 EC_RW.bin\nmake runfutiltests\n\nChange-Id: I8c1e0cef147967cfd6d28aa7272b88c03e109e0d\nSigned-off-by: Daisuke Nojiri \u003cdnojiri@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/647804\nReviewed-by: Randall Spangler \u003crspangler@chromium.org\u003e\n" }, { "commit": "f78d505e04051153d16df2a0adb9927a47d81bcd", "tree": "f1aca878acc9a31e59d8b4ea892316b2de182c04", "parents": [ "35da86f58928bf3063b496d329e1903bdca09ecd" ], "author": { "name": "Daisuke Nojiri", "email": "dnojiri@chromium.org", "time": "Tue Aug 15 18:05:22 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Sep 08 20:04:33 2017 -0700" }, "message": "Support EC early firmware selection\n\nChromebox ECs perform EFS: verifying firmware before the AP boots.\nThis patch adds support for EC EFS.\n\nEC EFS uses two slots: one is active slot and one is used for update.\nAP is agnostic about which slot is active and which slot is for\nupdate. Instead, AP recognizes one slot as \u0027active\u0027 and the other\nas \u0027update\u0027 (or non active) slot.\n\nAfter update is successful, AP issues a cold reboot command to\nactivate the new slot.\n\nBUG\u003db:65028930,b:65264494\nBRANCH\u003dnone\nCQ-DEPEND\u003dCL:616248\nTEST\u003dbuildall. On Fizz, verify:\n1. RW_B is old and updated by soft sync. RW_B is activated and\nexecuted after reboot. System continues to boot to OS.\n2. RW_A is old and updated by soft sync. RW_A is activated and\nexecuted after reboot. System continues to boot to OS.\n\nChange-Id: I6ca7686eb28b0b548785cf2c02eca1b67018f469\nSigned-off-by: Daisuke Nojiri \u003cdnojiri@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/616346\n" }, { "commit": "35da86f58928bf3063b496d329e1903bdca09ecd", "tree": "e6ca9e95920279138deb43d1203b4394b4c20e6b", "parents": [ "16426bf1667a223f3ef52f1129fd5fe2b91787ba" ], "author": { "name": "Daisuke Nojiri", "email": "dnojiri@chromium.org", "time": "Thu Aug 31 10:49:00 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Tue Sep 05 21:07:19 2017 -0700" }, "message": "futility: Make help text for sign-rwsig accurate\n\nThis patch updates the help text for futility sign --type rwsig\ncommand. The change describes what FMAP regions are required. It\nalso names each mode (data only, data+signature, key+data+signature)\nand explains how each mode is selected.\n\nBUG\u003db:65027647\nBRANCH\u003dnone\nTEST\u003dRun futility help sign rwsig\n\nChange-Id: Ib43f5396ce4f1319f4825ef85d412483bd92d18f\nSigned-off-by: Daisuke Nojiri \u003cdnojiri@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/646377\nReviewed-by: Aaron Durbin \u003cadurbin@chromium.org\u003e\n" }, { "commit": "16426bf1667a223f3ef52f1129fd5fe2b91787ba", "tree": "9feea132a69afd78c601c8785ced3a311a27002c", "parents": [ "3f3a496a23088731e4ab5654b02fbc13a6881c65" ], "author": { "name": "C Shapiro", "email": "shapiroc@chromium.org", "time": "Tue Sep 05 10:10:26 2017 -0600" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Tue Sep 05 21:07:18 2017 -0700" }, "message": "image_signing: Fix missing root key for unibuilds\n\nFor model specific signatures, the root key needs to be copied also for\nthe development case where the root key can be flashed into the RO\nblock.\n\nBUG\u003db:65367246\nTEST\u003d./build_image --board\u003dcoral dev \\\n\u0026\u0026 ./mod_image_for_recovery.sh --board\u003dcoral \\\n\u0026\u0026 ~/trunk/src/platform/vboot_reference/scripts/image_signing/sign_official_build.sh \\\nrecovery ../build/images/coral/latest/recovery_image.bin \\\n../platform/vboot_reference/tests/devkeys\nBRANCH\u003dNone\n\nChange-Id: I116850881d3c183b20e7d75e40deb13122f40c7a\nReviewed-on: https://chromium-review.googlesource.com/650546\nCommit-Ready: C Shapiro \u003cshapiroc@google.com\u003e\nTested-by: C Shapiro \u003cshapiroc@google.com\u003e\nReviewed-by: C Shapiro \u003cshapiroc@google.com\u003e\n" }, { "commit": "3f3a496a23088731e4ab5654b02fbc13a6881c65", "tree": "da09422523c0e833db80c09e5dcbbc992f255760", "parents": [ "96a0ead803c22fb5e55effb9d3a571a4c88f29db" ], "author": { "name": "C Shapiro", "email": "shapiroc@chromium.org", "time": "Fri Sep 01 09:20:19 2017 -0600" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Sep 01 14:41:47 2017 -0700" }, "message": "image_signing: Fix loem.ini pattern for unibuilds\n\nThe grep pattern was too lenient and allowed for matches with the same\nshared root key id. E.g. NASHER also matched NASHER360\n\nThis changes the pattern to match exactly to the end of the line.\n\nBUG\u003db:65284008\nTEST\u003dgrep -E \"[0-9]+ \u003d NASHER$\" ~/tmp/loem.ini with actual loem.ini\nthat will exist on the signers\nBRANCH\u003dNone\n\nChange-Id: I80a870cd512825d30c7a39e4ac6f3cffc9ea808d\nReviewed-on: https://chromium-review.googlesource.com/647800\nCommit-Ready: C Shapiro \u003cshapiroc@google.com\u003e\nTested-by: C Shapiro \u003cshapiroc@google.com\u003e\nReviewed-by: Aaron Durbin \u003cadurbin@chromium.org\u003e\nReviewed-by: YH Lin \u003cyueherngl@chromium.org\u003e\n" }, { "commit": "96a0ead803c22fb5e55effb9d3a571a4c88f29db", "tree": "cdb3c430648cfe8daa3276008e3a1eac298d71e2", "parents": [ "d2ee3ca7c190879d5262b6b00aa77fb93786b292" ], "author": { "name": "Paul Kocialkowski", "email": "contact@paulk.fr", "time": "Thu Aug 31 09:32:23 2017 +0300" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Thu Aug 31 04:52:16 2017 -0700" }, "message": "Fix arch detection for i686\n\nThis adds detection for the i686 arch and replaces it with x86, allowing\nit to build.\n\nBRANCH\u003dnone\nBUG\u003dnone\nTEST\u003dBuild host_stuff on an i686 machine\n\nChange-Id: Idab7c762a7fbb97ec5318b9aa860756b4dd0bc25\nSigned-off-by: Paul Kocialkowski \u003ccontact@paulk.fr\u003e\nReviewed-on: https://chromium-review.googlesource.com/645086\nCommit-Ready: Patrick Georgi \u003cpgeorgi@chromium.org\u003e\nTested-by: Patrick Georgi \u003cpgeorgi@chromium.org\u003e\nReviewed-by: Aaron Durbin \u003cadurbin@chromium.org\u003e\nReviewed-by: Patrick Georgi \u003cpgeorgi@chromium.org\u003e\n" }, { "commit": "d2ee3ca7c190879d5262b6b00aa77fb93786b292", "tree": "5c3645003e9d7f0c6874b70af08775494f61d4d8", "parents": [ "bbd5c6e9e59e8a897b04f56a91cf6be4902fb1c4" ], "author": { "name": "C Shapiro", "email": "shapiroc@chromium.org", "time": "Tue Aug 29 11:36:03 2017 -0600" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Wed Aug 30 13:04:21 2017 -0700" }, "message": "image_signing: Don\u0027t create empty keyset subdir\n\nupdater4.sh uses the /keyset subdir from the firmware updater shellball\nto indicate if it should use model specific keys or not. This won\u0027t\nwork for any case where the signers haven\u0027t been updated with model\nspecific keys yet.\n\nChanged the output for unibuilds to be consistent with non-uni builds\nwhere the /keyset subdir won\u0027t be created if loem.ini doesn\u0027t exist on\nthe signer.\n\nBUG\u003db:65128657\nTEST\u003dcrrev.com/c/626718 and crrev.com/c/636344 test cases, which cover\nboth the shared and non-shared key use cases\nBRANCH\u003dNone\n\nChange-Id: I38db1385fa99ac4a9843a750c336c58b74b127b4\nReviewed-on: https://chromium-review.googlesource.com/642031\nCommit-Ready: Simon Glass \u003csjg@chromium.org\u003e\nTested-by: Simon Glass \u003csjg@chromium.org\u003e\nTested-by: C Shapiro \u003cshapiroc@google.com\u003e\nReviewed-by: Simon Glass \u003csjg@chromium.org\u003e\nReviewed-by: Jason Clinton \u003cjclinton@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "bbd5c6e9e59e8a897b04f56a91cf6be4902fb1c4", "tree": "13e846bddc38d46ead944020b2d67338d44f95e1", "parents": [ "9b3e2cba5b3bdc87c5b1d5905a2ceea451036eb0" ], "author": { "name": "Nicolas Boichat", "email": "drinkcat@google.com", "time": "Fri Aug 25 06:36:25 2017 +0800" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Sun Aug 27 02:00:40 2017 -0700" }, "message": "vb21_common2_tests: Free keyb_data\n\nBRANCH\u003dnone\nBUG\u003db:64854892\nTEST\u003dmake runlongtests\n\nChange-Id: I22d0c6e55afde6ece9535591f94ec07280ae2b12\nReviewed-on: https://chromium-review.googlesource.com/633966\nCommit-Ready: Nicolas Boichat \u003cdrinkcat@chromium.org\u003e\nTested-by: Nicolas Boichat \u003cdrinkcat@chromium.org\u003e\nReviewed-by: Randall Spangler \u003crspangler@chromium.org\u003e\n" }, { "commit": "9b3e2cba5b3bdc87c5b1d5905a2ceea451036eb0", "tree": "f63b2669b02b803b182a6c53d67c4dcd9ab47907", "parents": [ "594eb296fed7809a1e7faa714df5ca710f99a576" ], "author": { "name": "C Shapiro", "email": "shapiroc@chromium.org", "time": "Fri Aug 25 13:01:39 2017 -0600" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Aug 25 19:54:10 2017 -0700" }, "message": "[unibuild] Fix issues with model specific fw sign\n\nUpdated the current coral config to use the fake keys from the loemkeys\ndev keyset (ACME) and then tested/debugged this flow based on that\nconfig.\n\nFixed issue where key_id wasn\u0027t eval\u0027d in bash when it was passed to\ngrep because it has \u0027 quotes around it.\n\nBUG\u003db:64842314\nTEST\u003d~/trunk/src/platform/vboot_reference/scripts/image_signing/sign_official_build.sh\nrecovery\n../build/images/coral/R62-9877.0.2017_08_25_1030-a1/recovery_image.bin\n../platform/vboot_reference/tests/loemkeys\ncoral_loem_signed_recovery.bin\nBRANCH\u003dNone\n\nChange-Id: I50a58e512e9a83dc2707951f12d709f9006d67ca\nReviewed-on: https://chromium-review.googlesource.com/636344\nCommit-Ready: C Shapiro \u003cshapiroc@google.com\u003e\nTested-by: C Shapiro \u003cshapiroc@google.com\u003e\nReviewed-by: Simon Glass \u003csjg@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "594eb296fed7809a1e7faa714df5ca710f99a576", "tree": "3f0a93bc3c262b4ca1d2aa072d2056c950f015e3", "parents": [ "4ec9ee378497b414dbf8f899ea3d297b48f40bc7" ], "author": { "name": "Nicolas Boichat", "email": "drinkcat@google.com", "time": "Thu Aug 24 17:27:56 2017 +0800" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Aug 25 12:09:04 2017 -0700" }, "message": "image_signing: sign_official_build.sh: Add version to rwsig signatures\n\nWe would like to have different signature versions for hammer\n(1\u003ddev, 2\u003dpremp, 3\u003dmp), so we should pass --version to futility.\n\nThe default version stays 1.\n\nBRANCH\u003dnone\nBUG\u003db:35587169\nTEST\u003dopenssl genrsa -3 -out key_hammer.pem 2048\n futility create --desc\u003d\"Hammer fake MP key\" key_hammer.pem key_hammer\n echo firmware_version\u003d2 \u003e key_hammer.version\n ../vboot_reference/scripts/image_signing/sign_official_build.sh \\\n accessory_rwsig build/hammer/ec.bin . \\\n ec-signed.bin key_hammer.version\n futility show ec-signed.bin \u003d\u003e Version: 0x00000002\nTEST\u003dWithout passing a version file, version is still 1.\n ../vboot_reference/scripts/image_signing/sign_official_build.sh \\\n accessory_rwsig build/hammer/ec.bin . ec-signed.bin\n futility show ec-signed.bin \u003d\u003e Version: 0x00000001\n\nChange-Id: I0cd9133404fb0d827bd2f0d3bcc71d5dd274734d\nReviewed-on: https://chromium-review.googlesource.com/631757\nCommit-Ready: Nicolas Boichat \u003cdrinkcat@chromium.org\u003e\nTested-by: Nicolas Boichat \u003cdrinkcat@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "4ec9ee378497b414dbf8f899ea3d297b48f40bc7", "tree": "786a744714bfd4704d34b46c66dfcbb2d8658ab2", "parents": [ "a9cbc267362c71005790cf5b7ca6a8f8d864cea0" ], "author": { "name": "Nicolas Boichat", "email": "drinkcat@google.com", "time": "Wed Aug 23 17:39:25 2017 +0800" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Thu Aug 24 01:25:50 2017 -0700" }, "message": "vb21_common2_tests: Fix test for exponent 3 keys\n\nvb2_public_key_read_keyb cannot be used for VB2.1 public keys\n(especially not for 2048 exponent 3 or F4, as their size is the\nsame so the algorithm cannot be guess).\n\nInstead, do what futility/rwsig does and derive the public key from\nthe private RSA key.\n\nBRANCH\u003dnone\nBUG\u003db:64854892\nTEST\u003dmake runlongtests\n\nChange-Id: Ie81f40e6076cd0c234012b9af58e39425f8b717c\nSigned-off-by: Nicolas Boichat \u003cdrinkcat@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/628177\nCommit-Ready: Nicolas Boichat \u003cdrinkcat@chromium.org\u003e\nTested-by: Nicolas Boichat \u003cdrinkcat@chromium.org\u003e\nReviewed-by: Randall Spangler \u003crspangler@chromium.org\u003e\nReviewed-by: Caveh Jalali \u003ccaveh@google.com\u003e\n" }, { "commit": "a9cbc267362c71005790cf5b7ca6a8f8d864cea0", "tree": "cf8349b2dff4fa1510bdac07f31772434451bce2", "parents": [ "b2b3970923b7971acf78b11d5678ddc3a3a23521" ], "author": { "name": "Caveh Jalali", "email": "caveh@google.com", "time": "Sat Aug 19 12:25:42 2017 +0800" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Thu Aug 24 01:25:50 2017 -0700" }, "message": "tests: Add support for exponent 3 keys\n\nBRANCH\u003dnone\nBUG\u003db:64854892\nTEST\u003dmake runlongtests\n\nChange-Id: I827ce47b68339dc4df7f84b26a0b6643af27037b\nSigned-off-by: Caveh Jalali \u003ccaveh@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/628176\nCommit-Ready: Nicolas Boichat \u003cdrinkcat@chromium.org\u003e\nTested-by: Nicolas Boichat \u003cdrinkcat@chromium.org\u003e\n" }, { "commit": "b2b3970923b7971acf78b11d5678ddc3a3a23521", "tree": "ae86830209d4952c67a6e266991c529b35efea41", "parents": [ "509339ce2b7499ccb90331ab6910b87d0f9889a5" ], "author": { "name": "Mattias Nissler", "email": "mnissler@chromium.org", "time": "Fri Jul 07 10:26:43 2017 +0200" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Wed Aug 23 17:01:24 2017 -0700" }, "message": "Add support for IFX FieldUpgradeInfoRequest2 command\n\nAdd tpm_lite library support for the IFX specific TPM_FieldUpgrade\nsubcommand \"FieldUpgradeInfoRequest2\". Expose this via tpmc so it can\nbe used from shell scripts.\n\nBRANCH\u003dnone\nBUG\u003dchromium:728130\nTEST\u003dBuilds and tpmc ifxfieldupgradeinfo prints plausible results.\n\nChange-Id: Ie58ebccef7fe90f7fca65d7cd9c78e1f16f9f29a\nReviewed-on: https://chromium-review.googlesource.com/562772\nCommit-Ready: Mattias Nissler \u003cmnissler@chromium.org\u003e\nTested-by: Mattias Nissler \u003cmnissler@chromium.org\u003e\nReviewed-by: Mattias Nissler \u003cmnissler@chromium.org\u003e\n" }, { "commit": "509339ce2b7499ccb90331ab6910b87d0f9889a5", "tree": "ae383dbba8fb40b45db2a3dfcf15b0cfabf7ac25", "parents": [ "93f1142d7a7bbee5c1bb551d197ce1e4c2c2ef87" ], "author": { "name": "C Shapiro", "email": "shapiroc@chromium.org", "time": "Tue Aug 22 11:40:23 2017 -0600" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Wed Aug 23 08:02:12 2017 -0700" }, "message": "[unibuild] Support for unibuild firmware signing\n\nFor design context, see go/cros-unibuild-signing\n\nThis adds support for multiple, shared firmware images from a unified\nbuild that needs to be signed with different OEM specific keys.\n\nIt uses a signer_config.csv file (that is generated by pack_firmware.py)\nto determine which images need to be signed with which keys.\n\nBUG\u003db:64842314\nTEST\u003d./build_image --board\u003dcoral dev\n\u0026\u0026 ./mod_image_for_recovery.sh --board\u003dcoral\n\u0026\u0026 ~/trunk/src/platform/vboot_reference/scripts/image_signing/sign_official_build.sh\nrecovery ../build/images/coral/latest/recovery_image.bin\n../platform/vboot_reference/tests/devkeys\nBRANCH\u003dNone\n\nChange-Id: Id3711bbe73dfe652184bc046b5f642c30b8d1627\nReviewed-on: https://chromium-review.googlesource.com/626718\nCommit-Ready: C Shapiro \u003cshapiroc@google.com\u003e\nTested-by: C Shapiro \u003cshapiroc@google.com\u003e\nReviewed-by: C Shapiro \u003cshapiroc@google.com\u003e\n" }, { "commit": "93f1142d7a7bbee5c1bb551d197ce1e4c2c2ef87", "tree": "4e0ac2c359adba2389259ae9f26f59e46a128913", "parents": [ "5afa7faf7bfc4ec5efd22af5f2124a575bc64e52" ], "author": { "name": "Shelley Chen", "email": "shchen@chromium.org", "time": "Wed Aug 16 11:31:05 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Mon Aug 21 22:03:59 2017 -0700" }, "message": "detachables: Display recovery insert icon at recovery startup\n\nWhen user first starts up recovery (3 finger salute), display\nusb insert instructions and original insert graphic until user\nstarts pushing volume buttons. If the user pushes power button\nduring while the icon is displayed (no menu items), device will\nshut down (this is to accomodate users that accidentally enter\nthe recovery screen and want to exit quickly). Upon user\npressing the volume buttons, the insert icon will disappear\nand user will see the menu items and be able to scroll up/down.\n\nBUG\u003db:64400325\nBRANCH\u003dNone\nTEST\u003dboot into recovery. Make sure graphic shown until start\n pushing volume buttons.\n\nChange-Id: I4a5001271a0b84d1237d4bbc6a098afa10cb9372\nSigned-off-by: Shelley Chen \u003cshchen@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/617600\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "5afa7faf7bfc4ec5efd22af5f2124a575bc64e52", "tree": "b53159d411d583c322e90b3df1348ca621ee7f21", "parents": [ "8610346356a56d6f1b78f5eb9da456d11fc8264f" ], "author": { "name": "Caveh Jalali", "email": "caveh@google.com", "time": "Fri Aug 11 17:07:10 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Mon Aug 21 17:55:25 2017 -0700" }, "message": "ec_sync: always call VbExUpdateAuxFw\n\ncall VbExUpdateAuxFw() uncontidionally, instead of when we know we\nneed to do an update. Vb*AuxFw() already maintains state, so this\ndoesn\u0027t change when we (attempt) to update firmware.\n\nhowever, this does allow us to iterate over all firmware drivers to\ncall their .protect() method. previously, we would only call\n.protect() after an actual firmware update.\n\nupdated unit tests to match the new logic.\n\nBRANCH\u003dnone\nBUG\u003db:35585700\nTEST\u003dverified i2c tunnels are protected on reef using\n\tectool i2cprotect N status.\n\nChange-Id: I9244db28ed181f568d117092307293202257735b\nSigned-off-by: Caveh Jalali \u003ccaveh@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/620281\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "8610346356a56d6f1b78f5eb9da456d11fc8264f", "tree": "c5616e3bc730014473724302522d394475449c3c", "parents": [ "8c4b828502d8c6c7112286720dddfd30c92a968e" ], "author": { "name": "Furquan Shaikh", "email": "furquan@chromium.org", "time": "Fri Aug 18 11:36:58 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Aug 18 16:46:34 2017 -0700" }, "message": "lib/vboot_ui_menu: Consider volume buttons in vb2_update_selection\n\nvb2_update_selection considered only KEY_UP and KEY_DOWN inputs to\nupdate the selection. This resulted in volume buttons not working on\nfirmware screen to update the selection. Add volume buttons as valid\ninputs in vb2_update_selection.\n\nBUG\u003db:64839396\nBRANCH\u003dNone\nTEST\u003dVerified that volume buttons work on firmware screen.\n\nChange-Id: I08bfa91eafb170fb450649a2abaafe7f4d58e17b\nSigned-off-by: Furquan Shaikh \u003cfurquan@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/621787\nReviewed-by: Aaron Durbin \u003cadurbin@chromium.org\u003e\nReviewed-by: Shelley Chen \u003cshchen@chromium.org\u003e\n" }, { "commit": "8c4b828502d8c6c7112286720dddfd30c92a968e", "tree": "051cd3d48aef4bd58d8ca91862868466b2881cfd", "parents": [ "3f24b902e473777f59c35673f645a6e05f19977d" ], "author": { "name": "Shelley Chen", "email": "shchen@chromium.org", "time": "Mon Jul 31 14:28:42 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Mon Aug 14 20:37:45 2017 -0700" }, "message": "detachables: Skip \"Enable Developer Mode\" in DEV mode\n\nWhen DUT is already in dev mode, don\u0027t let user select the \"Enable\nDeveloper Mode\" selection in the menu. Add disabled_idx_mask to\nVbExDisplayMenu API to allow for disabling of menu items in the future\nif needed.\n\nBUG\u003db:63078243, b:35585623\nBRANCH\u003dNone\nTEST\u003dreboot into recovery with DUT already in dev mode. Make sure\n can\u0027t scroll to \"Enable Developer Mode: entry.\n reboot into recovery with DUT in normal mode. Make sure\n \"Enable Developer Mode\" entry is selectable.\nCQ-DEPEND\u003dCL:565335\n\nChange-Id: Ic71fe6aa2e41337787a0c2278f729356edb155fd\nSigned-off-by: Shelley Chen \u003cshchen@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/598430\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "3f24b902e473777f59c35673f645a6e05f19977d", "tree": "dce0b239f5b6a9c9ed80dc2cbf3f8e41eab11744", "parents": [ "a9dca5c04d4bfc797ff567f3d358f819c101ec2f" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Tue May 09 13:15:15 2017 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Wed Aug 09 21:46:13 2017 -0700" }, "message": "image_signing: convert_recovery_to_ssd.sh: rewrite to be better\n\nThis converts the script in one commit as nothing uses it directly,\nso the chances of it breaking overall build is low.\n- Convert to common.sh for more helpers\n- Convert echo to info\n- Convert to loopback devices to speed things up\n- Fix quoting in a few places\n- Drop cgpt usage since we use loopback partitions everywhere now\n\nBRANCH\u003dNone\nBUG\u003dchromium:714598\nTEST\u003drunning on an image still works\n\nChange-Id: I6608db77792502f35522a6f793ccd800fdd6af4e\nReviewed-on: https://chromium-review.googlesource.com/505482\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: David Riley \u003cdavidriley@chromium.org\u003e\n" }, { "commit": "a9dca5c04d4bfc797ff567f3d358f819c101ec2f", "tree": "fb576ec3b49d9746c8f1a01ba8f8c69d588781da", "parents": [ "ca97b25a33acbec1de6a2e74ca1e9693151dd100" ], "author": { "name": "Jeffy Chen", "email": "jeffy.chen@rock-chips.com", "time": "Mon Feb 20 21:26:58 2017 +0800" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Wed Aug 09 19:33:48 2017 -0700" }, "message": "cgpt: prioritize: Make sure all headers/entries are valid\n\nThe prioritize cmd expected primary gpt header and entries are valid.\n\nAdd a validity check to guarantee that.\n\nBUG\u003db:35585016\nTEST\u003dCheck on bob, the secondary gpt still valid after these commands:\ndd if\u003d/dev/zero of\u003d/dev/mmcblk0 bs\u003d512 count\u003d64\ncgpt prioritize /dev/mmcblk0\n\nChange-Id: I853e25211a46fa3ce93cef1e5169b93b0a6430a9\nSigned-off-by: Jeffy Chen \u003cjeffy.chen@rock-chips.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/604814\nReviewed-by: Randall Spangler \u003crspangler@chromium.org\u003e\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "ca97b25a33acbec1de6a2e74ca1e9693151dd100", "tree": "603d2c01fcbaf0e983603a72d67e50e020fcc8c8", "parents": [ "fc7b3972bc43da9f1b33ca8d3fd1eddf854a3635" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Tue May 09 04:07:11 2017 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Thu Aug 03 10:11:42 2017 -0700" }, "message": "image_signing: sign_official_build.sh: use loopbacks kernel configs w/boot loader updates\n\nThis is the last place that uses grab_kernel_config. Convert it over\nto accessing the kernel directly via loopbacks and delete the helper\nfunction entirely. This avoids unnecessary copies and prevents any\nmore code from using it.\n\nBRANCH\u003dNone\nBUG\u003dchromium:714598\nTEST\u003ddump_config still works\n\nChange-Id: I16aa2c2568d15c43bb20b9d5dc18060915047506\nReviewed-on: https://chromium-review.googlesource.com/505481\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: David Riley \u003cdavidriley@chromium.org\u003e\n" }, { "commit": "fc7b3972bc43da9f1b33ca8d3fd1eddf854a3635", "tree": "b2e9674e92f1111f3d640dcbd9f52fabb76c74a4", "parents": [ "356eab1c8ea5310889e9fcaa95089cc742c8ef24" ], "author": { "name": "Shelley Chen", "email": "shchen@chromium.org", "time": "Mon Jul 10 10:31:20 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Tue Aug 01 13:01:42 2017 -0700" }, "message": "detachables: Select power off after language selection\n\nSet current selection to power off after exiting the languages menu.\nPreviously, we were just defaulting to selecting the 0 index. However,\nthis won\u0027t work anymore if we hide the \"Enable Developer Mode\" entry\nin the recovery menu due to that entry being at the 0th index.\n\nBUG\u003db:63078243, b:35585623\nBRANCH\u003dNone\nTEST\u003dBoot into recovery when machine in normal mode.\n Select languages menu, make language selection and make sure\n that when return to recovery menu, power off item is selected.\n\nChange-Id: I479c2270ca99197fd8c44386ab1ca4526ae7d64a\nSigned-off-by: Shelley Chen \u003cshchen@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/565527\nReviewed-by: Randall Spangler \u003crspangler@chromium.org\u003e\n" }, { "commit": "356eab1c8ea5310889e9fcaa95089cc742c8ef24", "tree": "ab60f6728e229ad00ecb1767dd8d29de9f81a9c2", "parents": [ "8b71425257d251858410de71efcf389df8b200d2" ], "author": { "name": "Shelley Chen", "email": "shchen@chromium.org", "time": "Fri Jul 07 09:57:22 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Mon Jul 31 17:08:29 2017 -0700" }, "message": "detachables: Set fw screen timeout to 30 secs upon button press\n\nFor detachables, the short delay is to fast to them to read/choose\noptions. Setting timeout to 30 seconds once user starts scrolling\nthrough the menu. If no action is taken by the user, will retain\nthe short delay timeout.\n\nBUG\u003db:63056097, b:35585623\nBRANCH\u003dNone\nTEST\u003dreboot with gbb flag bit 1 enabled and ensure using short delay.\n reboot and press volume button and make sure using long delay.\n reboot and make sure short delay performed again upon reboot.\n reboot and make sure gbb flag bit 1 \u003d 0 and make sure long delay\n still working as expected.\n\nChange-Id: I31e3ca8aff6b29abca70ca9587deae7f6443d837\nSigned-off-by: Shelley Chen \u003cshchen@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/563817\nReviewed-by: Randall Spangler \u003crspangler@chromium.org\u003e\n" }, { "commit": "8b71425257d251858410de71efcf389df8b200d2", "tree": "4f4e0e0d9d58a683a6e3db4ed06e5ca67123428d", "parents": [ "2a7e9b84ac69c374112a13fd16fbf7cb996b78bf" ], "author": { "name": "Julius Werner", "email": "jwerner@chromium.org", "time": "Mon Jul 17 13:51:25 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Tue Jul 18 02:36:16 2017 -0700" }, "message": "crossystem: Remove defunct sw_wpsw_boot field\n\nThe sw_wpsw_boot field only ever worked correctly on some platforms. It\nalso isn\u0027t used anywhere in the codebase (only other reference is a\ncomment about how it doesn\u0027t always work in factory_installer.sh), and\nit\u0027s no longer clear what it was meant for in the first place\n(b/35510092 hints at needing it for some planned feature that was never\nimplemented). Let\u0027s get rid of it to avoid confusing people.\n\nIf userspace tools need to know the software write-protect state, they\ncan instead run flashrom directly. For feedback reports, this output is\nalready included in the \"verified boot\" section.\n\nBRANCH\u003dnone\nBUG\u003dchromium:508269,chromium:742685\nTEST\u003dnone\n\nChange-Id: I8975b1e2c8e604b4cb48d092c13b923b4db2d207\nSigned-off-by: Julius Werner \u003cjwerner@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/575389\nReviewed-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-by: Aaron Durbin \u003cadurbin@chromium.org\u003e\nReviewed-by: Randall Spangler \u003crspangler@chromium.org\u003e\n" }, { "commit": "2a7e9b84ac69c374112a13fd16fbf7cb996b78bf", "tree": "3a3ddc06183f57bc31262fbc2456142f66cd4dae", "parents": [ "68466c6d0a6cf629b77972773f523118b9cbb7be" ], "author": { "name": "Mattias Nissler", "email": "mnissler@chromium.org", "time": "Mon Jul 10 13:46:20 2017 +0200" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Tue Jul 18 00:32:48 2017 -0700" }, "message": "Implement tpmc getversion command.\n\nThis command exposes the vendor and TPM firmware version.\n\nBRANCH\u003dnone\nBUG\u003dchromium:728130\nTEST\u003dBuilds and tpmc getversion prints plausible results.\n\nChange-Id: Iec556a298e025e10bda00121b40a25d8dc3839d1\nReviewed-on: https://chromium-review.googlesource.com/565287\nCommit-Ready: Mattias Nissler \u003cmnissler@chromium.org\u003e\nTested-by: Mattias Nissler \u003cmnissler@chromium.org\u003e\nReviewed-by: Jorge Lucangeli Obes \u003cjorgelo@chromium.org\u003e\nReviewed-by: Andrey Pronin \u003capronin@chromium.org\u003e\n" }, { "commit": "68466c6d0a6cf629b77972773f523118b9cbb7be", "tree": "e8fa76e923a138bcaedb294875f643967e5bbe47", "parents": [ "8e556f4e2344b71b0be0b73b29c8185b677dd57f" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Tue May 09 03:56:17 2017 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Sat Jul 15 14:45:13 2017 -0700" }, "message": "image_signing: sign_official_build.sh: use loopbacks for rootfs hash updates\n\nThis avoids copying GB of data for the rootfs \u0026 kernels by using loopback\ndevices instead.\n\nBRANCH\u003dNone\nBUG\u003dchromium:714598\nTEST\u003ddump_config still works\n\nChange-Id: I41cd71db3c567be811c4a59523c797c128a8e493\nReviewed-on: https://chromium-review.googlesource.com/505480\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: David Riley \u003cdavidriley@chromium.org\u003e\n" }, { "commit": "8e556f4e2344b71b0be0b73b29c8185b677dd57f", "tree": "8b0f63466dcbe7406b966d7666ff3c18fd2d171c", "parents": [ "bce7904376beee2912932433a4634c1c25afe2f5" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Tue May 09 03:38:20 2017 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Thu Jul 13 19:46:10 2017 -0700" }, "message": "image_signing: sign_official_build.sh: use loopbacks for dump_config\n\nThis avoids copying out the kernels just to read their configs.\nNot super important as the signer doesn\u0027t use it, but we want to\nkill off the grab_kernel_config helper.\n\nBRANCH\u003dNone\nBUG\u003dchromium:714598\nTEST\u003ddump_config still works\n\nChange-Id: I2533b1d4de6980120f277fea3a1d964cb4fbaf0d\nReviewed-on: https://chromium-review.googlesource.com/505479\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: David Riley \u003cdavidriley@chromium.org\u003e\n" }, { "commit": "bce7904376beee2912932433a4634c1c25afe2f5", "tree": "bba8df33dab5fb6d3c64b13ac3a290e8da03c780", "parents": [ "06beb42e11733670eb1894f12586443a37a5af7c" ], "author": { "name": "Daniel Kurtz", "email": "djkurtz@chromium.org", "time": "Fri Jun 30 11:45:08 2017 +0800" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Jul 07 00:57:17 2017 -0700" }, "message": "Update for openssl 1.1\n\nOpenSSL 1.1 has made significant non-backwards compatible changes to its\nAPI as outlined in:\nhttps://wiki.openssl.org/index.php/OpenSSL_1.1.0_Changes\n\nBRANCH\u003dnone\nBUG\u003dchromium:738114\nTEST\u003dcros_workon --host start vboot_reference\nTEST\u003dw/ openssl-1.0.2k: sudo emerge vboot_reference\nTEST\u003dw/ openssl-1.1.0e: sudo emerge vboot_reference\n \u003d\u003e both build ok\n $ futility version\n \u003d\u003e command runs without error\nTEST\u003dcros_workon --board\u003dsoraka start vboot_reference coreboot\nTEST\u003dw/ openssl-1.0.2k: emerge-soraka vboot_reference coreboot\nTEST\u003dw/ openssl-1.1.0e: emerge-soraka vboot_reference coreboot\n \u003d\u003e All build ok\n\nChange-Id: I37cfc8cbb04a092eab7b0b3224f475b82609447c\nReviewed-on: https://chromium-review.googlesource.com/557739\nCommit-Ready: Daniel Kurtz \u003cdjkurtz@chromium.org\u003e\nTested-by: Daniel Kurtz \u003cdjkurtz@chromium.org\u003e\nReviewed-by: Randall Spangler \u003crspangler@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "06beb42e11733670eb1894f12586443a37a5af7c", "tree": "2917ef6e2e5cd273694b48ab636faf7045750102", "parents": [ "3dd580298b42d9d77e1f37733e4df2b6d5c302c6" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Tue May 09 03:29:37 2017 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Thu Jul 06 21:13:56 2017 -0700" }, "message": "image_signing: sign_official_build.sh: use loopbacks when updating recovery kernels\n\nThis avoids copying in/out the kernels for their configs and to resign.\n\nBRANCH\u003dNone\nBUG\u003dchromium:714598\nTEST\u003dsigning images still works\n\nChange-Id: Id13d5099da7f8a73ebd4d4e918188c7eb5b65a12\nReviewed-on: https://chromium-review.googlesource.com/505478\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: David Riley \u003cdavidriley@chromium.org\u003e\n" }, { "commit": "3dd580298b42d9d77e1f37733e4df2b6d5c302c6", "tree": "4b637f49b5e9c40bb0657ef8f88beb721465d468", "parents": [ "074697374b452d44450d0108d598ad001dc2d90d" ], "author": { "name": "Caveh Jalali", "email": "caveh@google.com", "time": "Fri May 12 16:46:41 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Wed Jun 28 03:09:49 2017 -0700" }, "message": "call depthcharge hooks for auxiliary FW update.\n\nthis adds calls to depthcharge (using callbacks) to do auxiliary\nfirmware updates. in particular, this is intended to trigger TCPC\nupdates, but other programmables could also be updated.\n\nno firmware updates take place until a board file has actually\nregistered a firmware update \"driver\". board file updates to follow.\n\nTEST\u003d\"COV\u003d1 make\" passes.\n\t depthcharge boots on snappy.\n\t with additional follow-on CLs, we can update the ps8751.\n\nthe companion depthcharge changes are here:\n\nhttps://chromium-review.googlesource.com/c/498150/\n\nthe working design doc is here:\n\nhttps://docs.google.com/a/google.com/document/d/1uzS0b3O3Us1QI2Sx7LDkjEfHmuhYB2BolrAoNwCVoc0/edit?usp\u003dsharing\n\nthese features depend on vboot API updates:\n\nCQ-DEPEND\u003dCL:498150\nBUG\u003db:35586896\nBRANCH\u003dnone\n\nChange-Id: If0d634eab08b429a8e7e80f5fe11eab3705bba0f\nSigned-off-by: Caveh Jalali \u003ccaveh@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/505260\nReviewed-by: Stefan Reinauer \u003creinauer@chromium.org\u003e\n" }, { "commit": "074697374b452d44450d0108d598ad001dc2d90d", "tree": "e73c5db97b0c3e769b025ec7d398dafd2d3d4436", "parents": [ "10e76bd2356ea69dcafaba2af60f63b6b33373fc" ], "author": { "name": "Alex Suykov", "email": "alex.suykov@gmail.com", "time": "Tue Jan 05 11:51:55 2016 +0200" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Wed Jun 28 00:59:00 2017 -0700" }, "message": "host lib: include \u003csys/types.h\u003e for ssize_t\n\nIn uClibc neither \u003cstdio.h\u003e nor \u003cstrings.h\u003e defines ssize_t.\n\nChange-Id: I7fb6a0f51eae76062784952beb42298c486461b5\nSigned-off-by: Alex Suykov \u003calex.suykov@gmail.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/320472\nCommit-Ready: Stefan Reinauer \u003creinauer@google.com\u003e\nTested-by: Stefan Reinauer \u003creinauer@google.com\u003e\nReviewed-by: Stefan Reinauer \u003creinauer@google.com\u003e\n" }, { "commit": "10e76bd2356ea69dcafaba2af60f63b6b33373fc", "tree": "7c6ea433cf689f25514dfe6c8dadc3f5b75738b2", "parents": [ "3abb4fe45e0e25d203c77d1a5ed1afd49a5a594c" ], "author": { "name": "Stefan Reinauer", "email": "reinauer@google.com", "time": "Tue Jun 20 13:19:24 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Tue Jun 27 17:56:16 2017 -0700" }, "message": "Drop pre-vboot2 safe guards\n\nSigned-off-by: Stefan Reinauer \u003creinauer@chromium.org\u003e\n\nBRANCH\u003dnone\nTEST\u003dsudo emerge vboot_reference\nBUG\u003dnone\n\nChange-Id: Id98347cc6d4fb79cc2caa103b83c4aec82f4ef6a\nReviewed-on: https://chromium-review.googlesource.com/541584\nCommit-Ready: Stefan Reinauer \u003creinauer@google.com\u003e\nTested-by: Stefan Reinauer \u003creinauer@google.com\u003e\nReviewed-by: Randall Spangler \u003crspangler@chromium.org\u003e\n" }, { "commit": "3abb4fe45e0e25d203c77d1a5ed1afd49a5a594c", "tree": "6719bec34cef6cd4b99df90e057ce9a1a222fc8a", "parents": [ "7662a7e3d062bea6ce3bb224c237ce9cf9e6a018" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Tue May 09 02:59:09 2017 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Jun 23 22:56:47 2017 -0700" }, "message": "image_signing: sign_official_build.sh: switch initial image signing to loopbacks\n\nThis changes the kernel config reading and the stateful vblock updating\nto use loopback devices. This avoids having to copy out the kernels\nmany times over just to read them.\n\nBRANCH\u003dNone\nBUG\u003dchromium:714598\nTEST\u003dsigning images still works\n\nChange-Id: Ibb49791a7db998e45b35ed15ddc12126e669c730\nReviewed-on: https://chromium-review.googlesource.com/505477\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: David Riley \u003cdavidriley@chromium.org\u003e\nReviewed-by: Jorge Lucangeli Obes \u003cjorgelo@chromium.org\u003e\n" }, { "commit": "7662a7e3d062bea6ce3bb224c237ce9cf9e6a018", "tree": "6ba2164169efe78c8235af6fab47f0f39dd56fdb", "parents": [ "7bd4c0375bbc39d9d2bedeb3aa4c9b2c4c1a8575" ], "author": { "name": "Erdi Chen", "email": "erdi@google.com", "time": "Fri Jun 23 14:28:10 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Jun 23 22:56:43 2017 -0700" }, "message": "cgpt: show: Print partition size with 64-bit format\n\nPartition size on 4TB drive can overflow 32-bit integers. Running \"cgpt\nshow /dev/sda\" prints negative number for the state partition (sda1).\n\nBRANCH\u003dnone\nBUG\u003dnone\nTEST\u003dRun \"cgpt show /dev/sda\" with 4TB drive.\n\nChange-Id: I56f3b43594028695745de8c5a1626d940a3b4c5b\nReviewed-on: https://chromium-review.googlesource.com/546879\nCommit-Ready: Erdi Chen \u003cerdi@google.com\u003e\nTested-by: Erdi Chen \u003cerdi@google.com\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "7bd4c0375bbc39d9d2bedeb3aa4c9b2c4c1a8575", "tree": "7a3704c2b490261b0a55260fea7428be0ca51f37", "parents": [ "05418ff02ce0869e13105a4d33545169abeaa2ec" ], "author": { "name": "Shelley Chen", "email": "shchen@chromium.org", "time": "Thu Jun 22 08:19:04 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Thu Jun 22 17:03:50 2017 -0700" }, "message": "detachables: Fix language menu size in recovery\n\nBUG\u003db:35585623\nBRANCH\u003dNone\nTEST\u003dReboot into recovery, scroll to language menu\n and make sure that you can scroll and select\n other languages.\n\nChange-Id: I6fe7f0550b05e33eaeef928cd23932f5a40fe9ad\nSigned-off-by: Shelley Chen \u003cshchen@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/544897\nReviewed-by: Randall Spangler \u003crspangler@chromium.org\u003e\n" }, { "commit": "05418ff02ce0869e13105a4d33545169abeaa2ec", "tree": "9a54a437bf4a73fe4681438b8993da9260b7de5f", "parents": [ "01dc8189247394893bbe163fa6b4897a3593bf9c" ], "author": { "name": "Shelley Chen", "email": "shchen@chromium.org", "time": "Tue Jun 20 13:49:34 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Thu Jun 22 17:03:50 2017 -0700" }, "message": "detachables: Highlight selection w/ Debug Info\n\nCurrently with detachable menu, when debug info is\ndisplayed, the current selection is not highlighted.\nChanging call in VbDisplayDebugInfo from\nVbDisplaySecreen to VbDisplayMenu to ensure\nselection is highlighted. This will have no effect\non firmware screens for non-detachables.\n\nBUG\u003db:35585623\nBRANCH\u003dNone\nTEST\u003dCompile with and without USE\u003ddetachable_ui\n Reboot and display debug info. Make sure\n that for detachable menu, selection remains\n highlighted and for non-detachable screens,\n The screen displays as usual.\n\nChange-Id: I0a7a2c4e0ae3ffb82e13dc92a319288d4ccb3997\nSigned-off-by: Shelley Chen \u003cshchen@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/541758\nReviewed-by: Randall Spangler \u003crspangler@chromium.org\u003e\nReviewed-by: Furquan Shaikh \u003cfurquan@chromium.org\u003e\nReviewed-by: Stefan Reinauer \u003creinauer@google.com\u003e\n" }, { "commit": "01dc8189247394893bbe163fa6b4897a3593bf9c", "tree": "04ddb271e0b7fbc36a80b96d6c7b1df1b0a417d5", "parents": [ "3522e574a21a65ae4ef76ac396101c68e1c985a1" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Mon Jun 19 10:08:46 2017 +0800" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Wed Jun 21 23:38:08 2017 -0700" }, "message": "Change invocation of \"gbb_utility\" to \"futility gbb\"\n\nReplace commands using gbb_utility by the new \u0027gbb\u0027 futility command.\n\nBRANCH\u003dnone\nBUG\u003dNone\nTEST\u003dUSE\u003dtest emerge-$BOARD vboot_reference\n\nChange-Id: I8c1547d295a955373413482509a33964b0e0c06f\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/538442\nReviewed-by: Stefan Reinauer \u003creinauer@google.com\u003e\n" }, { "commit": "3522e574a21a65ae4ef76ac396101c68e1c985a1", "tree": "f2ab47fbd2045671f7bbe45f41679729b59772d6", "parents": [ "4007d6ff218110d55830c6dc2ca9822825afa0da" ], "author": { "name": "Randall Spangler", "email": "rspangler@chromium.org", "time": "Wed Jun 07 13:20:46 2017 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Tue Jun 20 17:24:20 2017 -0700" }, "message": "2lib: Add test_mockable attribute\n\nSome tests mock library functions. This previously worked due to adding\n\n CFLAGS +\u003d -Xlinker --allow-multiple-definition\n\nto the test binaries. But the new version of binutils seems to need\nthe default implementation to be weak if compiled with -O2 in some\ncases. Add test_mockable for use with functions where this is now\nneeded.\n\nBUG\u003dchromium:723906\nBRANCH\u003dnone\nTEST\u003dAdd CFLAGS +\u003d -O2 to the makefile, then make -j runtests\n Tests break before this change with -O2, and work afterwards\n\nChange-Id: I95996a3e1086251442055765295a75de4c20ee3c\nSigned-off-by: Randall Spangler \u003crspangler@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/527601\nCommit-Ready: Manoj Gupta \u003cmanojgupta@chromium.org\u003e\nTested-by: Rahul Chaudhry \u003crahulchaudhry@chromium.org\u003e\nReviewed-by: Rahul Chaudhry \u003crahulchaudhry@chromium.org\u003e\n" }, { "commit": "4007d6ff218110d55830c6dc2ca9822825afa0da", "tree": "27c289a36cec0131a909175c8512f704dfe9e273", "parents": [ "c8d08ca31313d9ef5f85d0614f00eb3e4494aa71" ], "author": { "name": "C Shapiro", "email": "shapiroc@google.com", "time": "Mon Jun 19 16:53:58 2017 -0600" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Tue Jun 20 13:38:10 2017 -0700" }, "message": "Unified build support for multi-firmware signing\n\nUnified builds break down multiple firmware images for each model;\nhowever, the signing script didn\u0027t have support for this.\n\nThis updates the signing script to iterate over all models in a unified\nbuild and sign each firmware image separately.\n\nBUG\u003dchromium:734485\nTEST\u003dsign_official_build.sh recovery for reef and reef-uni\nBRANCH\u003dnone\n\nChange-Id: Ia2b5b8bd36ac77aeb7944362186d1d5739e6ff3d\nReviewed-on: https://chromium-review.googlesource.com/540131\nCommit-Ready: C Shapiro \u003cshapiroc@google.com\u003e\nTested-by: C Shapiro \u003cshapiroc@google.com\u003e\nReviewed-by: Simon Glass \u003csjg@chromium.org\u003e\nReviewed-by: Jason Clinton \u003cjclinton@chromium.org\u003e\n" } ], "next": "c8d08ca31313d9ef5f85d0614f00eb3e4494aa71" }