Revert "futility: Avoid unnecessary servo control command"
This reverts commit 8c30aaab650e9b099875568317cd1f8ac69ccd1d.
Reason for revert: This is very wrong. This will completely break Servo AP SPI flash reading on some boards and setups, and may be electrically unsafe on others in some situations.
Original change's description:
> futility: Avoid unnecessary servo control command
>
> For flash read via servo, there's no need to toggle the servo control
> (such as "ccd_cpu_fw_spi" for CCD). In fact, toggling the control
> results in an unnecessary reboot.
>
> Add an argument to setup_flash() to decide whether to toggle the servo
> control.
>
> BUG=b:288218235
> TEST=sudo emerge vboot_reference
> TEST=make runtests
> BRANCH=none
>
> Change-Id: Ia02648f89d392a52c5d0c4b069623acfb1b4c9dd
> Signed-off-by: Yu-Ping Wu <yupingso@chromium.org>
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4655887
> Commit-Queue: Yidi Lin <yidilin@chromium.org>
> Reviewed-by: Yidi Lin <yidilin@chromium.org>
BUG=b:288218235
Change-Id: I5d2eedf733917eba076627a0fee2b96836b0789f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4661500
Commit-Queue: Matthew Blecker <matthewb@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Matthew Blecker <matthewb@chromium.org>
Tested-by: Matthew Blecker <matthewb@chromium.org>
Owners-Override: Brian Norris <briannorris@chromium.org>
5 files changed
