make_dev_ssd: Remove logic choosing editor value

Remove the logic to dynamically choose which editor to use. Instead,
assume $EDITOR always has a good value.

This also requires passing the |-E| argument to sudo, so the $EDITOR
system value is used, because it's undefined for sudo calls otherwise:

  '-E'
  The -E (preserve environment) option indicates to the security policy
  that the user wishes to preserve their existing environment variables.
  The security policy may return an error if the -E option is specified
  and the user does not have permission to preserve the environment.

BRANCH=none
BUG=b:264675318
TEST=/usr/share/vboot/bin/make_dev_ssd.sh --edit_config
- Test with both 'test' (w/ vim) and 'base' (w/out vim) builds

Cq-Depend: chromium:5421766
Change-Id: I553057e14cc5a50db240237055edaea391167a55
Signed-off-by: Tim Van Patten <timvp@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5313678
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
1 file changed