commit 3798bedfa672a7d24fde745aab1ed4f4806e993f
author Saleem Abdulrasool <compnerd@compnerd.org> Thu Feb 08 09:35:07 2018 -0800
committer GitHub <noreply@github.com> Thu Feb 08 09:35:07 2018 -0800
tree e3b020244b56004d30ae475cf7c2e2ef6a7d6017
parent fbaaa75537a1fef571d86061b9a2db17444698a2
parent b49d69f4b35593c846d01806237c9a78e048aa84

Merge pull request #14472 from compnerd/driver-break-return

Driver: avoid unnecessary break after return in switch

lib/Driver/Driver.cpp

diff --git a/lib/Driver/Driver.cpp b/lib/Driver/Driver.cpp
index 8fcfcce..e506ae4 100644
--- a/lib/Driver/Driver.cpp
+++ b/lib/Driver/Driver.cpp
@@ -212,23 +212,16 @@
   case llvm::Triple::TvOS:
   case llvm::Triple::WatchOS:
     return llvm::make_unique<toolchains::Darwin>(*this, target);
-    break;
   case llvm::Triple::Linux:
-    if (target.isAndroid()) {
+    if (target.isAndroid())
       return llvm::make_unique<toolchains::Android>(*this, target);
-    } else {
-      return llvm::make_unique<toolchains::GenericUnix>(*this, target);
-    }
-    break;
+    return llvm::make_unique<toolchains::GenericUnix>(*this, target);
   case llvm::Triple::FreeBSD:
     return llvm::make_unique<toolchains::GenericUnix>(*this, target);
-    break;
   case llvm::Triple::Win32:
     return llvm::make_unique<toolchains::Cygwin>(*this, target);
-    break;
   case llvm::Triple::Haiku:
     return llvm::make_unique<toolchains::GenericUnix>(*this, target);
-    break;
   default:
     Diags.diagnose(SourceLoc(), diag::error_unknown_target,
                    ArgList.getLastArg(options::OPT_target)->getValue());