tree 6281001eaf53423be05d3cc3a4788f35d2731539
parent 738a7fb3db8edaad1ac67db540a1300d575404e7
author Doug Gregor <dgregor@apple.com> 1510183515 -0800
committer Doug Gregor <dgregor@apple.com> 1510201363 -0800

[Clang importer] Move the "all properties" lists into the name importer.

Swift's ASTContext contained all of the logic to find the complete list
of properties for an Objective-C class, which is used by the Clang importer
to influence the mapping of Objective-C names into Swift. Swift's
ASTContext also included a *cache* for this information, indexed by
the Clang `ObjCInterfaceDecl *`. However, this cache was getting
populated/queried from the Clang importer's name importer, such that
the keys would be Clang declarations used to build modules and then
deallocated. If that memory eventually gets reused for a different
`ObjCInterfaceDecl *`, we would get incorrect/stale all-properties
information.

Almost Surely fixes rdar://problem/35347167, which is a
nondeterministic failure where UIView's `addGestureRecognizer(_:)` gets
occasionally imported as `add(_:)`.

(cherry picked from commit a49455e3b23d8f91580b6282a146e4a800ae5265)