tree ecfd66a6cdf1e21b570bf6b79b1468867e8191ba
parent e87bba908679071b0725ee8d73d3fbd0232742a2
author Slava Pestov <spestov@apple.com> 1496896781 -0700
committer Slava Pestov <spestov@apple.com> 1496897017 -0700

Sema: Targeted fix for bad interaction between resilience checks and -enable-testing

The -enable-testing flag makes ValueDecl::getEffectiveAccess()
say that internal declarations are public.

This would lead us to emit spurious diagnostics if a default
argument of an internal function referenced a private symbol,
for example, which is something we actually want to allow.

Hack around this by adding a new 'forLinkage' parameter to
getEffectiveAccess(). When this is false, we ignore the
-enable-testing flag, and only look for the @_versioned
attribute.

I'm not very happy with the fix, because it only compliates
the subtle behaviors of getFormalAccess(), getEffectiveAccess()
and getFormalAccessScope() further. But refactoring this is
a bigger change than I'm willing to put into swift-4.0-branch.

Fixes <rdar://problem/32592973>.