)]}' { "commit": "57ae6cfe01b811aaead80872ed9e5e1d30f35f81", "tree": "12dd094a0ba392e374f906cb62426df5d5213d60", "parents": [ "d6010879c6271b66acd4498e892a24de0ffaf15e" ], "author": { "name": "Brian Osman", "email": "brianosman@google.com", "time": "Tue Nov 15 18:07:26 2016 +0000" }, "committer": { "name": "Skia Commit-Bot", "email": "skia-commit-bot@chromium.org", "time": "Tue Nov 15 18:07:40 2016 +0000" }, "message": "Revert \"Support decoding images to multiple formats, depending on usage\"\n\nThis reverts commit c73a1ecbed64652b3d7aa8dc6face9a2205ce830.\n\nReason for revert: ANGLE and CommandBuffer failures\n\nOriginal change\u0027s description:\n\u003e Support decoding images to multiple formats, depending on usage\n\u003e \n\u003e Our codec generator will now preserve any asked-for color space, and\n\u003e convert the encoded data to that representation. Cacherator now\n\u003e allows decoding an image to both legacy (nullptr color space), and\n\u003e color-correct formats. In color-correct mode, we choose the best\n\u003e decoded format, based on the original properties, and our backend\u0027s\n\u003e capabilities. Preference is given to the native format, when it\u0027s\n\u003e already texturable (sRGB 8888 or F16 linear). Otherwise, we prefer\n\u003e linear F16, and fall back to sRGB when that\u0027s not an option.\n\u003e \n\u003e BUG\u003dskia:5907\n\u003e \n\u003e GOLD_TRYBOT_URL\u003d https://gold.skia.org/search?issue\u003d4438\n\u003e \n\u003e Change-Id: I847c243dcfb72d8c0f1f6fc73c09547adea933f0\n\u003e Reviewed-on: https://skia-review.googlesource.com/4438\n\u003e Reviewed-by: Matt Sarett \u003cmsarett@google.com\u003e\n\u003e Commit-Queue: Brian Osman \u003cbrianosman@google.com\u003e\n\u003e \n\nTBR\u003dmtklein@google.com,bsalomon@google.com,msarett@google.com,brianosman@google.com,reed@google.com\nNOPRESUBMIT\u003dtrue\nNOTREECHECKS\u003dtrue\nNOTRY\u003dtrue\n\nChange-Id: I1818f937464573d601f64e5a1f1eb43f5a778f4e\nReviewed-on: https://skia-review.googlesource.com/4832\nCommit-Queue: Brian Osman \u003cbrianosman@google.com\u003e\nReviewed-by: Brian Osman \u003cbrianosman@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "b5827ef03bc9c5f7ff2bffc39632ab0b3d1b28ef", "old_mode": 33188, "old_path": "bench/SkBlend_optsBench.cpp", "new_id": "6a4593e664bfb781e77c567f1b03547f1a0e3e76", "new_mode": 33188, "new_path": "bench/SkBlend_optsBench.cpp" }, { "type": "modify", "old_id": "53f83ac4c2968018ee551df6b5284ec4364a1111", "old_mode": 33188, "old_path": "gm/image_pict.cpp", "new_id": "903024b8ee364b63e3b3b808cecc8a6ab3492944", "new_mode": 33188, "new_path": "gm/image_pict.cpp" }, { "type": "modify", "old_id": "9f85971f898025943e1afdc3938f33c4bb4b51d7", "old_mode": 33188, "old_path": "src/codec/SkCodecImageGenerator.cpp", "new_id": "8108f0de441c64744faf5f6ffe9626798c027356", "new_mode": 33188, "new_path": "src/codec/SkCodecImageGenerator.cpp" }, { "type": "modify", "old_id": "1e618accb0e0d03afddb61acbb3275af0de73869", "old_mode": 33188, "old_path": "src/core/SkBitmapDevice.cpp", "new_id": "e44b76926ad07a2fdb39f2776b92051b1421c225", "new_mode": 33188, "new_path": "src/core/SkBitmapDevice.cpp" }, { "type": "modify", "old_id": "0951393b736f237cb738551ede17da6a57021d23", "old_mode": 33188, "old_path": "src/core/SkBitmapProvider.cpp", "new_id": "8347d32d7f659dbf6df404863da5653fa1e7e7cb", "new_mode": 33188, "new_path": "src/core/SkBitmapProvider.cpp" }, { "type": "modify", "old_id": "9cbbf0d470ec7ddf47bb2285454cf8690cb31fcb", "old_mode": 33188, "old_path": "src/core/SkBitmapProvider.h", "new_id": "2e878b18ab14737640634fcc95ec080457d651ec", "new_mode": 33188, "new_path": "src/core/SkBitmapProvider.h" }, { "type": "modify", "old_id": "5f0ecb99c64bf152cf1074bd118005a5507ef03e", "old_mode": 33188, "old_path": "src/core/SkDevice.cpp", "new_id": "b2ff2423ed75ca70bd2f51cb4402832db206462a", "new_mode": 33188, "new_path": "src/core/SkDevice.cpp" }, { "type": "modify", "old_id": "d6f816e8eff026c3f24dcb1f9757475b7e39fa7e", "old_mode": 33188, "old_path": "src/core/SkImageCacherator.cpp", "new_id": "54045d5821367a8de692fa44d6ba44f865f6d3a4", "new_mode": 33188, "new_path": "src/core/SkImageCacherator.cpp" }, { "type": "modify", "old_id": "fc03e8e5e931e719b20f096fe0493876eb43529b", "old_mode": 33188, "old_path": "src/core/SkImageCacherator.h", "new_id": "a8a05a1f90b0adbfc6f7d433a83b098f9506b13a", "new_mode": 33188, "new_path": "src/core/SkImageCacherator.h" }, { "type": "modify", "old_id": "2c96626d1d8b58dd37aa51afaca728e33d1f95f3", "old_mode": 33188, "old_path": "src/core/SkSpecialImage.cpp", "new_id": "f18878175b77e6383b5cea4d1686d802615db496", "new_mode": 33188, "new_path": "src/core/SkSpecialImage.cpp" }, { "type": "modify", "old_id": "c6afa1d0c7927f108209cb4602a2c8f1027fca54", "old_mode": 33188, "old_path": "src/core/SkSpecialImage.h", "new_id": "12847df115edab64b54aaf8948d2fa1f270e4ff2", "new_mode": 33188, "new_path": "src/core/SkSpecialImage.h" }, { "type": "modify", "old_id": "de849416c8c619e7770e94f2be7ded4cde73b429", "old_mode": 33188, "old_path": "src/effects/SkImageSource.cpp", "new_id": "f96a4a16769b04e27f6032fa4a0f362313ae8138", "new_mode": 33188, "new_path": "src/effects/SkImageSource.cpp" }, { "type": "modify", "old_id": "79df90f4d3eacd0900b52633349bfb884e52ec05", "old_mode": 33188, "old_path": "src/gpu/SkGpuDevice.cpp", "new_id": "1fbc953b6515f4873fbd2b0c0b987927f82ad9cb", "new_mode": 33188, "new_path": "src/gpu/SkGpuDevice.cpp" }, { "type": "modify", "old_id": "f976242eca0086c037c2f4f333136ea3a69199ad", "old_mode": 33188, "old_path": "src/image/SkImage.cpp", "new_id": "4d76638cbd327850e1f43beccf56a848d40261dd", "new_mode": 33188, "new_path": "src/image/SkImage.cpp" }, { "type": "modify", "old_id": "04babb8ec21ccd1c86366f463c1cb42910594f87", "old_mode": 33188, "old_path": "src/image/SkImageShader.cpp", "new_id": "eed817554e42c39db9fc4ecedc18af3ef6b80805", "new_mode": 33188, "new_path": "src/image/SkImageShader.cpp" }, { "type": "modify", "old_id": "94bf783ed43d03363f70bc2cde597b83f4db7949", "old_mode": 33188, "old_path": "src/image/SkImage_Base.h", "new_id": "7fbe97deac1901b1aba05c19eb6128137683d219", "new_mode": 33188, "new_path": "src/image/SkImage_Base.h" }, { "type": "modify", "old_id": "43d26d00836cd2fbd7176b5678665d066f72dbce", "old_mode": 33188, "old_path": "src/image/SkImage_Generator.cpp", "new_id": "03dda91e5ea52d1d4b1c017978b68d7cd6a5c09a", "new_mode": 33188, "new_path": "src/image/SkImage_Generator.cpp" }, { "type": "modify", "old_id": "0bcfbd2294116c9b831814153c6a83f7445278f8", "old_mode": 33188, "old_path": "src/image/SkImage_Gpu.cpp", "new_id": "a006e14ecf12ed5923416cedc75d9ba67eda782a", "new_mode": 33188, "new_path": "src/image/SkImage_Gpu.cpp" }, { "type": "modify", "old_id": "fbcddf8f1afc2018418a3f11c0696fbad6951c33", "old_mode": 33188, "old_path": "src/image/SkImage_Gpu.h", "new_id": "13c1e306dc93b95b66ac4611733a90371354f547", "new_mode": 33188, "new_path": "src/image/SkImage_Gpu.h" }, { "type": "modify", "old_id": "149d0a6f655fbea83e73f19eb42e9b51fb5a7fd0", "old_mode": 33188, "old_path": "src/image/SkImage_Raster.cpp", "new_id": "be86a2a6efdf1c49a33a3337ee948579d1f72f4d", "new_mode": 33188, "new_path": "src/image/SkImage_Raster.cpp" }, { "type": "modify", "old_id": "ea6887ac80d784df7a86c7f88865490a7eec0dbd", "old_mode": 33188, "old_path": "src/pdf/SkPDFBitmap.cpp", "new_id": "2d789d04d8dca92891e439d0bb22be661d21f1e0", "new_mode": 33188, "new_path": "src/pdf/SkPDFBitmap.cpp" }, { "type": "modify", "old_id": "9a70f68c31dfcf5744b5b201fe736942d349ec8c", "old_mode": 33188, "old_path": "src/pdf/SkPDFDevice.cpp", "new_id": "a04b38000564fbd685a857b853ecabd86a5335e2", "new_mode": 33188, "new_path": "src/pdf/SkPDFDevice.cpp" }, { "type": "modify", "old_id": "e3a652b06b482db3c6a2d70a2d2f1d88d5feccf7", "old_mode": 33188, "old_path": "tests/ImageFilterCacheTest.cpp", "new_id": "ebd3186e01b0a6904382bcb1dbc40935d11217ec", "new_mode": 33188, "new_path": "tests/ImageFilterCacheTest.cpp" }, { "type": "modify", "old_id": "2ae179c6a9a193954c88fce3d058195bc3fa4d31", "old_mode": 33188, "old_path": "tests/SkBlend_optsTest.cpp", "new_id": "e6813748522640a03164c4a89fa19061c062fbcf", "new_mode": 33188, "new_path": "tests/SkBlend_optsTest.cpp" }, { "type": "modify", "old_id": "8cd874a3c8ca2cb16ff8786efa0bfd2565becef1", "old_mode": 33188, "old_path": "tests/SpecialImageTest.cpp", "new_id": "62a5da60894c73a24bb345fb759b8f9730004509", "new_mode": 33188, "new_path": "tests/SpecialImageTest.cpp" }, { "type": "modify", "old_id": "981bfba337381dc88c2b8ee7274d21d8ef7d4131", "old_mode": 33188, "old_path": "tools/Resources.cpp", "new_id": "3a9bb58c4e149c8a63581ba93fd7cb7c7cafd2d4", "new_mode": 33188, "new_path": "tools/Resources.cpp" } ] }