tree 44d55113eb68056819fea39c5f80d782da3504bd
parent 219f6e2bef92f5739c97eada4b844525e244a8fc
author Sam Lantinga <slouken@libsdl.org> 1475344344 -0700
committer Sam Lantinga <slouken@libsdl.org> 1475344344 -0700

Fixed bug 3362 - OpenGL renderer doesn't check if framebuffers are supported when creating target textures

Simon Hug

The GL_CreateTexture function doesn't have any checks for the case where the driver doesn't support the framebuffer object extension. It will call into GL_GetFBO which will call the non-existent glGenFramebuffersEXT.

Also, for some reason GL_CreateContext always sets the SDL_RENDERER_TARGETTEXTURE info flag, even if it is not supported. Changeset 6e6bd53feff0 [1] makes this change, but doesn't explain why. It seems to me like the code would already have taken care of this [2].

The attached patch adds some checks and stops SDL from reporting render target support if there is none. The application can then properly inform the user instead of just crashing.