tree acec1fa92b347dd5d7f92dd7db5f64fc58b1c64b
parent df1b5d3cc2117f1ee96abca25678bc5f5604d450
author bors <bors@rust-lang.org> 1728551840 +0000
committer Philipp Krones <hello@philkrones.com> 1728552853 +0200
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQIzBAABCAAdFiEEij1UXJ/PQTcb99vTHKDfKvWdaKUFAmcHn5UACgkQHKDfKvWd
 aKVxZA/6AoCkyh+D/UwOMVXYN8EP0J3nhrB34ThMio16TqeNheVTV2PyEmIWlf8W
 75IB9eUrT+fR7XZtaoNKC373XjGAIuhgcN8kP9N6W7CW6q9pdrAquR/H3bJs5XqS
 HEvC9v4fTURU4Cr2uwXJiMHMJZoIuJgHAsE4LZYWEwCxK7H6a9IW1jskkCPEjR5+
 LmqH8w1EW+O8DIEP0sh7D2vQ8SFdbNosblElIQOEOM16qWSqMYHlw9agXHwvZjXZ
 Bpt2e6aV9BHr3hYpKSgB7HvxTVqxzYMyykXVGPpvn6v8LwceWR4Vx5OFUmbjE/Jb
 JOp68O7fv1p8bXCrmXxZIgxba2s5aLpijwU4Z6MepR8kaMOeGg7Xeo9ZRRayVVFl
 cX3w/GkoOZcD5i1zMa9wMJ243k4a7Jrc2BCtQxEq06aQhCBVfBUpCBk8NLpJ1SC1
 Ey1FdCUACd0n5WJlykaNRkI6pSEpXCEaArGBbilBZ2YmECyjEwO3iN3oH8zSDdFn
 FN5JiPccgntP3jb8F5BguNRHVvLD7jpcaPk1G0x/gNpnR++YdeZ+YTmDMyumQ1QG
 2S87hfWaZMgIxGO8IcMMgEufUp2iejmvohg4hmAs8583wGDPolJsV0FUJgcd2bXK
 fXSDkMRS/6H4xu0dy4PGXjrPEBGKVJ/w1HRT9fWVrcKD2bvot3c=
 =5vlt
 -----END PGP SIGNATURE-----

Auto merge of #13464 - y21:issue13458, r=flip1995

Don't warn on proc macro generated code in `needless_return`

Fixes #13458
Fixes #13457
Fixes #13467
Fixes #13479
Fixes #13481
Fixes #13526
Fixes #13486

The fix is unfortunately a little more convoluted than just simply adding a `is_from_proc_macro`. That check *does*  fix the issue, however it also introduces a bunch of false negatives in the tests, specifically when the returned expression is in a different syntax context, e.g. `return format!(..)`.

The proc macro check builds up a start and end pattern based on the HIR nodes and compares it to a snippet of the span, however that would currently fail for `return format!(..)` because we would have the patterns `("return", <something inside of the format macro>)`, which doesn't compare equal. So we now return an empty string pattern for when it's in a different syntax context.

"Hide whitespace" helps a bit for reviewing the proc macro detection change

changelog: none