tree 9d6ff0b427b1f35f34e3b5877b702a061f347cd9
parent 38650b69cafbff61d71a275ced1e9866a08a36c0
author Felix S. Klock II <pnkfelix@pnkfx.org> 1548161490 +0100
committer Felix S. Klock II <pnkfelix@pnkfx.org> 1548164713 +0100

Do not initiate nested probe within `assemble_probe`.

In particular, the table entries (associated with type-variables
created during the probe) must persist as long as the candidates
assembled during the probe. If you make a nested probe without
creating a nested `ProbeContext`, the table entries are popped at the
end of the nested probe, while the type-variables would leak out via
the assembled candidates attached to `self` (the outer
`ProbeContext`). This causes an ICE (*if you are lucky*)!