commit 79058918553a825cfa2e29ae26ed2580743949c1
author Erick Tryzelaar <etryzelaar@google.com> Thu Jul 26 09:53:34 2018 -0700
committer Erick Tryzelaar <etryzelaar@google.com> Thu Jul 26 09:53:34 2018 -0700
tree e4cc761066b20f75cb4c0dfcc2d623f7d49c1577
parent d6bb132ad3eb85e0426036f91526698fc61f99dd

Remove duplicate code when creating client

This block of code is either redundant, or was supposed to
fetch the metadata from the remote server if it wasn't present
locally. The documentation suggests that it will only try
loading from the local server, so I erred on just removing
this chunk of code, rather than doing the less-safe thing
of downloading the initial metadata from an unverified
server.

src/client.rs

diff --git a/src/client.rs b/src/client.rs
index 5a9cb85..8d965ed 100644
--- a/src/client.rs
+++ b/src/client.rs
@@ -141,16 +141,7 @@
                 &config.max_root_size,
                 config.min_bytes_per_second,
                 None,
-            )
-            .or_else(|_| {
-                local.fetch_metadata(
-                    &MetadataPath::from_role(&Role::Root),
-                    &MetadataVersion::Number(1),
-                    &config.max_root_size,
-                    config.min_bytes_per_second,
-                    None,
-                )
-            })?;
+            )?;
 
         let tuf = Tuf::from_root(&root)?;