tree f60a1e859cdad69a2d336777c5aa90fddcd073d5
parent 3b17bd2df301d06bdea612a820cd6aa28b5c0cdd
author Drew Fisher <zarvox@google.com> 1594981630 -0700
committer Drew Fisher <zarvox@google.com> 1607563485 +0000

[UBSan][roughtime] Fix unaligned reads, reenable UBSan

It is undefined behavior to attempt to dereference an unaligned pointer,
which is very easy to do any time you reinterpret_cast a pointer that
you obtained by parsing some bytes that aren't guaranteed to be aligned.

The canonical answer is to use memcpy to copy the bytes into an aligned
structure, and to use that aligned structure.  Here, we already have the
intended out pointer, so we can simply perform the bytewise copy.

Test: fx test network-time-service-tests
Fixed: 47040
Change-Id: I39b98804261fff4e76c064c5b8bf9e6fa88f3bbb
Reviewed-on: https://fuchsia-review.googlesource.com/c/third_party/roughtime/+/460140
Reviewed-by: Jody Sankey <jsankey@google.com>