commit e9377c8373b34dca1f9655b2444adf52bcd32cb6
author Joe Tsai <joetsai@digital-static.net> Fri Jul 21 01:17:22 2023 -0700
committer Joe Tsai <joetsai@digital-static.net> Wed Aug 09 16:35:43 2023 -0700
tree 13f8a5993abbd01665b76384c81a1ea9fe8b8993
parent ec1c8caca60e03e3816cadfaad20a0fd384a2a5e

Properly handle io.EOF error conditions when reading

Previously, the Server.Serve method would never return nil,
because the infinite for-loop handling request packets would
only break if reading a packet reported an error.
A common termination condition is when the underlying connection
is closed and recvPacket returns io.EOF.
In which case Serve should ignore io.EOF and
treat it as a normal shutdown.

However, this means that recvPacket must correctly handle io.EOF
such that it never reports io.EOF if a packet is partially read.
There are two calls to io.ReadFull in recvPacket.
The first call correctly forwards an io.EOF error
if no additional bytes of the next packet are read.
However, the second call incorrectly forwards io.EOF
when no bytes of the payload could be read.
This is incorrect since we already read the length and
should convert the io.EOF into an io.ErrUnexpectedEOF.