Google Git
Sign in
fuchsia / third_party / pkg / sftp / 737aa1dc61e93af5e18282c7bc6e34e22ee7dfa6
commit737aa1dc61e93af5e18282c7bc6e34e22ee7dfa6[log] [tgz]
authorJohn Eikenberry <jae@zhar.net>Thu Jun 29 11:27:52 2017 -0700
committerJohn Eikenberry <jae@zhar.net>Thu Jun 29 11:27:52 2017 -0700
treeee701ad59802e802e1135e1be1c798c779dbcaf4
parentca043ca452cac768d3b7bab7140076218dad0445 [diff]
Fixes #181: client deadlock on server death

The client was deadlocking if you killed the server when a file transfer
was occuring. The problem occured when you had many requests sent and
were waiting on responses when the server dies. The errors for all those
pending requests get sent along the response channel which is also used
for the errors reported by the new requests being made. The new request
channel send is in the same loop as the channel reading, so when it
blocked due to all other errors filling the channel it deadlocked the
program.

There were 2 possible fixes, changing the new request error channel
usage to be in a separate goroutine to keep it from blocking the loop or
to increase the size of the buffer to handle all the errors. This
implements the latter.

Included is a test that reproduces the problem most of the time. Due to
the required timing of the issue, it was impossible to reproduce 100% of
the time.
2 files changed
tree: ee701ad59802e802e1135e1be1c798c779dbcaf4
  1. examples/
  2. server_standalone/
  3. .gitignore
  4. .travis.yml
  5. attrs.go
  6. attrs_stubs.go
  7. attrs_test.go
  8. attrs_unix.go
  9. client.go
  10. client_integration_darwin_test.go
  11. client_integration_linux_test.go
  12. client_integration_test.go
  13. client_test.go
  14. conn.go
  15. CONTRIBUTORS
  16. debug.go
  17. example_test.go
  18. LICENSE
  19. match.go
  20. other_test.go
  21. packet-manager.go
  22. packet-manager_go1.8.go
  23. packet-manager_legacy.go
  24. packet-manager_test.go
  25. packet-typing.go
  26. packet.go
  27. packet_test.go
  28. README.md
  29. release.go
  30. request-example.go
  31. request-interfaces.go
  32. request-readme.md
  33. request-server.go
  34. request-server_test.go
  35. request-unix.go
  36. request.go
  37. request_test.go
  38. request_windows.go
  39. server.go
  40. server_integration_test.go
  41. server_statvfs_darwin.go
  42. server_statvfs_impl.go
  43. server_statvfs_linux.go
  44. server_statvfs_stubs.go
  45. server_stubs.go
  46. server_test.go
  47. server_unix.go
  48. sftp.go
README.md

sftp

The sftp package provides support for file system operations on remote ssh servers using the SFTP subsystem. It also implements an SFTP server for serving files from the filesystem.

UNIX Build Status GoDoc

usage and examples

See godoc.org/github.com/pkg/sftp for examples and usage.

The basic operation of the package mirrors the facilities of the os package.

The Walker interface for directory traversal is heavily inspired by Keith Rarick's fs package.

roadmap

  • There is way too much duplication in the Client methods. If there was an unmarshal(interface{}) method this would reduce a heap of the duplication.

contributing

We welcome pull requests, bug fixes and issue reports.

Before proposing a large change, first please discuss your change by raising an issue.

For API/code bugs, please include a small, self contained code example to reproduce the issue. For pull requests, remember test coverage.

We try to handle issues and pull requests with a 0 open philosophy. That means we will try to address the submission as soon as possible and will work toward a resolution. If progress can no longer be made (eg. unreproducible bug) or stops (eg. unresponsive submitter), we will close the bug.

Thanks.