tree abfdc55388087bf35d9ed1d843ee0ba76de2bb47
parent 61377cba376de66048884cde8d81e537e9c10e48
author Filip Filmar <fmil@google.com> 1608069396 -0800
committer CQ Bot <commit-bot@chromium.org> 1610481373 +0000

[openssh] Fixes ASAN memory leak errors

Fixes the two memory leak errors that ASAN found in openssh-portable:

- one, a global variable is never freed.  Handled by registering an
  atexit().

- two, a local array took ownership of a pointer to a string that is
  then never freed.  Handled by registering a cleanup attribute, because
  there are multiple return paths from the function, and this change is
  made locally so we know our compiler supports the cleanup approach.

Hopefully this makes ASAN happier.

The fix is made in our fork of openssh-portable because:

- The local variable fix is compiler-dependent, so may not be applicable
  in general to the upstream.

- Upstream seems to not care about issues like these, otherwise they'd
  have long handled it.

Bug: 56434
Change-Id: I3139279fe9c8fde2e146561b47b632af52916bdb
Reviewed-on: https://fuchsia-review.googlesource.com/c/third_party/openssh-portable/+/462755
Reviewed-by: George Kulakowski <kulakowski@google.com>
Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>
Fuchsia-Auto-Submit: Filip Filmar <fmil@google.com>