| commit | 8bdf725c5d1369515d1236e830ecee16b068720a | [log] [tgz] |
|---|---|---|
| author | Filip Filmar <fmil@google.com> | Tue Dec 15 13:56:36 2020 -0800 |
| committer | CQ Bot <commit-bot@chromium.org> | Tue Jan 12 19:56:13 2021 +0000 |
| tree | abfdc55388087bf35d9ed1d843ee0ba76de2bb47 | |
| parent | 61377cba376de66048884cde8d81e537e9c10e48 [diff] |
[openssh] Fixes ASAN memory leak errors Fixes the two memory leak errors that ASAN found in openssh-portable: - one, a global variable is never freed. Handled by registering an atexit(). - two, a local array took ownership of a pointer to a string that is then never freed. Handled by registering a cleanup attribute, because there are multiple return paths from the function, and this change is made locally so we know our compiler supports the cleanup approach. Hopefully this makes ASAN happier. The fix is made in our fork of openssh-portable because: - The local variable fix is compiler-dependent, so may not be applicable in general to the upstream. - Upstream seems to not care about issues like these, otherwise they'd have long handled it. Bug: 56434 Change-Id: I3139279fe9c8fde2e146561b47b632af52916bdb Reviewed-on: https://fuchsia-review.googlesource.com/c/third_party/openssh-portable/+/462755 Reviewed-by: George Kulakowski <kulakowski@google.com> Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com> Fuchsia-Auto-Submit: Filip Filmar <fmil@google.com>
OpenSSH is a complete implementation of the SSH protocol (version 2) for secure remote login, command execution and file transfer. It includes a client ssh and server sshd, file transfer utilities scp and sftp as well as tools for key generation (ssh-keygen), run-time key storage (ssh-agent) and a number of supporting programs.
This is a port of OpenBSD's OpenSSH to most Unix-like operating systems, including Linux, OS X and Cygwin. Portable OpenSSH polyfills OpenBSD APIs that are not available elsewhere, adds sshd sandboxing for more operating systems and includes support for OS-native authentication and auditing (e.g. using PAM).
The official documentation for OpenSSH are the man pages for each tool:
Stable release tarballs are available from a number of download mirrors. We recommend the use of a stable release for most users. Please read the release notes for details of recent changes and potential incompatibilities.
Portable OpenSSH is built using autoconf and make. It requires a working C compiler, standard library and headers, and zlib. libcrypto from either LibreSSL or OpenSSL may also be used, but OpenSSH may be built without it supporting a subset of crypto algorithms.
FIDO security token support need libfido2 and its dependencies. Also, certain platforms and build-time options may require additional dependencies, see README.platform for details.
Releases include a pre-built copy of the configure script and may be built using:
tar zxvf openssh-X.YpZ.tar.gz cd openssh ./configure # [options] make && make tests
See the Build-time Customisation section below for configure options. If you plan on installing OpenSSH to your system, then you will usually want to specify destination paths.
If building from git, you'll need autoconf installed to build the configure script. The following commands will check out and build portable OpenSSH from git:
git clone https://github.com/openssh/openssh-portable # or https://anongit.mindrot.org/openssh.git cd openssh-portable autoreconf ./configure make && make tests
There are many build-time customisation options available. All Autoconf destination path flags (e.g. --prefix) are supported (and are usually required if you want to install OpenSSH).
For a full list of available flags, run configure --help but a few of the more frequently-used ones are described below. Some of these flags will require additional libraries and/or headers be installed.
| Flag | Meaning |
|---|---|
--with-pam | Enable PAM support. OpenPAM, Linux PAM and Solaris PAM are supported. |
--with-libedit | Enable libedit support for sftp. |
--with-kerberos5 | Enable Kerberos/GSSAPI support. Both Heimdal and MIT Kerberos implementations are supported. |
--with-selinux | Enable SELinux support. |
--with-security-key-builtin | Include built-in support for U2F/FIDO2 security keys. This requires libfido2 be installed. |
Portable OpenSSH development is discussed on the openssh-unix-dev mailing list (archive mirror). Bugs and feature requests are tracked on our Bugzilla.
Non-security bugs may be reported to the developers via Bugzilla or via the mailing list above. Security bugs should be reported to openssh@openssh.com.