tree 43d59cfb4b0c638e428ebfc747109359cf42528f
parent c2198e9d8fc6545224b20bb2b3598048d3a7ab15
author James Tucker <raggi@google.com> 1610053913 +0000
committer CQ Bot <commit-bot@chromium.org> 1610058247 +0000

Revert "[config] turn off in-protocol keepalives"

This reverts commit fcb26e787893be1e348290148301e5a7a50c25b1.

Reason for revert: TCPKeepAlive appears to not work in the case where we're using USB-CDC and the target system reboots, the ssh master never notices, and new channels just hang forever never making forward progress.

Original change's description:
> [config] turn off in-protocol keepalives
>
> We're mostly using and relying on TCPKeepAlive now. Turning off the
> in-protocol keepalives significantly reduces otherwise idle network
> noise.
>
> Change-Id: I09d89864363476a0a4d1c415b57c13542a15414d
> Reviewed-on: https://fuchsia-review.googlesource.com/c/third_party/openssh-portable/+/449135
> Fuchsia-Auto-Submit: James Tucker <raggi@google.com>
> Reviewed-by: Erick Tryzelaar <etryzelaar@google.com>
> Reviewed-by: Tamir Duberstein <tamird@google.com>
> Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>

TBR=raggi@google.com,etryzelaar@google.com,tamird@google.com,olivernewman@google.com,auto-submit@fuchsia-infra.iam.gserviceaccount.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Id14346d28307f9d6207a931ae9af5cbcec20b8ab
Reviewed-on: https://fuchsia-review.googlesource.com/c/third_party/openssh-portable/+/468496
Reviewed-by: James Tucker <raggi@google.com>
Commit-Queue: James Tucker <raggi@google.com>