android: Don’t set _FILE_OFFSET_BITS, it never worked off_t is normally 32 bits on 32-bit platforms. It’s customary to set _FILE_OFFSET_BITS to 64 to get a 64-bit off_t on these platforms, but this was traditionally never effective in the Android NDK, so the macro was being set without effect. That’s changed with “unified headers,” but choosing a 64-bit off_t results in certain functions without historical 64-bit off_t support becoming unavailable below a certain API level. For example, mmap() and sendfile() aren’t available with a 64-bit off_t until API 21. 64-bit platforms always get a 64-bit off_t, and this macro is unnecessary. Bug: crashpad:30 Test: build for a 32-bit platform using API 16 and unified headers Change-Id: Ib4e422c480c5360afbb5638427150a029bdc052c Reviewed-on: https://chromium-review.googlesource.com/478371 Reviewed-by: Joshua Peraza <jperaza@chromium.org>
This is mini_chromium, a small collection of useful low-level (“base”) routines from the Chromium open-source project. Chromium is large, sprawling, full of dependencies, and a web browser. mini_chromium is small, self-contained, and a library. mini_chromium is especially useful as a dependency of other code that wishes to use Chromium’s base routines. By using mini_chromium, other projects’ code can function in a standalone environment outside of Chromium without having to treat all of Chromium as a dependency. When building as part of Chromium, those projects’ code can use Chromium’s own (non-mini_chromium) base implementation.
Code provided in mini_chromium provides the same interface as the equivalent code in Chromium.
While it’s a goal of mini_chromium to maintain interface compatibility with Chromium’s base library for the interfaces it does implement, there’s no requirement that it use the same implementations as Chromium’s base library. Many of the implementations used in mini_chromium are identical to Chromium’s, but many others have been modified to eliminate dependencies that are not desired in mini_chromium, and a few are completely distinct from Chromium’s altogether. Additionally, when mini_chromium provides an interface in the form of a file or class present in Chromium, it’s not bound to provide all functions, methods, or types that the Chromium equivalent does. The differences noted above notwithstanding, the interfaces exposed by mini_chromium’s base are and must remain a strict subset of Chromium’s.
Crashpad is the chief consumer of mini_chromium.
Mark Mentovai
mark@chromium.org