win: Don’t define c16*() functions in base/strings/string16.{cc,h}

Chromium never provided these, and mini_chromium needs to be
interface-compatible with Chromium. These functions were accidentally
defined on Windows in 463f840d61d1.

Change-Id: I942b16733396067d4b2c5e799558ac14475eb939
Reviewed-on: https://chromium-review.googlesource.com/737557
Reviewed-by: Nico Weber <thakis@chromium.org>
2 files changed
tree: e54bdc4e6f893404e436bc6631b6ae27e777518e
  1. base/
  2. build/
  3. .gitignore
  4. .gn
  5. AUTHORS
  6. BUILD.gn
  7. codereview.settings
  8. LICENSE
  9. mini_chromium.gyp
  10. README.md
README.md

mini_chromium

This is mini_chromium, a small collection of useful low-level (“base”) routines from the Chromium open-source project. Chromium is large, sprawling, full of dependencies, and a web browser. mini_chromium is small, self-contained, and a library. mini_chromium is especially useful as a dependency of other code that wishes to use Chromium’s base routines. By using mini_chromium, other projects’ code can function in a standalone environment outside of Chromium without having to treat all of Chromium as a dependency. When building as part of Chromium, those projects’ code can use Chromium’s own (non-mini_chromium) base implementation.

Code provided in mini_chromium provides the same interface as the equivalent code in Chromium.

While it’s a goal of mini_chromium to maintain interface compatibility with Chromium’s base library for the interfaces it does implement, there’s no requirement that it use the same implementations as Chromium’s base library. Many of the implementations used in mini_chromium are identical to Chromium’s, but many others have been modified to eliminate dependencies that are not desired in mini_chromium, and a few are completely distinct from Chromium’s altogether. Additionally, when mini_chromium provides an interface in the form of a file or class present in Chromium, it’s not bound to provide all functions, methods, or types that the Chromium equivalent does. The differences noted above notwithstanding, the interfaces exposed by mini_chromium’s base are and must remain a strict subset of Chromium’s.

Crashpad is the chief consumer of mini_chromium.

Mark Mentovai
mark@chromium.org