commit 4fb8fd4cbc5975baaa3139b6db6c1c5d0cc5b585
author Matt Arsenault <Matthew.Arsenault@amd.com> Wed Feb 26 23:53:44 2025 +0700
committer Matt Arsenault <arsenm2@gmail.com> Wed Feb 26 23:56:37 2025 +0700
tree 04f8ac5cc10e4f4302147f63a8ee8c74aa3df4b8
parent 81d263d55831cc4c2363a5b2cd8c5272f01c302b

Use yet another allocator for LiveRanges

Not sure it's worth it for these, there should never be all that
many. We could pre-allocate the maximum size up front.

llvm/include/llvm/CodeGen/LiveIntervals.h

diff --git a/llvm/include/llvm/CodeGen/LiveIntervals.h b/llvm/include/llvm/CodeGen/LiveIntervals.h
index 7cee939..4a4d53e 100644
--- a/llvm/include/llvm/CodeGen/LiveIntervals.h
+++ b/llvm/include/llvm/CodeGen/LiveIntervals.h
@@ -65,12 +65,15 @@
   MachineDominatorTree *DomTree = nullptr;
   std::unique_ptr<LiveIntervalCalc> LICalc;
 
-  // Allocator for RegUnitRanges and SubRanges.
+  // Allocator for SubRanges.
   BumpPtrAllocator Allocator;
 
   // Allocator for VirtRegIntervals
   SpecificBumpPtrAllocator<LiveInterval> LIAllocator;
 
+  // Allocator for RegUnitRanges
+  SpecificBumpPtrAllocator<LiveRange> LRAllocator;
+
   /// Special pool allocator for VNInfo's (LiveInterval val#).
   VNInfo::Allocator VNInfoAllocator;
 
@@ -423,8 +426,8 @@
     if (!LR) {
       // Compute missing ranges on demand.
       // Use segment set to speed-up initial computation of the live range.
-      RegUnitRanges[Unit] = LR = new (Allocator.Allocate<LiveRange>())
-          LiveRange(UseSegmentSetForPhysRegs);
+      RegUnitRanges[Unit] = LR =
+          new (LRAllocator.Allocate()) LiveRange(UseSegmentSetForPhysRegs);
       computeRegUnitRange(*LR, Unit);
     }
     return *LR;

llvm/lib/CodeGen/LiveIntervals.cpp

diff --git a/llvm/lib/CodeGen/LiveIntervals.cpp b/llvm/lib/CodeGen/LiveIntervals.cpp
index fd5cc38..2b46e4e 100644
--- a/llvm/lib/CodeGen/LiveIntervals.cpp
+++ b/llvm/lib/CodeGen/LiveIntervals.cpp
@@ -146,8 +146,7 @@
   RegMaskBits.clear();
   RegMaskBlocks.clear();
 
-  for (LiveRange *LR : RegUnitRanges)
-    Allocator.Deallocate(LR);
+  LRAllocator.DestroyAll();
   RegUnitRanges.clear();
 
   // Free the live intervals themselves.