tree 4102eb2c854975285884d5eb57ff5eefc6d5c0fb
parent 93f281d789db9a99dd566e5c00e417e1efbba845
author Louis Dionne <ldionne@apple.com> 1544132777 +0000
committer Louis Dionne <ldionne@apple.com> 1544132777 +0000

[libc++] Improve diagnostics for non-const comparators and hashers in associative containers

Summary:
When providing a non-const-callable comparator in a map or set, the
warning diagnostic does not include the point of instantiation of
the container that triggered the warning, which makes it difficult
to track down the problem. This commit improves the diagnostic by
placing it directly in the body of the associative container.

The same change is applied to unordered associative containers, which
had a similar problem.

Finally, this commit cleans up the forward declarations of several
map and unordered_map helpers, which are not needed anymore.

<rdar://problem/41370747>

Reviewers: EricWF, mclow.lists

Subscribers: christof, dexonsmith, llvm-commits

Differential Revision: https://reviews.llvm.org/D48955