tree 7c659caab50b19fceb4e67b48cdda44f854e7370
parent 6f2865e90816f1d3e6cdd2e38432ff576aa7d9c9
author Louis Dionne <ldionne@apple.com> 1570112693 +0000
committer Louis Dionne <ldionne@apple.com> 1570112693 +0000

[libc++abi] Do not export some implementation-detail functions

Summary:
Those functions started being mistakenly exported from the libc++abi
shared library after commit r344152 in 2018. Removing these symbols is
technically an ABI break. However, they are not part of the C++ ABI,
they haven't ever been re-exported from libc++, and they are not
declared in any public header, so it's very unlikely that calls to
these functions exist out there. Also, the functions have reserved
names, so any impacted user would have to have tried really hard
being broken by this removal.

Note that avoiding this kind of problem is exactly why we're now
controlling exported symbols explicitly with a textual list.

Also note that applying the hidden visibility attribute is necessary
because the list of exported symbols is only used on Apple platforms
for the time being.

Reviewers: phosek, mclow.lists, EricWF

Subscribers: christof, jkorous, dexonsmith, libcxx-commits

Tags: #libc

Differential Revision: https://reviews.llvm.org/D68357

git-svn-id: https://llvm.org/svn/llvm-project/libcxxabi/trunk@373602 91177308-0d34-0410-b5e6-96231b3b80d8