| commit | eb405d8a422eb77910a15715d17b60b7f10bbf8c | [log] [tgz] |
|---|---|---|
| author | Honglin Yu <honglinyu@chromium.org> | Thu Feb 06 14:12:07 2020 +1100 |
| committer | Nico Weber <thakis@chromium.org> | Fri Feb 07 19:39:45 2020 +0000 |
| tree | e1d95e57905d959d61aa6f2f129027f44769125d | |
| parent | 9f4020916eb1f28f3666f018fdcbe6c9a37f0e08 [diff] |
Add flag for compiling into shared libraries. We would like libicu to be compiled into shared libraries then can be reused by chrome and other programs on ChromeOS. To achieve this, we need to do two modifications on the BUILD.gn of icu, 1. Enable libicu to be compiled into a shared library. 2. Let chrome use system icu on ChromeOS. This CL achieves the first modification. For more discussion, please see https://docs.google.com/document/d/1T0H6DaRD9116pfaQMpBwfJtxlHPVJrroVsT_-SrAr1A/edit?usp=sharing BUG=chromium:1020393 TEST=on workstation, this mod can produce libicu*.so Change-Id: Ia48b47bd0c87dff0da7e92dcadb03aa4e639aa45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/2018302 Reviewed-by: Jungshik Shin <jshin@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org>