Automated change: Fix sanity tests
diff --git a/Package.swift b/Package.swift
index 210d9bc..65543f6 100644
--- a/Package.swift
+++ b/Package.swift
@@ -1652,6 +1652,7 @@
"src/core/lib/promise/seq.h",
"src/core/lib/promise/sleep.cc",
"src/core/lib/promise/sleep.h",
+ "src/core/lib/promise/status_flag.h",
"src/core/lib/promise/trace.cc",
"src/core/lib/promise/trace.h",
"src/core/lib/promise/try_seq.h",
diff --git a/build_autogenerated.yaml b/build_autogenerated.yaml
index bd2a9aa..6dff824 100644
--- a/build_autogenerated.yaml
+++ b/build_autogenerated.yaml
@@ -1050,6 +1050,7 @@
- src/core/lib/promise/race.h
- src/core/lib/promise/seq.h
- src/core/lib/promise/sleep.h
+ - src/core/lib/promise/status_flag.h
- src/core/lib/promise/trace.h
- src/core/lib/promise/try_seq.h
- src/core/lib/resolver/endpoint_addresses.h
@@ -2498,6 +2499,7 @@
- src/core/lib/promise/race.h
- src/core/lib/promise/seq.h
- src/core/lib/promise/sleep.h
+ - src/core/lib/promise/status_flag.h
- src/core/lib/promise/trace.h
- src/core/lib/promise/try_seq.h
- src/core/lib/resolver/endpoint_addresses.h
@@ -4623,6 +4625,7 @@
- src/core/lib/promise/promise.h
- src/core/lib/promise/race.h
- src/core/lib/promise/seq.h
+ - src/core/lib/promise/status_flag.h
- src/core/lib/promise/trace.h
- src/core/lib/promise/try_seq.h
- src/core/lib/resolver/endpoint_addresses.h
@@ -9386,6 +9389,7 @@
- src/core/lib/promise/poll.h
- src/core/lib/promise/race.h
- src/core/lib/promise/seq.h
+ - src/core/lib/promise/status_flag.h
- src/core/lib/promise/trace.h
- src/core/lib/promise/try_seq.h
- src/core/lib/resource_quota/arena.h
@@ -11556,6 +11560,7 @@
- src/core/lib/promise/poll.h
- src/core/lib/promise/race.h
- src/core/lib/promise/seq.h
+ - src/core/lib/promise/status_flag.h
- src/core/lib/promise/trace.h
- src/core/lib/promise/try_seq.h
- src/core/lib/resource_quota/arena.h
@@ -16937,6 +16942,7 @@
- src/core/lib/promise/promise.h
- src/core/lib/promise/race.h
- src/core/lib/promise/seq.h
+ - src/core/lib/promise/status_flag.h
- src/core/lib/promise/trace.h
- src/core/lib/promise/try_seq.h
- src/core/lib/resolver/endpoint_addresses.h
@@ -17952,6 +17958,7 @@
- src/core/lib/promise/detail/seq_state.h
- src/core/lib/promise/detail/status.h
- src/core/lib/promise/poll.h
+ - src/core/lib/promise/status_flag.h
- src/core/lib/promise/trace.h
- src/core/lib/promise/try_seq.h
src:
diff --git a/gRPC-C++.podspec b/gRPC-C++.podspec
index 1d2d74a..5e8485a 100644
--- a/gRPC-C++.podspec
+++ b/gRPC-C++.podspec
@@ -1147,6 +1147,7 @@
'src/core/lib/promise/race.h',
'src/core/lib/promise/seq.h',
'src/core/lib/promise/sleep.h',
+ 'src/core/lib/promise/status_flag.h',
'src/core/lib/promise/trace.h',
'src/core/lib/promise/try_seq.h',
'src/core/lib/resolver/endpoint_addresses.h',
@@ -2378,6 +2379,7 @@
'src/core/lib/promise/race.h',
'src/core/lib/promise/seq.h',
'src/core/lib/promise/sleep.h',
+ 'src/core/lib/promise/status_flag.h',
'src/core/lib/promise/trace.h',
'src/core/lib/promise/try_seq.h',
'src/core/lib/resolver/endpoint_addresses.h',
diff --git a/gRPC-Core.podspec b/gRPC-Core.podspec
index 2e78799..0fd3d26 100644
--- a/gRPC-Core.podspec
+++ b/gRPC-Core.podspec
@@ -1755,6 +1755,7 @@
'src/core/lib/promise/seq.h',
'src/core/lib/promise/sleep.cc',
'src/core/lib/promise/sleep.h',
+ 'src/core/lib/promise/status_flag.h',
'src/core/lib/promise/trace.cc',
'src/core/lib/promise/trace.h',
'src/core/lib/promise/try_seq.h',
@@ -3140,6 +3141,7 @@
'src/core/lib/promise/race.h',
'src/core/lib/promise/seq.h',
'src/core/lib/promise/sleep.h',
+ 'src/core/lib/promise/status_flag.h',
'src/core/lib/promise/trace.h',
'src/core/lib/promise/try_seq.h',
'src/core/lib/resolver/endpoint_addresses.h',
diff --git a/grpc.gemspec b/grpc.gemspec
index ffcdbc6..c7248f3 100644
--- a/grpc.gemspec
+++ b/grpc.gemspec
@@ -1658,6 +1658,7 @@
s.files += %w( src/core/lib/promise/seq.h )
s.files += %w( src/core/lib/promise/sleep.cc )
s.files += %w( src/core/lib/promise/sleep.h )
+ s.files += %w( src/core/lib/promise/status_flag.h )
s.files += %w( src/core/lib/promise/trace.cc )
s.files += %w( src/core/lib/promise/trace.h )
s.files += %w( src/core/lib/promise/try_seq.h )
diff --git a/package.xml b/package.xml
index 4ff9ece..38b4ade 100644
--- a/package.xml
+++ b/package.xml
@@ -1640,6 +1640,7 @@
<file baseinstalldir="/" name="src/core/lib/promise/seq.h" role="src" />
<file baseinstalldir="/" name="src/core/lib/promise/sleep.cc" role="src" />
<file baseinstalldir="/" name="src/core/lib/promise/sleep.h" role="src" />
+ <file baseinstalldir="/" name="src/core/lib/promise/status_flag.h" role="src" />
<file baseinstalldir="/" name="src/core/lib/promise/trace.cc" role="src" />
<file baseinstalldir="/" name="src/core/lib/promise/trace.h" role="src" />
<file baseinstalldir="/" name="src/core/lib/promise/try_seq.h" role="src" />
diff --git a/src/core/BUILD b/src/core/BUILD
index b5bf934..1b51a7b 100644
--- a/src/core/BUILD
+++ b/src/core/BUILD
@@ -782,6 +782,7 @@
"promise_status",
"seq_state",
"status_flag",
+ "//:gpr",
"//:gpr_platform",
],
)
diff --git a/src/core/ext/transport/inproc/inproc_transport.cc b/src/core/ext/transport/inproc/inproc_transport.cc
index cc79007..14a92e6 100644
--- a/src/core/ext/transport/inproc/inproc_transport.cc
+++ b/src/core/ext/transport/inproc/inproc_transport.cc
@@ -116,7 +116,7 @@
call_handler](ClientMetadataHandle md) {
auto call_initiator = server_transport->AcceptCall(*md);
if (!call_initiator.ok()) return call_initiator.status();
- ForwardCall(std::move(call_handler), std::move(*call_initiator),
+ ForwardCall(call_handler, std::move(*call_initiator),
std::move(md));
return absl::OkStatus();
},
@@ -162,8 +162,7 @@
std::string(error.message()).c_str());
intptr_t integer;
grpc_status_code status = GRPC_STATUS_INTERNAL;
- if (grpc_error_get_int(error, grpc_core::StatusIntProperty::kRpcStatus,
- &integer)) {
+ if (grpc_error_get_int(error, StatusIntProperty::kRpcStatus, &integer)) {
status = static_cast<grpc_status_code>(integer);
}
return RefCountedPtr<Channel>(Channel::FromC(grpc_lame_client_channel_create(
diff --git a/src/core/lib/promise/detail/promise_like.h b/src/core/lib/promise/detail/promise_like.h
index 4bec366..e0fdc30 100644
--- a/src/core/lib/promise/detail/promise_like.h
+++ b/src/core/lib/promise/detail/promise_like.h
@@ -17,6 +17,7 @@
#include <grpc/support/port_platform.h>
+#include <type_traits>
#include <utility>
#include "absl/meta/type_traits.h"
diff --git a/src/core/lib/promise/for_each.h b/src/core/lib/promise/for_each.h
index dd530d1..b72e42c 100644
--- a/src/core/lib/promise/for_each.h
+++ b/src/core/lib/promise/for_each.h
@@ -24,7 +24,6 @@
#include "absl/status/status.h"
#include "absl/strings/str_cat.h"
-#include "status_flag.h"
#include <grpc/support/log.h>
@@ -32,6 +31,7 @@
#include "src/core/lib/promise/activity.h"
#include "src/core/lib/promise/detail/promise_factory.h"
#include "src/core/lib/promise/poll.h"
+#include "src/core/lib/promise/status_flag.h"
#include "src/core/lib/promise/trace.h"
namespace grpc_core {
diff --git a/src/core/lib/promise/status_flag.h b/src/core/lib/promise/status_flag.h
index 523406f..907b2cb 100644
--- a/src/core/lib/promise/status_flag.h
+++ b/src/core/lib/promise/status_flag.h
@@ -46,8 +46,8 @@
class StatusFlag {
public:
explicit StatusFlag(bool value) : value_(value) {}
- StatusFlag(Failure) : value_(false) {}
- StatusFlag(Success) : value_(true) {}
+ explicit StatusFlag(Failure) : value_(false) {}
+ explicit StatusFlag(Success) : value_(true) {}
bool ok() const { return value_; }
@@ -75,8 +75,8 @@
template <typename T>
class ValueOrFailure {
public:
- ValueOrFailure(T value) : value_(std::move(value)) {}
- ValueOrFailure(Failure) {}
+ explicit ValueOrFailure(T value) : value_(std::move(value)) {}
+ explicit ValueOrFailure(Failure) {}
static ValueOrFailure FromOptional(absl::optional<T> value) {
return ValueOrFailure{std::move(value)};
diff --git a/src/core/lib/promise/try_seq.h b/src/core/lib/promise/try_seq.h
index 3de699b..062c8be 100644
--- a/src/core/lib/promise/try_seq.h
+++ b/src/core/lib/promise/try_seq.h
@@ -26,6 +26,8 @@
#include "absl/status/status.h"
#include "absl/status/statusor.h"
+#include <grpc/support/log.h>
+
#include "src/core/lib/promise/detail/basic_seq.h"
#include "src/core/lib/promise/detail/promise_like.h"
#include "src/core/lib/promise/detail/seq_state.h"
diff --git a/test/core/promise/BUILD b/test/core/promise/BUILD
index 2370dfd..410b124 100644
--- a/test/core/promise/BUILD
+++ b/test/core/promise/BUILD
@@ -341,6 +341,7 @@
"//src/core:map",
"//src/core:memory_quota",
"//src/core:pipe",
+ "//src/core:promise_status",
"//src/core:resource_quota",
"//src/core:seq",
"//src/core:try_seq",
@@ -368,6 +369,7 @@
"//src/core:memory_quota",
"//src/core:pipe",
"//src/core:poll",
+ "//src/core:promise_status",
"//src/core:resource_quota",
"//src/core:seq",
],
diff --git a/test/core/promise/for_each_test.cc b/test/core/promise/for_each_test.cc
index 9428769..a3ef094 100644
--- a/test/core/promise/for_each_test.cc
+++ b/test/core/promise/for_each_test.cc
@@ -23,6 +23,7 @@
#include "src/core/lib/gprpp/ref_counted_ptr.h"
#include "src/core/lib/promise/activity.h"
+#include "src/core/lib/promise/detail/status.h"
#include "src/core/lib/promise/inter_activity_pipe.h"
#include "src/core/lib/promise/join.h"
#include "src/core/lib/promise/map.h"
diff --git a/test/core/promise/map_pipe_test.cc b/test/core/promise/map_pipe_test.cc
index 8cd88aa..bc34333 100644
--- a/test/core/promise/map_pipe_test.cc
+++ b/test/core/promise/map_pipe_test.cc
@@ -24,6 +24,7 @@
#include "src/core/lib/gprpp/ref_counted_ptr.h"
#include "src/core/lib/promise/activity.h"
+#include "src/core/lib/promise/detail/status.h"
#include "src/core/lib/promise/for_each.h"
#include "src/core/lib/promise/join.h"
#include "src/core/lib/promise/map.h"
diff --git a/test/core/util/port_server_client.h b/test/core/util/port_server_client.h
index 3e47935..97865ba 100644
--- a/test/core/util/port_server_client.h
+++ b/test/core/util/port_server_client.h
@@ -19,7 +19,6 @@
#ifndef GRPC_TEST_CORE_UTIL_PORT_SERVER_CLIENT_H
#define GRPC_TEST_CORE_UTIL_PORT_SERVER_CLIENT_H
-#include <memory>
// C interface to port_server.py
// must be synchronized with tools/run_tests/python_utils/start_port_server.py
diff --git a/tools/doxygen/Doxyfile.c++.internal b/tools/doxygen/Doxyfile.c++.internal
index 5905f23..03508b9 100644
--- a/tools/doxygen/Doxyfile.c++.internal
+++ b/tools/doxygen/Doxyfile.c++.internal
@@ -2657,6 +2657,7 @@
src/core/lib/promise/seq.h \
src/core/lib/promise/sleep.cc \
src/core/lib/promise/sleep.h \
+src/core/lib/promise/status_flag.h \
src/core/lib/promise/trace.cc \
src/core/lib/promise/trace.h \
src/core/lib/promise/try_seq.h \
diff --git a/tools/doxygen/Doxyfile.core.internal b/tools/doxygen/Doxyfile.core.internal
index aa35ecb..681c205 100644
--- a/tools/doxygen/Doxyfile.core.internal
+++ b/tools/doxygen/Doxyfile.core.internal
@@ -2436,6 +2436,7 @@
src/core/lib/promise/seq.h \
src/core/lib/promise/sleep.cc \
src/core/lib/promise/sleep.h \
+src/core/lib/promise/status_flag.h \
src/core/lib/promise/trace.cc \
src/core/lib/promise/trace.h \
src/core/lib/promise/try_seq.h \
