| commit | 0edc819075312bc4e7ea7605c924585bbc22a12c | [log] [tgz] |
|---|---|---|
| author | Ghanan Gowripalan <ghanan@google.com> | Fri Jul 28 15:33:10 2023 +0000 |
| committer | CQ Bot <fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jul 28 15:35:20 2023 +0000 |
| tree | 805ea8f1e27922bdf7212b6e81c0bb9d2cddb5c0 | |
| parent | 2b3f72fa1f4168360d586ca7a8428256dc0acfa6 [diff] |
Revert "[fidl] Don't close channel on 1way messaging errors" This reverts commit 2b3f72fa1f4168360d586ca7a8428256dc0acfa6. Reason for revert: This doesn't do what we wanted it to do. See https://fxbug.dev/131322 Original change's description: > [fidl] Don't close channel on 1way messaging errors > > When sending a one-way/fire-and-forget message, do not close the channel > if an error occurs. This is so that a client can read messages sitting > in the channel after the error occurs. It should also be noted that for > one-way/fire-and-forget messaging, there is no guarantee of message > delivery or handling. > > This change is needed for Ib72a8a7610637731a518241d9d048be9bd4fdf1a. > > Bug: b/292622684 > Change-Id: I44735984427066d23e15af6fedc1af01d3ea66a3 > Reviewed-on: https://fuchsia-review.googlesource.com/c/third_party/go/+/891252 > Reviewed-by: Bruno Dal Bo <brunodalbo@google.com> > Fuchsia-Auto-Submit: Ghanan Gowripalan <ghanan@google.com> > Commit-Queue: Ghanan Gowripalan <ghanan@google.com> Bug: b/292622684 Change-Id: If7a7397b4385710623fb10af541043f95c60ba97 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://fuchsia-review.googlesource.com/c/third_party/go/+/891718 Commit-Queue: Ghanan Gowripalan <ghanan@google.com> Reviewed-by: RubberStamper 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 4.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.