| commit | f4cc13d369771b7726f8129a000e55fe9e19776d | [log] [tgz] |
|---|---|---|
| author | Devon H. O'Dell <dhobsd@google.com> | Tue Nov 06 10:39:55 2018 -0800 |
| committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | Mon Nov 19 23:20:46 2018 +0000 |
| tree | c4682f19cefae51bf089633f099364cc91c606f0 | |
| parent | 143b6d3e3c0419fa069fc22d6e904a4b15dc80d2 [diff] |
[fdio] Do not close VMOFile again on error In f097da4cae2bead51359d4eddefb0b8b4fb850bd, the node handle was closed when a failure was encountered in creating the VMOFile. Subsequently, ef4119d3fa5da5f70797f2e1f0d2683bad99f154 noticed that Pipes and VMOFiles should always be closed, and unconditionally closed the handle. This change removes the second close, which would likely fail (the handle already being closed), masking the error from creating the VMOFile. This change also fixes some style around the fixed code. The call to NewVMOFile should be on a single line, and the comma after the last argument is unnecessary and confusing. Change-Id: I014c6ca6ab7eb51328182d0cbb7457e2711c1745
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install or load doc/install.html in your web browser for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source or load doc/install-source.html in your web browser for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.