[zxwait] Wait for done when canceled and closed

Prior to this change, canceling pending waiters that were waiting for
signals on a closed handled would leave "lingering" packets in the
Port's queue. This would occasionally cause future waits to panic as the
"done" channel was being closed twice.

This CL flags waitingGs whose pending waiters have been canceled, which
prevents double cancellation. This enables `Wait` to properly drain the
`done` channel when it observes ctx cancellation for waits on a closed
handle.

Fixed: 132321
Change-Id: I16df9d75835b8e3820b50be9d7a5f2efa265bd84
Reviewed-on: https://fuchsia-review.googlesource.com/c/third_party/go/+/908524
Reviewed-by: Bruno Dal Bo <brunodalbo@google.com>
2 files changed
tree: 806fd6e21dbbf61195da35a0ac806ec8ace5d2fa
  1. .github/
  2. api/
  3. doc/
  4. lib/
  5. makefuchsia/
  6. makeroot/
  7. meta/
  8. misc/
  9. src/
  10. test/
  11. .gitattributes
  12. .gitignore
  13. BUILD.gn
  14. codereview.cfg
  15. CONTRIBUTING.md
  16. LICENSE
  17. OWNERS
  18. PATENTS
  19. README.md
  20. regen-api
  21. regen-api.py
  22. regen-fidl
  23. regen-syscalls
  24. SECURITY.md
  25. UPGRADE.md
  26. VERSION
README.md

The Go Programming Language

Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.

Gopher image Gopher image by Renee French, licensed under Creative Commons 4.0 Attributions license.

Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.

Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.

Download and Install

Binary Distributions

Official binary distributions are available at https://go.dev/dl/.

After downloading a binary release, visit https://go.dev/doc/install for installation instructions.

Install From Source

If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.

Contributing

Go is the work of thousands of contributors. We appreciate your help!

To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.

Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.