tree d1b86bb391046b9757819b350b8727cd2f12d082
parent 5fb67a91d53e5f01281904108473ec3ca2b0749e
author Erick Tryzelaar <etryzelaar@google.com> 1538151539 -0700
committer Erick Tryzelaar <etryzelaar@google.com> 1540239656 -0700

[exec] Fix handle leak in exec.Command

There's no guarantee that the exec.Command finalizer will ever be
run, so we need to make sure to release the handle if we call
Wait or Kill on the process, which is what exec_windows.go does.

Also, since exec wraps a uintptr cast of a handle, this uses
atomic.SwapUintptr to avoid racing on closing the handle.

PKG-250 #comment

TEST: Manually verified handle is no longer leaking when calling
a command with exec.Command(...).Run().

Change-Id: I4d48f86b1abe725e10f75f2bf46614e7936fb7ba