| commit | 333837b76f9d5f5dc5293e5d61d38c3000890d65 | [log] [tgz] |
|---|---|---|
| author | Eyal Soha <eyalsoha@google.com> | Thu Oct 04 12:43:49 2018 -0400 |
| committer | Eyal Soha <eyalsoha@google.com> | Mon Oct 08 12:43:37 2018 -0400 |
| tree | a85e54f59b18958fe5411a8c4bf089f037ffe2e4 | |
| parent | 791450eb3c98e711f5b60cd48befea0c980c541b [diff] |
[fidl][golang] Start Union Tags at 1 instead of 0
This doesn't affect the wire format, only the representation of FIDL
unions and only in Go. It will help detect two kinds of errors:
1. Uninitialized unions were previously of the first member, now they
are errors when marshalling:
union Union1 {
int64 a;
int64 b;
};
u1 := Union1{} // This was previously of type "a" with value 0, now it is an error whenmarshalled.
2. Not using setters properly will be caught as errors when
marshalling:
u1 := Union1{}
u1.a = 12345 // This is wrong, it should have been u1.SetA(12345)
Both new and old encodings are modified and interoperable.
TESTED=fx run-test go_fidl_test
Change-Id: Ida12a5b8eb7cbc2a00f0661028381adfe3a0a2c6
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install or load doc/install.html in your web browser for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source or load doc/install-source.html in your web browser for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.