commit | 08436b6f74a8212cd4480cb5a1add7b71b84b622 | [log] [tgz] |
---|---|---|
author | Benjamin Prosnitz <bprosnitz@google.com> | Tue Aug 17 09:11:22 2021 -0400 |
committer | CQ Bot <commit-bot@chromium.org> | Tue Aug 17 18:00:23 2021 +0000 |
tree | 175f07e3db943878efdcf533d370f417d72df741 | |
parent | 66a9733f74e6e5f8f21738ed5e9a956cb302d01d [diff] |
[fidl][go] Use <= 4 byte unknown data to indicate inlining Envelope inlining is a feature that allows up to 4 bytes of data to be store inline in an envelope. Previously, the FIDL go bindings identified inline unknown envelopes through a boolean on the unknown value. This was unnecessary because it is possible to determine if an envelope is inlined based on the data length. Additionally, other FIDL bindings use the data length rather than an inline boolean so this aligns better with them. This also fixes a bug in encode where handles wouldn't be encoded in inlining mode. This will be tested through GIDL tests added separately. Bug: 80348 Change-Id: I4f17d9919a639a812e122fd7cbec78aa0f9e9ed2 Reviewed-on: https://fuchsia-review.googlesource.com/c/third_party/go/+/569841 Reviewed-by: Mitchell Kember <mkember@google.com> Commit-Queue: Benjamin Prosnitz <bprosnitz@google.com>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://golang.org/doc/contribute.html.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.