tree bf99499509711dc74f03325d69be2fd0b98a9687
parent 54f72d32435d760d5604f17a82e2435b28dc4ba5
author Prashant Varanasi <github@prashantv.com> 1510676171 -0800
committer GitHub <noreply@github.com> 1510676171 -0800
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJaCxbLCRBK7hj4Ov3rIwAAdHIIAASnQnfPevK57CMdj43vxuX4
 nO98aAgA+1fLzFVw5v5PQNTlFtLnv2MOAVWLL0fbSqfxaG0UJ/iZ21Sy+/DuXD+F
 njZuj9sVDiQ7DerASnV208bwo5eXXZQkXf9Ly8+hM+D2wNni0Yfflt8AalUqlpQc
 NcfvvYCxs8kVUaht+ytzajh4Z2rJ+kp5MjpRfB9P89I3HBYbaS925rxRnGeGAGcR
 cR1559ASwmVer8BeqJHT9xrpKQcXojfFPOrFM+puElfFunjjo4l+ALmsoOGBcYO5
 9voB/YHofPzPuYBNPkXS2/iOPMlW1/oX/HsrgRqyrSp3ewkWQOr9z0ds5M+JO0k=
 =8oPi
 -----END PGP SIGNATURE-----
 

Revert "Optimization for String.Store("")" (#32)

This optimization causes data races since we're changing the value field
without using atomics. E.g., a caller who has multiple goroutines
calling `Set("1")` and `Set("")` will race on the access to `s.v` since
one goroutine is trying to read it while the other sets it, neither
using atomic operations.

This reverts commit 16b44f14f0990d358f2ba3191ff8e7c44c9f0bef.