tree 751e26007feca6e140434e9a92089a375f4c2a42
parent aa5a447569a7ed4dd24abc368d8b6726c77f9f3f
author Drew Fisher <zarvox@google.com> 1600331951 -0700
committer Drew Fisher <zarvox@google.com> 1600416104 +0000

[spirv-remap] Fix undefined behavior in hashing

There's a statement that intends to generate a 32-bit hashcode, but due
to integer promotion, the intermediate values can trigger signed integer
overflow, which is undefined behavior.

To avoid this, cast at least one operand to unsigned int before
multiplying, which will cause the result to be promoted to unsigned int
instead of signed int.

With this patch, I'm able to build core for qemu-x64 with host_asan-ubsan.

Fixed: 60128
Change-Id: Idd644e534116bf29dca8013936ac39901bbe68fc
Reviewed-on: https://fuchsia-review.googlesource.com/c/third_party/glslang/+/428254
Reviewed-by: John Bauman <jbauman@google.com>