tree 50424d0aa8873d94ec13ea0e0cd3916f58c9cca9
parent b34d68b672c35042b7d7334590e1e0cd653f3826
author Krzesimir Nowak <qdlacz@gmail.com> 1612997467 +0100
committer Philip Withnall <pwithnall@endlessos.org> 1613041855 +0000

gbytearray: Do not accept too large byte arrays

GByteArray uses guint for storing the length of the byte array, but it
also has a constructor (g_byte_array_new_take) that takes length as a
gsize. gsize may be larger than guint (64 bits for gsize vs 32 bits
for guint). It is possible to call the function with a value greater
than G_MAXUINT, which will result in silent length truncation. This
may happen as a result of unreffing GBytes into GByteArray, so rather
be loud about it.

(Test case tweaked by Philip Withnall.)

(Backport 2.66: Add #include gstrfuncsprivate.h in the test case for
`g_memdup2()`.)