commit c20754c4a65784f46519397cee285018670d2cfb
author Camilla Löwy <elmindreda@elmindreda.org> Mon Mar 04 18:52:56 2019 +0100
committer Camilla Löwy <elmindreda@elmindreda.org> Mon Mar 04 18:52:56 2019 +0100
tree 1ad8663d184a4bc56997f8622336d5dd091f0678
parent 621ece63c8d31ae0dcf2196a3abde19ce8569984

Fix Coverity Scan false positive

src/cocoa_joystick.m

diff --git a/src/cocoa_joystick.m b/src/cocoa_joystick.m
index 1c2818f..23cc7a8 100644
--- a/src/cocoa_joystick.m
+++ b/src/cocoa_joystick.m
@@ -464,7 +464,7 @@
         (strncmp(guid + 20, "000000000000", 12) == 0))
     {
         char original[33];
-        strcpy(original, guid);
+        strncpy(original, guid, sizeof(original) - 1);
         sprintf(guid, "03000000%.4s0000%.4s000000000000",
                 original, original + 16);
     }

src/input.c

diff --git a/src/input.c b/src/input.c
index b5e1154..7ee4281 100644
--- a/src/input.c
+++ b/src/input.c
@@ -436,7 +436,7 @@
     js->buttonCount = buttonCount;
     js->hatCount    = hatCount;
 
-    strcpy(js->guid, guid);
+    strncpy(js->guid, guid, sizeof(js->guid) - 1);
     js->mapping = findValidMapping(js);
 
     return js;

src/win32_joystick.c

diff --git a/src/win32_joystick.c b/src/win32_joystick.c
index 5812396..280ab47 100644
--- a/src/win32_joystick.c
+++ b/src/win32_joystick.c
@@ -745,7 +745,7 @@
     if (strcmp(guid + 20, "504944564944") == 0)
     {
         char original[33];
-        strcpy(original, guid);
+        strncpy(original, guid, sizeof(original) - 1);
         sprintf(guid, "03000000%.4s0000%.4s000000000000",
                 original, original + 4);
     }