tree 9d221dfb4baf6a4d90bac8666ba2b7c53c1abf8e
parent c0eb78e8392ac7d7ffe0c92ae44b5c1b3f04785a
parent d24b0ba3309f6b207cc19781c7e40b211a1e96a0
author bors <bors@rust-lang.org> 1712156296 +0000
committer bors <bors@rust-lang.org> 1712156296 +0000

Auto merge of #17003 - krobelus:utf8-positions-multibyte, r=Veykril

Fix off-by-one error converting to LSP UTF8 offsets with multi-byte char

On this file,

```rust
fn main() {
    let 된장 = 1;
}
```

when using `"positionEncodings":["utf-16"]` I get an "unused variable" diagnostic on the variable
name (codepoint offset range `8..10`). So far so good.

When using `positionEncodings":["utf-8"]`, I expect to get the equivalent range in bytes (LSP:
"Character offsets count UTF-8 code units (e.g bytes)."), which is `8..14`, because both
characters are 3 bytes in UTF-8.  However I actually get `10..14`.

Looks like this is because we accidentally treat a 1-based index as an offset value: when
converting from our internal char-indices to LSP byte offsets, we look at one character to many.
This causes wrong results if the extra character is a multi-byte one, such as when computing
the start coordinate of 된장.

Fix that by actually passing an offset. While at it, fix the variable name of the line number,
which is not an offset (yet).

Originally reported at https://github.com/kakoune-lsp/kakoune-lsp/issues/740