commit f1b4a9cfb06e874eebf1796e7acd99bbde26f619
author Aleksei Trifonov <avrong@avrong.me> Mon Aug 26 03:06:49 2024 +0300
committer Aleksei Trifonov <avrong@avrong.me> Mon Aug 26 12:19:50 2024 +0300
tree 0acfc89c0adeb65db638f3e86f0618e075c28f3e
parent 7ea4241afa8432b43b0a8d31b172171d02390d86

Show lifetime args if there are only error ones

crates/hir-ty/src/display.rs

diff --git a/crates/hir-ty/src/display.rs b/crates/hir-ty/src/display.rs
index 151cc3d..4a5eaaa 100644
--- a/crates/hir-ty/src/display.rs
+++ b/crates/hir-ty/src/display.rs
@@ -1438,17 +1438,7 @@
 
     let parameters_to_write = generic_args_sans_defaults(f, generic_def, parameters);
 
-    // FIXME: Remote this
-    // most of our lifetimes will be errors as we lack elision and inference
-    // so don't render them for now
-    let only_err_lifetimes = !cfg!(test)
-        && parameters_to_write.iter().all(|arg| {
-            matches!(
-                arg.data(Interner),
-                chalk_ir::GenericArgData::Lifetime(it) if *it.data(Interner) == LifetimeData::Error
-            )
-        });
-    if !parameters_to_write.is_empty() && !only_err_lifetimes {
+    if !parameters_to_write.is_empty() {
         write!(f, "<")?;
         hir_fmt_generic_arguments(f, parameters_to_write, self_)?;
         write!(f, ">")?;
@@ -1881,7 +1871,7 @@
                 wc.hir_fmt(f)?;
                 write!(f, ")")?;
             }
-            _ => write!(f, "?")?,
+            _ => write!(f, "_")?,
         }
         Ok(())
     }