Rollup merge of #158214 - hanna-kruppe:issue-158206, r=cjgillot

Don't try to remove assignments in SimplifyComparisonIntegral

The pass tried to opportunistically clean up an unnecessary assign statement if there's no other use of the comparison folded into a `switchInt`. The reasoning was that `switchInt(move _N)` prevents uses of `_N` in other blocks. The immediate problem is that the pass didn't check for other uses of the comparison result *in the same block*. This PR drops the cleanup logic entirely to fix rust-lang/rust#158206.

One could try to salvage the cleanup by doing another scan through the basic block and looking for other uses of the temporary. However, the other half of the reasoning (`move` prevents later uses) is also dubious. As the documentation of `Operand::Move` says:

> This may additionally overwrite the place with uninit bytes, depending on how we decide in [UCG#188](https://github.com/rust-lang/unsafe-code-guidelines/issues/188). You should not emit MIR that may attempt a subsequent second load of this place without first re-initializing it.

This does not justify assuming "moves makes place uninitialized" semantics for the purpose of optimizations. At least for now, it doesn't seem possible to do this cleanup soundly without a whole-function analysis that looks at all uses, i.e., a general dead code elimination pass.
tree: e38ae80032e7d22549502427003bb411160eaa2b
  1. .cargo/
  2. .config/
  3. .github/
  4. .vscode/
  5. assets/
  6. bench_data/
  7. crates/
  8. docs/
  9. editors/
  10. lib/
  11. xtask/
  12. .codecov.yml
  13. .editorconfig
  14. .git-blame-ignore-revs
  15. .gitattributes
  16. .gitignore
  17. .typos.toml
  18. AI_POLICY.md
  19. Cargo.lock
  20. Cargo.toml
  21. CLAUDE.md
  22. clippy.toml
  23. CONTRIBUTING.md
  24. josh-sync.toml
  25. LICENSE-APACHE
  26. LICENSE-MIT
  27. PRIVACY.md
  28. README.md
  29. rust-version
  30. rustfmt.toml
  31. triagebot.toml
README.md

rust-analyzer is a language server that provides IDE functionality for writing Rust programs. You can use it with any editor that supports the Language Server Protocol (VS Code, Vim, Emacs, Zed, etc).

rust-analyzer features include go-to-definition, find-all-references, refactorings and code completion. rust-analyzer also supports integrated formatting (with rustfmt) and integrated diagnostics (with rustc and clippy).

Internally, rust-analyzer is structured as a set of libraries for analyzing Rust code. See Architecture in the manual.

codecov

Quick Start

https://rust-analyzer.github.io/book/installation.html

Documentation

If you want to contribute to rust-analyzer check out the CONTRIBUTING.md or if you are just curious about how things work under the hood, see the Contributing section of the manual.

If you want to use rust-analyzer's language server with your editor of choice, check the manual. It also contains some tips & tricks to help you be more productive when using rust-analyzer.

Security and Privacy

See the security and privacy sections of the manual.

Communication

For usage and troubleshooting requests, please use “IDEs and Editors” category of the Rust forum:

https://users.rust-lang.org/c/ide/14

For questions about development and implementation, join rust-analyzer working group on Zulip:

https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Frust-analyzer

Quick Links

License

rust-analyzer is primarily distributed under the terms of both the MIT license and the Apache License (Version 2.0).

See LICENSE-APACHE and LICENSE-MIT for details.