replace_arith_op not applicable on selected
diff --git a/crates/ide-assists/src/handlers/replace_arith_op.rs b/crates/ide-assists/src/handlers/replace_arith_op.rs
index 6b385a0..440ab4d 100644
--- a/crates/ide-assists/src/handlers/replace_arith_op.rs
+++ b/crates/ide-assists/src/handlers/replace_arith_op.rs
@@ -102,6 +102,9 @@
/// Extract the operands of an arithmetic expression (e.g. `1 + 2` or `1.checked_add(2)`)
fn parse_binary_op(ctx: &AssistContext<'_>) -> Option<(ast::Expr, ArithOp, ast::Expr)> {
+ if !ctx.has_empty_selection() {
+ return None;
+ }
let expr = ctx.find_node_at_offset::<ast::BinExpr>()?;
let op = match expr.op_kind() {
@@ -163,7 +166,7 @@
#[cfg(test)]
mod tests {
- use crate::tests::check_assist;
+ use crate::tests::{check_assist, check_assist_not_applicable};
use super::*;
@@ -223,4 +226,16 @@
"#,
)
}
+
+ #[test]
+ fn replace_arith_not_applicable_with_non_empty_selection() {
+ check_assist_not_applicable(
+ replace_arith_with_checked,
+ r#"
+fn main() {
+ let x = 1 $0+$0 2;
+}
+"#,
+ )
+ }
}
