sftp: update tests to finish and not panic on windows

Many Unix assuptions have been made when testing.
Previously running tests on windows threw a panic
part way through the tests. After these changes
many more tests pass when the fix was isolated
to the test itself, and none panic.

Some tests are skipped because they do make sense
on windows (chmod, chown), while others are skipped
just to how the test was implemented.

Lastly, some of the external executables were hard coded.
Change these to look paths in TestMain first. This is done
to better support windows, where openssh may be installed and
sftp and sftp-server may both be in the PATH.
9 files changed
tree: 1cb00191bb89d95188a509fc96e4d2311f437827
  1. examples/
  2. server_standalone/
  3. .gitignore
  4. .travis.yml
  5. attrs.go
  6. attrs_stubs.go
  7. attrs_test.go
  8. attrs_unix.go
  9. client.go
  10. client_integration_darwin_test.go
  11. client_integration_linux_test.go
  12. client_integration_test.go
  13. client_test.go
  14. conn.go
  15. CONTRIBUTORS
  16. debug.go
  17. example_test.go
  18. LICENSE
  19. match.go
  20. packet-manager.go
  21. packet-manager_test.go
  22. packet-typing.go
  23. packet.go
  24. packet_test.go
  25. README.md
  26. release.go
  27. request-attrs.go
  28. request-attrs_test.go
  29. request-errors.go
  30. request-example.go
  31. request-interfaces.go
  32. request-readme.md
  33. request-server.go
  34. request-server_test.go
  35. request-unix.go
  36. request.go
  37. request_test.go
  38. request_windows.go
  39. server.go
  40. server_integration_test.go
  41. server_statvfs_darwin.go
  42. server_statvfs_impl.go
  43. server_statvfs_linux.go
  44. server_statvfs_stubs.go
  45. server_stubs.go
  46. server_test.go
  47. server_unix.go
  48. sftp.go
README.md

sftp

The sftp package provides support for file system operations on remote ssh servers using the SFTP subsystem. It also implements an SFTP server for serving files from the filesystem.

UNIX Build Status GoDoc

usage and examples

See godoc.org/github.com/pkg/sftp for examples and usage.

The basic operation of the package mirrors the facilities of the os package.

The Walker interface for directory traversal is heavily inspired by Keith Rarick's fs package.

roadmap

  • There is way too much duplication in the Client methods. If there was an unmarshal(interface{}) method this would reduce a heap of the duplication.

contributing

We welcome pull requests, bug fixes and issue reports.

Before proposing a large change, first please discuss your change by raising an issue.

For API/code bugs, please include a small, self contained code example to reproduce the issue. For pull requests, remember test coverage.

We try to handle issues and pull requests with a 0 open philosophy. That means we will try to address the submission as soon as possible and will work toward a resolution. If progress can no longer be made (eg. unreproducible bug) or stops (eg. unresponsive submitter), we will close the bug.

Thanks.