Google Git
Sign in
fuchsia / third_party / github.com / pkg / sftp / b0f20f999fc77694512444077c6bbf70e34160a9
commitb0f20f999fc77694512444077c6bbf70e34160a9[log] [tgz]
authorJohn Eikenberry <jae@zhar.net>Mon Aug 20 12:39:58 2018 -0700
committerJohn Eikenberry <jae@zhar.net>Wed Aug 22 13:11:00 2018 -0700
treece006ffba3e377c861b4357324f4189de7be6d2f
parentfe93131e0a925a116ad9296296bb40c3373d69eb [diff]
fix race w/ open packet and stat

An Open packet would trigger the use of a worker pool, then the Stat
packet would come in go to the pool and return faster than the Open
(returning a file-not-found error). This fixes that be eliminating the
pool/non-pool state switching.

The include test doesn't really exercise it fully as it cannot inject
a delay in the right place to trigger the race. I plan on adding a means
to inject some logic into the packet handling in the future once I
rewrite the old filesystem server code as a request-server backend.

Fixes #265
2 files changed
tree: ce006ffba3e377c861b4357324f4189de7be6d2f
  1. examples/
  2. server_standalone/
  3. .gitignore
  4. .travis.yml
  5. attrs.go
  6. attrs_stubs.go
  7. attrs_test.go
  8. attrs_unix.go
  9. client.go
  10. client_integration_darwin_test.go
  11. client_integration_linux_test.go
  12. client_integration_test.go
  13. client_test.go
  14. conn.go
  15. CONTRIBUTORS
  16. debug.go
  17. example_test.go
  18. LICENSE
  19. match.go
  20. other_test.go
  21. packet-manager.go
  22. packet-manager_test.go
  23. packet-typing.go
  24. packet.go
  25. packet_test.go
  26. README.md
  27. release.go
  28. request-attrs.go
  29. request-attrs_test.go
  30. request-errors.go
  31. request-example.go
  32. request-interfaces.go
  33. request-readme.md
  34. request-server.go
  35. request-server_test.go
  36. request-unix.go
  37. request.go
  38. request_test.go
  39. request_windows.go
  40. server.go
  41. server_integration_test.go
  42. server_statvfs_darwin.go
  43. server_statvfs_impl.go
  44. server_statvfs_linux.go
  45. server_statvfs_stubs.go
  46. server_stubs.go
  47. server_test.go
  48. server_unix.go
  49. sftp.go
README.md

sftp

The sftp package provides support for file system operations on remote ssh servers using the SFTP subsystem. It also implements an SFTP server for serving files from the filesystem.

UNIX Build Status GoDoc

usage and examples

See godoc.org/github.com/pkg/sftp for examples and usage.

The basic operation of the package mirrors the facilities of the os package.

The Walker interface for directory traversal is heavily inspired by Keith Rarick's fs package.

roadmap

  • There is way too much duplication in the Client methods. If there was an unmarshal(interface{}) method this would reduce a heap of the duplication.

contributing

We welcome pull requests, bug fixes and issue reports.

Before proposing a large change, first please discuss your change by raising an issue.

For API/code bugs, please include a small, self contained code example to reproduce the issue. For pull requests, remember test coverage.

We try to handle issues and pull requests with a 0 open philosophy. That means we will try to address the submission as soon as possible and will work toward a resolution. If progress can no longer be made (eg. unreproducible bug) or stops (eg. unresponsive submitter), we will close the bug.

Thanks.