tree ee701ad59802e802e1135e1be1c798c779dbcaf4
parent ca043ca452cac768d3b7bab7140076218dad0445
author John Eikenberry <jae@zhar.net> 1498760872 -0700
committer John Eikenberry <jae@zhar.net> 1498760872 -0700

Fixes #181: client deadlock on server death

The client was deadlocking if you killed the server when a file transfer
was occuring. The problem occured when you had many requests sent and
were waiting on responses when the server dies. The errors for all those
pending requests get sent along the response channel which is also used
for the errors reported by the new requests being made. The new request
channel send is in the same loop as the channel reading, so when it
blocked due to all other errors filling the channel it deadlocked the
program.

There were 2 possible fixes, changing the new request error channel
usage to be in a separate goroutine to keep it from blocking the loop or
to increase the size of the buffer to handle all the errors. This
implements the latter.

Included is a test that reproduces the problem most of the time. Due to
the required timing of the issue, it was impossible to reproduce 100% of
the time.