tree b3cc498d91689afc5fbd960bf91f0e83329cec6c
parent 98203f5a8333288eb3163b7c667d4260fe1333e9
author John Eikenberry <jae@zhar.net> 1521146780 -0700
committer Doug Evans <dje@google.com> 1538516289 -0700

fix client deadlock on server death during writes

Fixes #234

Similar to #181 (which was about read methods), the client deadlocks on
server drop on write methods (Write/ReadFrom). This is another case of
broadcastErr() and dispatchRequest() deadlocking.

The fix is to bump up the channel used to communicate about inflight
packets to maxConcurrentRequests+1 (+1 is new). It seems that it can
have the full set of packets going and hit the error (triggering
broadcastErr) yet it still tries to call dispatchRequest again. More
details in that ticket.

I'm also bumping up the chan buffer in the read methods to keep them
consistent. I can't reproduce the problem, but it looks like it should
have it. So it might just be a much harder race to trigger.

This also includes 2 tests which reprocuded the issue for ReadFrom and
Write.

Change-Id: Icb6cefc682da28b8bd495cc8fddd65b9a37eb448