commit 0bf136aa41ea62cc27ef37e0c3a6f3ff68471a86
author David 'Digit' Turner <digit@google.com> Thu Mar 14 14:24:07 2024 +0100
committer CQ Bot <fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Mar 15 10:16:28 2024 +0000
tree 5c48bc3b6d887e52f230636af16245f9523adb3f
parent b60db430e3a60828a28ff8ec6e3e037ec6c0d516

ipc_handle.h: Add IpcService class

Introduce an alternative to IpcServiceHandle to
handle service handling, both on the server side
and the client one. Benefits include:

- For clarity, the term "peer" is used to denote
  the server-side end of the service pipe, while
  "client" is used to denote the client-side
  end. This is mostly important in unit-tests
  where both live in the same process!

- Much simpler API which always returns a new peer
  IpcHandle when calling AcceptPeer() method,
  even on Win32 (see comments in implementation
  for details).

- IpcServiceHandle::AcceptClient() is buggy on Win32
  since two successive calls to it *cannot* work
  properly, even after closing the peer handle
  returned by the function.

  There is no way to fix this without breaking its
  API, hence the need for a new class, and gradually
  adapting call sites.

  This is also the root cause why [1] cannot work
  on Windows.

  Future patches will change the code to use
  IpcService instead of IpcServiceHandle where
  appropriate, and another one will remove
  IpcServiceHandle entirely when nothing uses
  it anymore.

  (Patches will be kept separate to make it
  easier to merge fixes during the next
  rebase-sync step).

[1] https://fuchsia-review.googlesource.com/c/third_party/github.com/ninja-build/ninja/+/1001534/2

Fuchsia-Topic: advanced-ipc
Change-Id: I709f1d858c1e5b3dc56cbd5c50756293a29d2491
Reviewed-on: https://fuchsia-review.googlesource.com/c/third_party/github.com/ninja-build/ninja/+/1008193
Reviewed-by: David Fang <fangism@google.com>
Fuchsia-Auto-Submit: David Turner <digit@google.com>
Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>