Google Git
Sign in
fuchsia / third_party / github.com / moby / moby / a450a575a672b90f02a4b1d3d9300ce1d70a6311
commita450a575a672b90f02a4b1d3d9300ce1d70a6311[log] [tgz]
authorKir Kolyshkin <kolyshkin@gmail.com>Fri Dec 01 12:36:18 2017 -0800
committerKir Kolyshkin <kolyshkin@gmail.com>Fri Dec 01 13:46:47 2017 -0800
treeb311c6bb1fad57f4a092da1d6ae9d13e273cfd21
parent3a9ab941adcc7a39c3ea8c52e3c215cdddb2fe67 [diff]
zfs: fix ebusy on umount

This commit is a set of fixes and improvement for zfs graph driver,
in particular:

1. Remove mount point after umount in `Get()` error path, as well
   as in `Put()` (with `MNT_DETACH` flag). This should solve "failed
   to remove root filesystem for <ID> .... dataset is busy" error
   reported in Moby issue 35642.

To reproduce the issue:

   - start dockerd with zfs
   - docker run -d --name c1 --rm busybox top
   - docker run -d --name c2 --rm busybox top
   - docker stop c1
   - docker rm c1

Output when the bug is present:
```
Error response from daemon: driver "zfs" failed to remove root
filesystem for XXX : exit status 1: "/sbin/zfs zfs destroy -r
scratch/docker/YYY" => cannot destroy 'scratch/docker/YYY':
dataset is busy
```

Output when the bug is fixed:
```
Error: No such container: c1
```
(as the container has been successfully autoremoved on stop)

2. Fix/improve error handling in `Get()` -- do not try to umount
   if `refcount` > 0

3. Simplifies unmount in `Get()`. Specifically, remove call to
   `graphdriver.Mounted()` (which checks if fs is mounted using
   `statfs()` and check for fs type) and `mount.Unmount()` (which
   parses `/proc/self/mountinfo`). Calling `unix.Unmount()` is
   simple and sufficient.

4. Add unmounting of driver's home to `Cleanup()`.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
1 file changed
tree: b311c6bb1fad57f4a092da1d6ae9d13e273cfd21
  1. .github/
  2. api/
  3. builder/
  4. cli/
  5. client/
  6. cmd/
  7. container/
  8. contrib/
  9. daemon/
  10. distribution/
  11. dockerversion/
  12. docs/
  13. hack/
  14. image/
  15. integration/
  16. integration-cli/
  17. internal/
  18. layer/
  19. libcontainerd/
  20. migrate/
  21. oci/
  22. opts/
  23. pkg/
  24. plugin/
  25. profiles/
  26. project/
  27. reference/
  28. registry/
  29. reports/
  30. restartmanager/
  31. runconfig/
  32. vendor/
  33. volume/
  34. .dockerignore
  35. .gitignore
  36. .mailmap
  37. AUTHORS
  38. CHANGELOG.md
  39. CONTRIBUTING.md
  40. Dockerfile
  41. Dockerfile.aarch64
  42. Dockerfile.armhf
  43. Dockerfile.e2e
  44. Dockerfile.ppc64le
  45. Dockerfile.s390x
  46. Dockerfile.simple
  47. Dockerfile.windows
  48. LICENSE
  49. MAINTAINERS
  50. Makefile
  51. NOTICE
  52. poule.yml
  53. README.md
  54. ROADMAP.md
  55. TESTING.md
  56. vendor.conf
  57. VENDORING.md
README.md

The Moby Project

Moby Project logo

Moby is an open-source project created by Docker to enable and accelerate software containerization.

It provides a “Lego set” of toolkit components, the framework for assembling them into custom container-based systems, and a place for all container enthusiasts and professionals to experiment and exchange ideas. Components include container build tools, a container registry, orchestration tools, a runtime and more, and these can be used as building blocks in conjunction with other tools and projects.

Principles

Moby is an open project guided by strong principles, aiming to be modular, flexible and without too strong an opinion on user experience. It is open to the community to help set its direction.

  • Modular: the project includes lots of components that have well-defined functions and APIs that work together.
  • Batteries included but swappable: Moby includes enough components to build fully featured container system, but its modular architecture ensures that most of the components can be swapped by different implementations.
  • Usable security: Moby provides secure defaults without compromising usability.
  • Developer focused: The APIs are intended to be functional and useful to build powerful tools. They are not necessarily intended as end user tools but as components aimed at developers. Documentation and UX is aimed at developers not end users.

Audience

The Moby Project is intended for engineers, integrators and enthusiasts looking to modify, hack, fix, experiment, invent and build systems based on containers. It is not for people looking for a commercially supported system, but for people who want to work and learn with open source code.

Relationship with Docker

The components and tools in the Moby Project are initially the open source components that Docker and the community have built for the Docker Project. New projects can be added if they fit with the community goals. Docker is committed to using Moby as the upstream for the Docker Product. However, other projects are also encouraged to use Moby as an upstream, and to reuse the components in diverse ways, and all these uses will be treated in the same way. External maintainers and contributors are welcomed.

The Moby project is not intended as a location for support or feature requests for Docker products, but as a place for contributors to work on open source code, fix bugs, and make the code more useful. The releases are supported by the maintainers, community and users, on a best efforts basis only, and are not intended for customers who want enterprise or commercial support; Docker EE is the appropriate product for these use cases.

Legal

Brought to you courtesy of our legal counsel. For more context, please see the NOTICE document in this repo.

Use and transfer of Moby may be subject to certain restrictions by the United States and other governments.

It is your responsibility to ensure that your use and/or transfer does not violate applicable laws.

For more information, please see https://www.bis.doc.gov

Licensing

Moby is licensed under the Apache License, Version 2.0. See LICENSE for the full license text.