Google Git Google Git
Sign in
fuchsia/third_party/github.com/intel/libva/refs/heads/upstream/master
commit
f052e984e0c8bf10784198cc311b23c567b1367f
[log]
author
intel-mediadev <MediaDev@intel.com>
Fri Oct 23 12:05:47 2026 +0800
committer
Zhang, Xinfeng <carl.zhang@intel.com>
Fri Oct 23 15:56:11 2026 +0800
tree
487ae6d10e29f3a58a931ef2a61865eef9b36d5e
parent
d1934dc9d847e06a915af9b2b651f45d31d9ae2a [diff] 
[Media_Common][Coverity] Fix NULL_FIELD dereferences in va_trace and va_dri2

Fix two Coverity NULL_FIELD defects (CID 3528231, CID 3660939):

1. va/va_trace.c (CID 3528231): In va_TraceVPrint(), fp_log is read from
   trace_ctx->plog_file->fp_log and passed directly to vfprintf/fflush without
   a null check. Since fp_log is set from fopen() output (which can return NULL
   on failure), dereferencing it unconditionally causes undefined behavior. All
   other sites in the file that use fp_log check it for null first (lines 744,
   920, 2113, 4307). Add the missing null guard before the FILE* use.

2. va/x11/va_dri2.c (CID 3660939): VA_DRI2GetBuffers_internal() dereferences
   info->codes->major_opcode without checking info->codes for null. Both callers
   validate info->codes via XextCheckExtension/XextSimpleCheckExtension before
   calling this static helper, so this cannot be triggered in current code.
   Add a defensive early-return to make the function self-guarding and consistent
   with the pattern used in sibling functions.

Resolves: VSMGWL-85794

[Internal]
Commit_Type: Bugfix
Platforms: Gen8_12, Xe_Hpm, Xe_Lpm, Xe2_Hpm, Xe2_Lpm, Xe3_Hpm, Xe3_Lpm
OS: Linux
Feature impact: Misc
Resolves: VSMGWL-85794
Related-to: N/A

Co-Authored-By: Claude Code <noreply@anthropic.com>
2 files changed
tree: 487ae6d10e29f3a58a931ef2a61865eef9b36d5e
  1. .github/
  2. build/
  3. doc/
  4. pkgconfig/
  5. va/
  6. .gitignore
  7. Android.bp
  8. autogen.sh
  9. configure.ac
  10. CONTRIBUTING.md
  11. COPYING
  12. Makefile.am
  13. meson.build
  14. meson_options.txt
  15. NEWS
  16. README.md
  17. security.md
  18. style_unify
README.md

Libva Project

Libva is an implementation for VA-API (Video Acceleration API)

VA-API is an open-source library and API specification, which provides access to graphics hardware acceleration capabilities for video processing. It consists of a main library and driver-specific acceleration backends for each supported hardware vendor.

If you would like to contribute to libva, check our Contributing guide.

We also recommend taking a look at the ‘janitorial’ bugs in our list of open issues as these bugs can be solved without an extensive knowledge of libva.

We would love to help you start contributing!

Doxygen files are regularly updated through Github Pages and can be accessed directly through github pages libva

The libva development team can be reached via github issues.

Backward Compatibility

No code changes may be introduced that would regress support for existing API. All contributions must ensure continued compatibility and functionality. Failure to maintain API compatibility may result in the rejection or reversion of the contribution.

Any deliberate modifications or removal of existing API will be transparently communicated in the release notes.

API options are solely considered as a stable interface. Any debug parameters, environmental variables, and internal data structures, are not considered as an interface and may be changed or removed at any time.

Build and Install Libva

This build documentation was tested under clear Ubuntu Server 18.04 (with gcc-7.3.0, gcc-8.1.0 and clang-6.0 compilers) but it should work on another OS distributions with various versions of gcc and clang.

Install all required common packages:

sudo apt-get install git cmake pkg-config meson libdrm-dev automake libtool

Take latest libva version:

git clone https://github.com/intel/libva.git
cd libva

Build with autogen and Meson

When you install the libva from OSV package repositories, different OSV distro use different default location for libva. Basically, Debian/Ubuntu family install libva to /usr/lib/x86_64-linux-gnu and rpm family like Fedora/CentOS/SUSE/RHEL install libva to /usr/lib64. For Other media component default location, you could refer to Install from OSV package)

Without prefix setting, libva will be install to /usr/local/lib as default. If you use other path as installation target folder or no prefix, you have to add the folder to your environment variable or use LD_LIBRARY_PATH to specify the location, like LD_LIBRARY_PATH=/usr/local/lib if no prefix.

If you intent to overwrite system default libva, you could use same OSV distro prefix, then system libva will be replaced and also your new installed libva version will be overwrited when you upgrade it from OSV distro package repository.

For debian family, you could use autogen

./autogen.sh --prefix=/usr --libdir=/usr/lib/x86_64-linux-gnu
make
sudo make install

or build using Meson

mkdir build 
cd build 
meson .. -Dprefix=/usr -Dlibdir=/usr/lib/x86_64-linux-gnu
ninja
sudo ninja install

For rpm family, you could use autogen

./autogen.sh --prefix=/usr --libdir=/usr/lib64
make
sudo make install

or build using Meson

mkdir build 
cd build 
meson .. -Dprefix=/usr -Dlibdir=/usr/lib64
ninja
sudo ninja install