commit 0e4e31197428a347842d152773b4cace4645ca25
author Andrey Abramov <aa@it-express.ru> Thu Jul 02 21:56:42 2020 +0300
committer GitHub <noreply@github.com> Thu Jul 02 13:56:42 2020 -0500
tree 6dfe4fade2a1ba2cfd25aef72398b1581fa4b8ba
parent cb32006e483f2a23230e24209cf185c65b477dbf

Fix race in NewUUID() (#64)

* Fixed race in NewUUID()

* Remove unnecessary variable

version1.go

diff --git a/version1.go b/version1.go
index 199a1ac..4631096 100644
--- a/version1.go
+++ b/version1.go
@@ -17,12 +17,6 @@
 //
 // In most cases, New should be used.
 func NewUUID() (UUID, error) {
-	nodeMu.Lock()
-	if nodeID == zeroID {
-		setNodeInterface("")
-	}
-	nodeMu.Unlock()
-
 	var uuid UUID
 	now, seq, err := GetTime()
 	if err != nil {
@@ -38,7 +32,13 @@
 	binary.BigEndian.PutUint16(uuid[4:], timeMid)
 	binary.BigEndian.PutUint16(uuid[6:], timeHi)
 	binary.BigEndian.PutUint16(uuid[8:], seq)
+
+	nodeMu.Lock()
+	if nodeID == zeroID {
+		setNodeInterface("")
+	}
 	copy(uuid[10:], nodeID[:])
+	nodeMu.Unlock()
 
 	return uuid, nil
 }